[Libreoffice-commits] core.git: desktop/source drawinglayer/source editeng/source filter/source forms/source sw/source
Jochen Nitschke
j.nitschke+logerrit at ok.de
Wed Jun 28 12:21:07 UTC 2017
desktop/source/migration/migration_impl.hxx | 10 -------
drawinglayer/source/processor3d/zbufferprocessor3d.cxx | 15 -----------
editeng/source/editeng/edtspell.cxx | 8 ------
editeng/source/editeng/edtspell.hxx | 2 -
filter/source/graphicfilter/idxf/dxfvec.hxx | 17 -------------
filter/source/xsltdialog/xmlfiltercommon.hxx | 1
filter/source/xsltdialog/xmlfiltersettingsdialog.cxx | 22 -----------------
forms/source/component/GroupManager.cxx | 8 ------
forms/source/component/GroupManager.hxx | 1
sw/source/core/doc/tblrwcl.cxx | 9 ------
10 files changed, 93 deletions(-)
New commits:
commit 594331cc811fb9a684b5f1c871b679444b8cd51d
Author: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Date: Wed Jun 28 10:23:09 2017 +0200
remove default-able copy ctors and copy operators
The implicit defined ctors and operators will copy all members
(and bases).
Since C++11 implicit copy is depreciated if there is a non-default
dtor, keep such copies.
This commit includes only types that had either copy ctor or
copy operator and were found by cppcheck.
Change-Id: I93ee687fb3b3c5884f475a2c6054955cdde57ed7
Reviewed-on: https://gerrit.libreoffice.org/39351
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/desktop/source/migration/migration_impl.hxx b/desktop/source/migration/migration_impl.hxx
index 03a99349283f..7da83d96396f 100644
--- a/desktop/source/migration/migration_impl.hxx
+++ b/desktop/source/migration/migration_impl.hxx
@@ -108,16 +108,6 @@ struct MigrationItem
m_xPopupMenu = xPopupMenu;
}
- MigrationItem& operator=(const MigrationItem& aMigrationItem)
- {
- m_sParentNodeName = aMigrationItem.m_sParentNodeName;
- m_sPrevSibling = aMigrationItem.m_sPrevSibling;
- m_sCommandURL = aMigrationItem.m_sCommandURL;
- m_xPopupMenu = aMigrationItem.m_xPopupMenu;
-
- return *this;
- }
-
bool operator==(const MigrationItem& aMigrationItem)
{
return
diff --git a/drawinglayer/source/processor3d/zbufferprocessor3d.cxx b/drawinglayer/source/processor3d/zbufferprocessor3d.cxx
index 1ce54a3bfe36..0d9354cf303c 100644
--- a/drawinglayer/source/processor3d/zbufferprocessor3d.cxx
+++ b/drawinglayer/source/processor3d/zbufferprocessor3d.cxx
@@ -403,21 +403,6 @@ public:
{
}
- RasterPrimitive3D& operator=(const RasterPrimitive3D& rComp)
- {
- mpGeoTexSvx = rComp.mpGeoTexSvx;
- mpTransparenceGeoTexSvx = rComp.mpTransparenceGeoTexSvx;
- maMaterial = rComp.maMaterial;
- maPolyPolygon = rComp.maPolyPolygon;
- mfCenterZ = rComp.mfCenterZ;
- mbModulate = rComp.mbModulate;
- mbFilter = rComp.mbFilter;
- mbSimpleTextureActive = rComp.mbSimpleTextureActive;
- mbIsLine = rComp.mbIsLine;
-
- return *this;
- }
-
bool operator<(const RasterPrimitive3D& rComp) const
{
return mfCenterZ < rComp.mfCenterZ;
diff --git a/editeng/source/editeng/edtspell.cxx b/editeng/source/editeng/edtspell.cxx
index 50dce80f5619..906091181a11 100644
--- a/editeng/source/editeng/edtspell.cxx
+++ b/editeng/source/editeng/edtspell.cxx
@@ -161,14 +161,6 @@ size_t WrongList::Valid = std::numeric_limits<size_t>::max();
WrongList::WrongList() : mnInvalidStart(0), mnInvalidEnd(Valid) {}
-WrongList::WrongList(const WrongList& r) :
- maRanges(r.maRanges),
- mnInvalidStart(r.mnInvalidStart),
- mnInvalidEnd(r.mnInvalidEnd) {}
-
-WrongList::~WrongList() {}
-
-
void WrongList::SetRanges( const std::vector<editeng::MisspellRange>& rRanges )
{
maRanges = rRanges;
diff --git a/editeng/source/editeng/edtspell.hxx b/editeng/source/editeng/edtspell.hxx
index 23105fb84425..d61ad61cab25 100644
--- a/editeng/source/editeng/edtspell.hxx
+++ b/editeng/source/editeng/edtspell.hxx
@@ -75,8 +75,6 @@ public:
typedef std::vector<editeng::MisspellRange>::const_iterator const_iterator;
WrongList();
- WrongList(const WrongList& r);
- ~WrongList();
const std::vector<editeng::MisspellRange>& GetRanges() const { return maRanges;}
void SetRanges( const std::vector<editeng::MisspellRange>& rRanges );
diff --git a/filter/source/graphicfilter/idxf/dxfvec.hxx b/filter/source/graphicfilter/idxf/dxfvec.hxx
index 03e88e166e6d..6dd5f3de5eaf 100644
--- a/filter/source/graphicfilter/idxf/dxfvec.hxx
+++ b/filter/source/graphicfilter/idxf/dxfvec.hxx
@@ -43,16 +43,6 @@ public:
nDotCount(0),
fDotLen(0),
fDistance(0) {}
-
- DXFLineInfo(const DXFLineInfo& x) :
- eStyle(x.eStyle),
- fWidth(x.fWidth),
- nDashCount(x.nDashCount),
- fDashLen(x.fDashLen),
- nDotCount(x.nDotCount),
- fDotLen(x.fDotLen),
- fDistance(x.fDistance) {}
-
};
@@ -67,7 +57,6 @@ public:
double fx,fy,fz; // public ! - why not?
inline DXFVector(double fX=0.0, double fY=0.0, double fZ=0.0);
- inline DXFVector(const DXFVector & rV);
// summation/subtraktion:
DXFVector & operator += (const DXFVector & rV);
@@ -171,12 +160,6 @@ inline DXFVector::DXFVector(double fX, double fY, double fZ)
}
-inline DXFVector::DXFVector(const DXFVector & rV)
-{
- fx=rV.fx; fy=rV.fy; fz=rV.fz;
-}
-
-
inline DXFVector & DXFVector::operator += (const DXFVector & rV)
{
fx+=rV.fx; fy+=rV.fy; fz+=rV.fz;
diff --git a/filter/source/xsltdialog/xmlfiltercommon.hxx b/filter/source/xsltdialog/xmlfiltercommon.hxx
index f29111a4912c..0f0a26c66418 100644
--- a/filter/source/xsltdialog/xmlfiltercommon.hxx
+++ b/filter/source/xsltdialog/xmlfiltercommon.hxx
@@ -62,7 +62,6 @@ public:
bool mbNeedsXSLT2;
filter_info_impl();
- filter_info_impl( const filter_info_impl& rInfo );
bool operator==( const filter_info_impl& ) const;
css::uno::Sequence< OUString > getFilterUserData() const;
diff --git a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx
index 06c80142a184..09850c095b04 100644
--- a/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx
+++ b/filter/source/xsltdialog/xmlfiltersettingsdialog.cxx
@@ -1538,28 +1538,6 @@ filter_info_impl::filter_info_impl()
{
}
-filter_info_impl::filter_info_impl( const filter_info_impl& rInfo ) :
- maFilterName( rInfo.maFilterName ),
- maType( rInfo.maType ),
- maDocumentService( rInfo.maDocumentService ),
- maFilterService( rInfo.maFilterService ),
- maInterfaceName( rInfo.maInterfaceName ),
- maComment( rInfo.maComment ),
- maExtension( rInfo.maExtension ),
- maExportXSLT( rInfo.maExportXSLT ),
- maImportXSLT( rInfo.maImportXSLT ),
- maImportTemplate( rInfo.maImportTemplate ),
- maDocType( rInfo.maDocType ),
- maImportService( rInfo.maImportService ),
- maExportService( rInfo.maExportService ),
- maFlags( rInfo.maFlags ),
- maFileFormatVersion( rInfo.maFileFormatVersion ),
- mnDocumentIconID( rInfo.mnDocumentIconID ),
- mbReadonly( rInfo.mbReadonly ),
- mbNeedsXSLT2( rInfo.mbNeedsXSLT2 )
-{
-}
-
bool filter_info_impl::operator==( const filter_info_impl& r ) const
{
return maFilterName == r.maFilterName &&
diff --git a/forms/source/component/GroupManager.cxx b/forms/source/component/GroupManager.cxx
index 3444686670cd..a925e66551e4 100644
--- a/forms/source/component/GroupManager.cxx
+++ b/forms/source/component/GroupManager.cxx
@@ -82,14 +82,6 @@ OGroupComp::OGroupComp()
{
}
-OGroupComp::OGroupComp(const OGroupComp& _rSource)
- :m_xComponent( _rSource.m_xComponent )
- ,m_xControlModel(_rSource.m_xControlModel)
- ,m_nPos( _rSource.m_nPos )
- ,m_nTabIndex( _rSource.m_nTabIndex )
-{
-}
-
OGroupComp::OGroupComp(const Reference<XPropertySet>& rxSet, sal_Int32 nInsertPos )
: m_xComponent( rxSet )
, m_xControlModel(rxSet,UNO_QUERY)
diff --git a/forms/source/component/GroupManager.hxx b/forms/source/component/GroupManager.hxx
index 35b2faabc0a3..a39f91fb6bee 100644
--- a/forms/source/component/GroupManager.hxx
+++ b/forms/source/component/GroupManager.hxx
@@ -98,7 +98,6 @@ class OGroupComp
public:
OGroupComp(const css::uno::Reference< css::beans::XPropertySet>& rxElement, sal_Int32 nInsertPos );
- OGroupComp(const OGroupComp& _rSource);
OGroupComp();
bool operator==( const OGroupComp& rComp ) const;
diff --git a/sw/source/core/doc/tblrwcl.cxx b/sw/source/core/doc/tblrwcl.cxx
index f16e1cde47a8..e6f402cace45 100644
--- a/sw/source/core/doc/tblrwcl.cxx
+++ b/sw/source/core/doc/tblrwcl.cxx
@@ -87,8 +87,6 @@ struct CpyTabFrame
explicit CpyTabFrame( SwTableBoxFormat* pAktFrameFormat ) : pNewFrameFormat( nullptr )
{ Value.pFrameFormat = pAktFrameFormat; }
- CpyTabFrame& operator=( const CpyTabFrame& );
-
bool operator==( const CpyTabFrame& rCpyTabFrame ) const
{ return (sal_uLong)Value.nSize == (sal_uLong)rCpyTabFrame.Value.nSize; }
bool operator<( const CpyTabFrame& rCpyTabFrame ) const
@@ -233,13 +231,6 @@ static bool lcl_InsDelSelLine( SwTableLine* pLine, CR_SetLineHeight& rParam,
typedef bool (*FN_lcl_SetLineHeight)(SwTableLine*, CR_SetLineHeight&, SwTwips, bool );
-CpyTabFrame& CpyTabFrame::operator=( const CpyTabFrame& rCpyTabFrame )
-{
- pNewFrameFormat = rCpyTabFrame.pNewFrameFormat;
- Value = rCpyTabFrame.Value;
- return *this;
-}
-
typedef o3tl::sorted_vector<CpyTabFrame> CpyTabFrames;
struct CpyPara
More information about the Libreoffice-commits
mailing list