[Libreoffice-commits] core.git: 2 commits - include/vcl sw/qa

Caolán McNamara caolanm at redhat.com
Fri Mar 10 08:59:25 UTC 2017


 include/vcl/bitmapaccess.hxx         |    2 --
 sw/qa/extras/ww8import/ww8import.cxx |    1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 0ae45758d1f4235f98c98f22e027ab3298e21b86
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Mar 10 08:58:13 2017 +0000

    coverity#1402149 Unchecked dynamic_cast
    
    Change-Id: I73fa2c6d3658e10728492c9766acef1eaadc5ca1

diff --git a/sw/qa/extras/ww8import/ww8import.cxx b/sw/qa/extras/ww8import/ww8import.cxx
index 4ec5ca0..c50ab96 100644
--- a/sw/qa/extras/ww8import/ww8import.cxx
+++ b/sw/qa/extras/ww8import/ww8import.cxx
@@ -83,6 +83,7 @@ DECLARE_WW8IMPORT_TEST( testTdf105570, "tdf105570.doc" )
       * Table 3 has { 0, 1, 1 }
       ****/
     SwXTextDocument* pTextDoc     = dynamic_cast<SwXTextDocument*>(mxComponent.get());
+    CPPUNIT_ASSERT(pTextDoc);
     SwDoc*           pDoc         = pTextDoc->GetDocShell()->GetDoc();
     SwWrtShell*      pWrtShell    = pDoc->GetDocShell()->GetWrtShell();
     SwShellCursor*   pShellCursor = pWrtShell->getShellCursor( false );
commit 34e9e77bf38b9ea7569f6a051505ac92eb4ae825
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Mar 10 08:56:40 2017 +0000

    coverity#1402152 Uninitialized pointer field
    
    forgot to remove this unused member
    
    Change-Id: I596d9f95284d1e27c2ca86e4c1ee75fc38cb7fce

diff --git a/include/vcl/bitmapaccess.hxx b/include/vcl/bitmapaccess.hxx
index 50eb37c..0623b74 100644
--- a/include/vcl/bitmapaccess.hxx
+++ b/include/vcl/bitmapaccess.hxx
@@ -108,8 +108,6 @@ private:
     BitmapReadAccess(const BitmapReadAccess&) = delete;
     BitmapReadAccess& operator=(const BitmapReadAccess&) = delete;
 
-private:
-    Scanline*   mpScanBuf;
 protected:
     FncGetPixel mFncGetPixel;
     FncSetPixel mFncSetPixel;


More information about the Libreoffice-commits mailing list