[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/unx

Caolán McNamara caolanm at redhat.com
Tue Mar 14 13:19:41 UTC 2017


 vcl/unx/gtk3/gtk3gtkframe.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3a4d2433fbf2ef6f41b82482ea99ed79fb2d6735
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Mar 13 12:28:12 2017 +0000

    rhbz#1431476 dnd has started copying instead of moving slides
    
    Is suspect something has changed in gtk3, and I think we're
    not supposed to use gdk_drag_drop_succeeded at this point, but
    instead we'd get a dragFailed signal on the failure case
    
    Change-Id: I6b305db56a29255b468ca9182d1f7e57cb4c10f4
    (cherry picked from commit 4ea76db5e53235971b597a2810a6d12618d6aaea)
    Reviewed-on: https://gerrit.libreoffice.org/35135
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index 4b65a55..2752fc7 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -4241,7 +4241,7 @@ void GtkDragSource::dragEnd(GdkDragContext* context)
     {
         datatransfer::dnd::DragSourceDropEvent aEv;
         aEv.DropAction = GdkToVcl(gdk_drag_context_get_selected_action(context));
-        aEv.DropSuccess = gdk_drag_drop_succeeded(context);
+        aEv.DropSuccess = true;
         auto xListener = m_xListener;
         m_xListener.clear();
         xListener->dragDropEnd(aEv);


More information about the Libreoffice-commits mailing list