[Libreoffice-commits] core.git: comphelper/source

Caolán McNamara caolanm at redhat.com
Sun Mar 19 21:35:47 UTC 2017


 comphelper/source/container/embeddedobjectcontainer.cxx |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

New commits:
commit 3f243471b57761ea523a19d5c717d06752aa2aa4
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun Mar 19 21:25:27 2017 +0000

    ofz: segv on nullptr
    
    Change-Id: I5ec64411b101972ddd150a782b845d4f790ea873

diff --git a/comphelper/source/container/embeddedobjectcontainer.cxx b/comphelper/source/container/embeddedobjectcontainer.cxx
index ea8459596957..f1d8e2bd7d99 100644
--- a/comphelper/source/container/embeddedobjectcontainer.cxx
+++ b/comphelper/source/container/embeddedobjectcontainer.cxx
@@ -240,13 +240,12 @@ bool EmbeddedObjectContainer::HasEmbeddedObjects()
 bool EmbeddedObjectContainer::HasEmbeddedObject( const OUString& rName )
 {
     EmbeddedObjectContainerNameMap::iterator aIt = pImpl->maObjectContainer.find( rName );
-    if ( aIt == pImpl->maObjectContainer.end() )
-    {
-        uno::Reference < container::XNameAccess > xAccess( pImpl->mxStorage, uno::UNO_QUERY );
-        return xAccess->hasByName(rName);
-    }
-    else
+    if (aIt != pImpl->maObjectContainer.end())
         return true;
+    uno::Reference <container::XNameAccess> xAccess(pImpl->mxStorage, uno::UNO_QUERY);
+    if (!xAccess.is())
+        return false;
+    return xAccess->hasByName(rName);
 }
 
 bool EmbeddedObjectContainer::HasEmbeddedObject( const uno::Reference < embed::XEmbeddedObject >& xObj )


More information about the Libreoffice-commits mailing list