[Libreoffice-commits] core.git: include/oox include/svl

Noel Grandin noel.grandin at collabora.co.uk
Wed Mar 29 09:25:02 UTC 2017


 include/oox/core/fastparser.hxx |    5 +++--
 include/svl/undo.hxx            |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 8c1bac8d8eb39e78a2e10993c0cd52ec28ae24de
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Wed Mar 29 09:05:39 2017 +0200

    loplugin:unnecessaryvirtual
    
    Change-Id: I5076f8700ee29cfec3875dfbc4b149229d776712
    Reviewed-on: https://gerrit.libreoffice.org/35823
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/include/oox/core/fastparser.hxx b/include/oox/core/fastparser.hxx
index bbfd28dffa8b..6af112d18d93 100644
--- a/include/oox/core/fastparser.hxx
+++ b/include/oox/core/fastparser.hxx
@@ -28,6 +28,7 @@
 #include <rtl/ustring.hxx>
 #include <rtl/ref.hxx>
 #include <sal/types.h>
+#include <oox/dllapi.h>
 
 namespace com { namespace sun { namespace star {
     namespace io { class XInputStream; }
@@ -54,7 +55,7 @@ namespace core {
 /** Wrapper for a fast SAX parser that works on automatically generated OOXML
     token and namespace identifiers.
  */
-class FastParser
+class OOX_DLLPUBLIC FastParser
 {
 public:
     /// @throws css::uno::RuntimeException
@@ -63,7 +64,7 @@ public:
                         FastParser(const FastParser&) = delete;
                         FastParser& operator=(const FastParser&) = delete;
 
-    virtual             ~FastParser();
+                        ~FastParser();
 
     /** Registers an OOXML namespace at the parser.
         @throws css::lang::IllegalArgumentException
diff --git a/include/svl/undo.hxx b/include/svl/undo.hxx
index abb892788cbf..b3301f6f6166 100644
--- a/include/svl/undo.hxx
+++ b/include/svl/undo.hxx
@@ -154,7 +154,7 @@ public:
     /// See SfxUndoAction::GetViewShellId().
     ViewShellId GetViewShellId() const override;
     virtual OUString        GetRepeatComment(SfxRepeatTarget&) const override;
-    virtual sal_uInt16      GetId() const;
+    sal_uInt16              GetId() const;
 
     void SetComment(const OUString& rComment);
     void dumpAsXml(struct _xmlTextWriter* pWriter) const override;


More information about the Libreoffice-commits mailing list