[Libreoffice-commits] libmspub.git: src/lib

David Tardon dtardon at redhat.com
Wed Mar 29 20:08:19 UTC 2017


 src/lib/MSPUBParser.cpp |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

New commits:
commit 8cd82e1a125a50d534eb5792be9d72ab35f5f7eb
Author: David Tardon <dtardon at redhat.com>
Date:   Wed Mar 29 22:07:29 2017 +0200

    avoid memory leak
    
    Change-Id: If9ad7d3b68222b3729d9180423cc2dfe1579229a

diff --git a/src/lib/MSPUBParser.cpp b/src/lib/MSPUBParser.cpp
index 992d62d..1af392e 100644
--- a/src/lib/MSPUBParser.cpp
+++ b/src/lib/MSPUBParser.cpp
@@ -2526,18 +2526,16 @@ bool MSPUBParser::parseMetaData()
   m_input->seek(0, librevenge::RVNG_SEEK_SET);
   MSPUBMetaData metaData;
 
-  librevenge::RVNGInputStream *sumaryInfo = m_input->getSubStreamByName("\x05SummaryInformation");
+  boost::scoped_ptr<librevenge::RVNGInputStream> sumaryInfo(m_input->getSubStreamByName("\x05SummaryInformation"));
   if (sumaryInfo)
   {
-    metaData.parse(sumaryInfo);
-    delete sumaryInfo;
+    metaData.parse(sumaryInfo.get());
   }
 
-  librevenge::RVNGInputStream *docSumaryInfo = m_input->getSubStreamByName("\005DocumentSummaryInformation");
+  boost::scoped_ptr<librevenge::RVNGInputStream> docSumaryInfo(m_input->getSubStreamByName("\005DocumentSummaryInformation"));
   if (docSumaryInfo)
   {
-    metaData.parse(docSumaryInfo);
-    delete docSumaryInfo;
+    metaData.parse(docSumaryInfo.get());
   }
 
   m_input->seek(0, librevenge::RVNG_SEEK_SET);


More information about the Libreoffice-commits mailing list