[Libreoffice-commits] core.git: filter/source
Thorsten Behrens
Thorsten.Behrens at CIB.de
Mon May 1 12:42:24 UTC 2017
filter/source/svg/.eslintrc.js | 250 +++++++++++++++++++++++++++++++
filter/source/svg/presentation_engine.js | 29 ++-
2 files changed, 267 insertions(+), 12 deletions(-)
New commits:
commit 7ab811b05e72a6ede72161c3e8b429424318bd29
Author: Thorsten Behrens <Thorsten.Behrens at CIB.de>
Date: Mon May 1 14:40:20 2017 +0200
filter: get svg JS code warning-free
Subsequent submissions need to pass
'eslint filter/source/svg/presentation_engine.js' w/o error.
Change-Id: If79c43844d48602d19cde8d4dd12d7e7eef674fe
diff --git a/filter/source/svg/.eslintrc.js b/filter/source/svg/.eslintrc.js
new file mode 100644
index 000000000000..12561b25aeda
--- /dev/null
+++ b/filter/source/svg/.eslintrc.js
@@ -0,0 +1,250 @@
+module.exports = {
+ "env": {
+ "browser": true,
+ "es6": true
+ },
+ "extends": "eslint:recommended",
+ "rules": {
+ "accessor-pairs": "error",
+ "array-bracket-spacing": "off",
+ "array-callback-return": "error",
+ "arrow-body-style": "error",
+ "arrow-parens": "error",
+ "arrow-spacing": "error",
+ "block-scoped-var": "off",
+ "block-spacing": [
+ "error",
+ "always"
+ ],
+ "brace-style": "off",
+ "callback-return": "error",
+ "camelcase": "off",
+ "capitalized-comments": "off",
+ "class-methods-use-this": "error",
+ "comma-dangle": "error",
+ "comma-spacing": "off",
+ "comma-style": [
+ "error",
+ "last"
+ ],
+ "complexity": "off",
+ "computed-property-spacing": "off",
+ "consistent-return": "off",
+ "consistent-this": "off",
+ "curly": "off",
+ "default-case": "off",
+ "dot-location": [
+ "error",
+ "property"
+ ],
+ "dot-notation": "off",
+ "eol-last": "error",
+ "eqeqeq": "off",
+ "func-call-spacing": "error",
+ "func-name-matching": "error",
+ "func-names": [
+ "error",
+ "never"
+ ],
+ "func-style": "off",
+ "generator-star-spacing": "error",
+ "global-require": "error",
+ "guard-for-in": "off",
+ "handle-callback-err": "error",
+ "id-blacklist": "error",
+ "id-length": "off",
+ "id-match": "error",
+ "indent": "off",
+ "init-declarations": "off",
+ "jsx-quotes": "error",
+ "key-spacing": "off",
+ "keyword-spacing": "off",
+ "line-comment-position": "off",
+ "linebreak-style": [
+ "error",
+ "unix"
+ ],
+ "lines-around-comment": "off",
+ "lines-around-directive": "off",
+ "max-depth": "off",
+ "max-len": "off",
+ "max-lines": "off",
+ "max-nested-callbacks": "error",
+ "max-params": "off",
+ "max-statements": "off",
+ "max-statements-per-line": "off",
+ "multiline-ternary": "off",
+ "new-parens": "error",
+ "newline-after-var": "off",
+ "newline-before-return": "off",
+ "newline-per-chained-call": "off",
+ "no-alert": "off",
+ "no-array-constructor": "error",
+ "no-await-in-loop": "error",
+ "no-bitwise": "off",
+ "no-caller": "error",
+ "no-catch-shadow": "error",
+ "no-compare-neg-zero": "error",
+ "no-confusing-arrow": "error",
+ "no-continue": "off",
+ "no-div-regex": "error",
+ "no-duplicate-imports": "error",
+ "no-else-return": "off",
+ "no-empty-function": "off",
+ "no-eq-null": "off",
+ "no-eval": "off",
+ "no-extend-native": "error",
+ "no-extra-bind": "error",
+ "no-extra-label": "error",
+ "no-extra-parens": "off",
+ "no-floating-decimal": "error",
+ "no-implicit-globals": "off",
+ "no-implied-eval": "off",
+ "no-inline-comments": "off",
+ "no-inner-declarations": [
+ "error",
+ "functions"
+ ],
+ "no-invalid-this": "error",
+ "no-iterator": "error",
+ "no-label-var": "error",
+ "no-labels": "error",
+ "no-lone-blocks": "error",
+ "no-lonely-if": "off",
+ "no-loop-func": "error",
+ "no-magic-numbers": "off",
+ "no-mixed-operators": "off",
+ "no-mixed-requires": "error",
+ "no-multi-assign": "off",
+ "no-multi-spaces": "off",
+ "no-multi-str": "error",
+ "no-multiple-empty-lines": "off",
+ "no-native-reassign": "error",
+ "no-negated-condition": "off",
+ "no-negated-in-lhs": "error",
+ "no-nested-ternary": "error",
+ "no-new": "error",
+ "no-new-func": "error",
+ "no-new-object": "error",
+ "no-new-require": "error",
+ "no-new-wrappers": "error",
+ "no-octal-escape": "error",
+ "no-param-reassign": "off",
+ "no-path-concat": "error",
+ "no-plusplus": "off",
+ "no-process-env": "error",
+ "no-process-exit": "error",
+ "no-proto": "error",
+ "no-prototype-builtins": "off",
+ "no-restricted-globals": "error",
+ "no-restricted-imports": "error",
+ "no-restricted-modules": "error",
+ "no-restricted-properties": "error",
+ "no-restricted-syntax": "error",
+ "no-return-assign": [
+ "error",
+ "except-parens"
+ ],
+ "no-return-await": "error",
+ "no-script-url": "error",
+ "no-self-compare": "error",
+ "no-sequences": "error",
+ "no-shadow": "off",
+ "no-shadow-restricted-names": "error",
+ "no-spaced-func": "error",
+ "no-sync": "error",
+ "no-tabs": "off",
+ "no-template-curly-in-string": "error",
+ "no-ternary": "off",
+ "no-throw-literal": "off",
+ "no-trailing-spaces": "off",
+ "no-undef-init": "off",
+ "no-undefined": "off",
+ "no-underscore-dangle": "off",
+ "no-unmodified-loop-condition": "off",
+ "no-unneeded-ternary": "off",
+ "no-unused-expressions": "error",
+ "no-use-before-define": "off",
+ "no-useless-call": "error",
+ "no-useless-computed-key": "error",
+ "no-useless-concat": "off",
+ "no-useless-constructor": "error",
+ "no-useless-escape": "error",
+ "no-useless-rename": "error",
+ "no-useless-return": "off",
+ "no-var": "off",
+ "no-void": "error",
+ "no-warning-comments": "off",
+ "no-whitespace-before-property": "error",
+ "no-with": "error",
+ "nonblock-statement-body-position": [
+ "error",
+ "any"
+ ],
+ "object-curly-newline": "off",
+ "object-curly-spacing": "off",
+ "object-property-newline": [
+ "error",
+ {
+ "allowMultiplePropertiesPerLine": true
+ }
+ ],
+ "object-shorthand": "off",
+ "one-var": "off",
+ "one-var-declaration-per-line": "off",
+ "operator-assignment": "off",
+ "operator-linebreak": "off",
+ "padded-blocks": "off",
+ "prefer-arrow-callback": "off",
+ "prefer-const": "off",
+ "prefer-destructuring": [
+ "error",
+ {
+ "array": false,
+ "object": false
+ }
+ ],
+ "prefer-numeric-literals": "error",
+ "prefer-promise-reject-errors": "error",
+ "prefer-reflect": "off",
+ "prefer-rest-params": "off",
+ "prefer-spread": "error",
+ "prefer-template": "off",
+ "quote-props": "off",
+ "quotes": [
+ "error",
+ "single"
+ ],
+ "radix": [
+ "error",
+ "as-needed"
+ ],
+ "require-await": "error",
+ "require-jsdoc": "off",
+ "rest-spread-spacing": "error",
+ "semi": "off",
+ "semi-spacing": "off",
+ "sort-imports": "error",
+ "sort-keys": "off",
+ "sort-vars": "off",
+ "space-before-blocks": "off",
+ "space-before-function-paren": "off",
+ "space-in-parens": "off",
+ "space-infix-ops": "off",
+ "space-unary-ops": "off",
+ "spaced-comment": "off",
+ "strict": "off",
+ "symbol-description": "error",
+ "template-curly-spacing": "error",
+ "template-tag-spacing": "error",
+ "unicode-bom": [
+ "error",
+ "never"
+ ],
+ "valid-jsdoc": "off",
+ "vars-on-top": "off",
+ "wrap-iife": "error",
+ "wrap-regex": "off",
+ "yield-star-spacing": "error"
+ }
+};
\ No newline at end of file
diff --git a/filter/source/svg/presentation_engine.js b/filter/source/svg/presentation_engine.js
index 735b9891efdb..8de843632ff8 100644
--- a/filter/source/svg/presentation_engine.js
+++ b/filter/source/svg/presentation_engine.js
@@ -1771,8 +1771,8 @@ var INDEX_MODE = 2;
// Mouse handler actions.
var MOUSE_UP = 1;
-var MOUSE_DOWN = 2; // TODO
-var MOUSE_MOVE = 3; // TODO
+var MOUSE_DOWN = 2; // eslint-disable-line no-unused-vars
+var MOUSE_MOVE = 3; // eslint-disable-line no-unused-vars
var MOUSE_WHEEL = 4;
// Key-codes.
@@ -1912,14 +1912,17 @@ function log( message )
{
if( typeof console == 'object' )
{
+ // eslint-disable-next-line no-console
console.log( message );
}
else if( typeof opera == 'object' )
{
opera.postError( message );
}
+ // eslint-disable-next-line no-undef
else if( typeof java == 'object' && typeof java.lang == 'object' )
{
+ // eslint-disable-next-line no-undef
java.lang.System.out.println( message );
}
}
@@ -3766,6 +3769,7 @@ function assert( condition, message )
{
presentationEngineStop();
if (typeof console == 'object')
+ // eslint-disable-next-line no-console
console.trace();
throw new Error( message );
}
@@ -4972,7 +4976,7 @@ var aClockDirectionOutMap = [ 'clockwise', 'counter-clockwise' ];
// Attribute Value Types
-var UNKNOWN_PROPERTY = 0; // TODO
+var UNKNOWN_PROPERTY = 0; // eslint-disable-line no-unused-vars
var NUMBER_PROPERTY = 1;
var ENUM_PROPERTY = 2;
var COLOR_PROPERTY = 3;
@@ -6447,17 +6451,17 @@ function getTransitionTable( eRestartMode, eFillMode )
// Event Triggers
var EVENT_TRIGGER_UNKNOWN = 0;
-var EVENT_TRIGGER_ON_SLIDE_BEGIN = 1; // TODO
-var EVENT_TRIGGER_ON_SLIDE_END = 2; // TODO
+var EVENT_TRIGGER_ON_SLIDE_BEGIN = 1; // eslint-disable-line no-unused-vars
+var EVENT_TRIGGER_ON_SLIDE_END = 2; // eslint-disable-line no-unused-vars
var EVENT_TRIGGER_BEGIN_EVENT = 3;
var EVENT_TRIGGER_END_EVENT = 4;
var EVENT_TRIGGER_ON_CLICK = 5;
-var EVENT_TRIGGER_ON_DBL_CLICK = 6; // TODO
-var EVENT_TRIGGER_ON_MOUSE_ENTER = 7; // TODO
-var EVENT_TRIGGER_ON_MOUSE_LEAVE = 8; // TODO
+var EVENT_TRIGGER_ON_DBL_CLICK = 6; // eslint-disable-line no-unused-vars
+var EVENT_TRIGGER_ON_MOUSE_ENTER = 7; // eslint-disable-line no-unused-vars
+var EVENT_TRIGGER_ON_MOUSE_LEAVE = 8; // eslint-disable-line no-unused-vars
var EVENT_TRIGGER_ON_NEXT_EFFECT = 9;
var EVENT_TRIGGER_ON_PREV_EFFECT = 10;
-var EVENT_TRIGGER_REPEAT = 11; // TODO
+var EVENT_TRIGGER_REPEAT = 11; // eslint-disable-line no-unused-vars
var aEventTriggerOutMap = [ 'unknown', 'slideBegin', 'slideEnd', 'begin', 'end', 'click',
'doubleClick', 'mouseEnter', 'mouseLeave', 'next', 'previous', 'repeat' ];
@@ -6486,11 +6490,11 @@ function getEventTriggerType( sEventTrigger )
// Timing Types
var UNKNOWN_TIMING = 0;
var OFFSET_TIMING = 1;
-var WALLCLOCK_TIMING = 2; // TODO
+var WALLCLOCK_TIMING = 2; // eslint-disable-line no-unused-vars
var INDEFINITE_TIMING = 3;
var EVENT_TIMING = 4;
var SYNCBASE_TIMING = 5;
-var MEDIA_TIMING = 6; // TODO
+var MEDIA_TIMING = 6; // eslint-disable-line no-unused-vars
var aTimingTypeOutMap = [ 'unknown', 'offset', 'wallclock', 'indefinite', 'event', 'syncbase', 'media' ];
@@ -8922,7 +8926,8 @@ function createIteratedNodes( )
* Animation Factory
**********************************************************************************************/
-
+// makeScaler is used in aAttributeMap:
+// eslint-disable-next-line no-unused-vars
function makeScaler( nScale )
{
if( ( typeof( nScale ) !== typeof( 0 ) ) || !isFinite( nScale ) )
More information about the Libreoffice-commits
mailing list