[Libreoffice-commits] core.git: forms/source formula/source include/formula reportdesign/source sc/source

Noel Grandin noel.grandin at collabora.co.uk
Tue May 2 09:33:03 UTC 2017


 forms/source/richtext/richtextimplcontrol.cxx |    2 +-
 forms/source/richtext/richtextimplcontrol.hxx |    2 +-
 forms/source/richtext/richtextvclcontrol.cxx  |    4 ++--
 formula/source/ui/dlg/formula.cxx             |   12 ++++++------
 include/formula/formula.hxx                   |    4 ++--
 reportdesign/source/ui/dlg/Formula.cxx        |    2 +-
 sc/source/ui/formdlg/formula.cxx              |    2 +-
 7 files changed, 14 insertions(+), 14 deletions(-)

New commits:
commit 29a72ca674ce9cd3d5c4ede63e2b10044f84247a
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Tue May 2 10:26:44 2017 +0200

    loplugin:checkunusedparams in forms..formula
    
    Change-Id: Iacd973b97fccda217c691cca0a8f440640ff7a0b
    Reviewed-on: https://gerrit.libreoffice.org/37140
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/forms/source/richtext/richtextimplcontrol.cxx b/forms/source/richtext/richtextimplcontrol.cxx
index 655ca5158fcd..d9ba2469e1e4 100644
--- a/forms/source/richtext/richtextimplcontrol.cxx
+++ b/forms/source/richtext/richtextimplcontrol.cxx
@@ -566,7 +566,7 @@ namespace frm
     }
 
 
-    void RichTextControlImpl::Draw( OutputDevice* _pDev, const Point& _rPos, const Size& _rSize, DrawFlags /*_nFlags*/ )
+    void RichTextControlImpl::Draw( OutputDevice* _pDev, const Point& _rPos, const Size& _rSize )
     {
         // need to normalize the map mode of the device - every paint operation on any device needs
         // to use the same map mode
diff --git a/forms/source/richtext/richtextimplcontrol.hxx b/forms/source/richtext/richtextimplcontrol.hxx
index c61c473c9100..89ea51463286 100644
--- a/forms/source/richtext/richtextimplcontrol.hxx
+++ b/forms/source/richtext/richtextimplcontrol.hxx
@@ -142,7 +142,7 @@ namespace frm
         bool    GetHideInactiveSelection() const;
 
         /// draws the control onto a given output device
-        void    Draw( OutputDevice* _pDev, const Point& _rPos, const Size& _rSize, DrawFlags _nFlags );
+        void    Draw( OutputDevice* _pDev, const Point& _rPos, const Size& _rSize );
 
         /// handles command events arrived at the anti-impl control
         long    HandleCommand( const CommandEvent& _rEvent );
diff --git a/forms/source/richtext/richtextvclcontrol.cxx b/forms/source/richtext/richtextvclcontrol.cxx
index 5ea1f430ef49..a4abd539646f 100644
--- a/forms/source/richtext/richtextvclcontrol.cxx
+++ b/forms/source/richtext/richtextvclcontrol.cxx
@@ -296,9 +296,9 @@ namespace frm
     }
 
 
-    void RichTextControl::Draw( OutputDevice* _pDev, const Point& _rPos, const Size& _rSize, DrawFlags _nFlags )
+    void RichTextControl::Draw( OutputDevice* _pDev, const Point& _rPos, const Size& _rSize, DrawFlags /*_nFlags*/ )
     {
-        m_pImpl->Draw( _pDev, _rPos, _rSize, _nFlags );
+        m_pImpl->Draw( _pDev, _rPos, _rSize );
     }
 
 
diff --git a/formula/source/ui/dlg/formula.cxx b/formula/source/ui/dlg/formula.cxx
index 2e34f5255610..304b9430478c 100644
--- a/formula/source/ui/dlg/formula.cxx
+++ b/formula/source/ui/dlg/formula.cxx
@@ -77,7 +77,7 @@ class FormulaDlg_Impl
 public:
     ::std::pair<RefButton*,RefEdit*>
         RefInputStartBefore( RefEdit* pEdit, RefButton* pButton );
-    void            RefInputStartAfter( RefEdit* pEdit, RefButton* pButton );
+    void            RefInputStartAfter();
     void            RefInputDoneAfter( bool bForced );
     bool            CalcValue( const OUString& rStrExp, OUString& rStrResult, bool bForceMatrixFormula = false );
     bool            CalcStruct( const OUString& rStrExp, bool bForceRecalcStruct = false );
@@ -1477,7 +1477,7 @@ void FormulaDlg_Impl::UpdateSelection()
     aPair.second = m_pEdRef;
     return aPair;
 }
-void FormulaDlg_Impl::RefInputStartAfter( RefEdit* /*pEdit*/, RefButton* /*pButton*/ )
+void FormulaDlg_Impl::RefInputStartAfter()
 {
     m_pRefBtn->SetEndImage();
 
@@ -1727,9 +1727,9 @@ void FormulaModalDialog::Update()
     return m_pImpl->RefInputStartBefore( pEdit, pButton );
 }
 
-void FormulaModalDialog::RefInputStartAfter( RefEdit* pEdit, RefButton* pButton )
+void FormulaModalDialog::RefInputStartAfter()
 {
-    m_pImpl->RefInputStartAfter( pEdit, pButton );
+    m_pImpl->RefInputStartAfter();
 }
 
 void FormulaModalDialog::RefInputDoneAfter()
@@ -1817,9 +1817,9 @@ void FormulaDlg::DoEnter()
     return m_pImpl->RefInputStartBefore( pEdit, pButton );
 }
 
-void FormulaDlg::RefInputStartAfter( RefEdit* pEdit, RefButton* pButton )
+void FormulaDlg::RefInputStartAfter()
 {
-    m_pImpl->RefInputStartAfter( pEdit, pButton );
+    m_pImpl->RefInputStartAfter();
 }
 
 void FormulaDlg::RefInputDoneAfter( bool bForced )
diff --git a/include/formula/formula.hxx b/include/formula/formula.hxx
index 164c673fe6d1..9b6cf62ecd19 100644
--- a/include/formula/formula.hxx
+++ b/include/formula/formula.hxx
@@ -76,7 +76,7 @@ protected:
 
     virtual bool    PreNotify( NotifyEvent& rNEvt ) override;
     ::std::pair<RefButton*,RefEdit*> RefInputStartBefore( RefEdit* pEdit, RefButton* pButton );
-    void            RefInputStartAfter( RefEdit* pEdit, RefButton* pButton );
+    void            RefInputStartAfter();
     void            RefInputDoneAfter();
 
     void            SetMeText(const OUString& _sText);
@@ -115,7 +115,7 @@ protected:
 
     virtual bool    PreNotify( NotifyEvent& rNEvt ) override;
     ::std::pair<RefButton*,RefEdit*> RefInputStartBefore( RefEdit* pEdit, RefButton* pButton );
-    void            RefInputStartAfter( RefEdit* pEdit, RefButton* pButton );
+    void            RefInputStartAfter();
     void            RefInputDoneAfter( bool bForced );
 
     void            SetMeText(const OUString& _sText);
diff --git a/reportdesign/source/ui/dlg/Formula.cxx b/reportdesign/source/ui/dlg/Formula.cxx
index 43ada4de2c16..480f017e7ac1 100644
--- a/reportdesign/source/ui/dlg/Formula.cxx
+++ b/reportdesign/source/ui/dlg/Formula.cxx
@@ -212,7 +212,7 @@ void FormulaDialog::ToggleCollapsed( RefEdit* _pEdit, RefButton* _pButton)
 
         m_pAddField->Update();
     }
-    RefInputStartAfter( aPair.second, aPair.first );
+    RefInputStartAfter();
     m_pAddField->Show();
 
 }
diff --git a/sc/source/ui/formdlg/formula.cxx b/sc/source/ui/formdlg/formula.cxx
index d2bb3521490b..76642c944d25 100644
--- a/sc/source/ui/formdlg/formula.cxx
+++ b/sc/source/ui/formdlg/formula.cxx
@@ -371,7 +371,7 @@ void ScFormulaDlg::RefInputStart( formula::RefEdit* pEdit, formula::RefButton* p
     pEdit->SetSelection(Selection(0, SELECTION_MAX));
     ::std::pair<formula::RefButton*,formula::RefEdit*> aPair = RefInputStartBefore( pEdit, pButton );
     m_aHelper.RefInputStart( aPair.second, aPair.first);
-    RefInputStartAfter( aPair.second, aPair.first );
+    RefInputStartAfter();
 }
 
 void ScFormulaDlg::RefInputDone( bool bForced )


More information about the Libreoffice-commits mailing list