[Libreoffice-commits] core.git: writerfilter/qa

Yeliz Taneroğlu yeliztaneroglu at gmail.com
Thu May 11 14:26:59 UTC 2017


 writerfilter/qa/ooxml/watch-generated-code.sh |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit e6b7caa702917bd7cf13248cc9b394518106446d
Author: Yeliz Taneroğlu <yeliztaneroglu at gmail.com>
Date:   Fri May 5 00:42:20 2017 +0300

    tdf#105204: ShellCheck nitpicks for watch-generated-code.sh
    
    Change-Id: Ic1e953b5bcae6124ee6ce7d141ddac11a94b2a8b
    Reviewed-on: https://gerrit.libreoffice.org/37464
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Michael Stahl <mstahl at redhat.com>

diff --git a/writerfilter/qa/ooxml/watch-generated-code.sh b/writerfilter/qa/ooxml/watch-generated-code.sh
index d6745731759d..22dc44011db5 100755
--- a/writerfilter/qa/ooxml/watch-generated-code.sh
+++ b/writerfilter/qa/ooxml/watch-generated-code.sh
@@ -26,16 +26,16 @@ reference)
     mkdir -p $mydir-reference/source/ooxml
     for i in $writerfilter_ALL
     do
-        cp $mydir/$i $mydir-reference/$i
+        cp $mydir/"$i" $mydir-reference/"$i"
     done
     ;;
 compare)
     for i in $writerfilter_ALL
     do
-        if [ "$(basename $i)" == "model_preprocessed.xml" ]; then
+        if [ "$(basename "$i")" == "model_preprocessed.xml" ]; then
             continue
         fi
-        diff -u $mydir-reference/$i $mydir/$i
+        diff -u $mydir-reference/"$i" $mydir/"$i"
     done
     ;;
 *)


More information about the Libreoffice-commits mailing list