[Libreoffice-commits] core.git: sc/source
Jochen Nitschke
j.nitschke+logerrit at ok.de
Fri May 12 18:32:09 UTC 2017
sc/source/filter/inc/addressconverter.hxx | 4 ++--
sc/source/filter/oox/formulaparser.cxx | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
New commits:
commit a280c61f7d2dafe10d8f9dbcfc7476a372dfd5a0
Author: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Date: Thu Mar 23 23:00:50 2017 +0100
update comments and remove TODO
TODO was addressed in commit 58c5a9de2a0b985ef81557271db39c56ceb624f9
when API version of importBiff12Formula was replaced with one using
ScAddress
Change-Id: I65629c80f8d5667c083602a87585d467d4c7dc60
Reviewed-on: https://gerrit.libreoffice.org/37555
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit at ok.de>
diff --git a/sc/source/filter/inc/addressconverter.hxx b/sc/source/filter/inc/addressconverter.hxx
index 713476b8a572..6ca497637493 100644
--- a/sc/source/filter/inc/addressconverter.hxx
+++ b/sc/source/filter/inc/addressconverter.hxx
@@ -239,7 +239,7 @@ public:
@param nSheet Sheet index for the returned address (will be checked).
@param bTrackOverflow true = Update the internal overflow flags, if
the address is outside of the supported sheet limits.
- @return A valid API cell address struct. */
+ @return A valid cell address struct. */
ScAddress createValidCellAddress(
const OUString& rString,
sal_Int16 nSheet,
@@ -278,7 +278,7 @@ public:
@param nSheet Sheet index for the returned address (will be checked).
@param bTrackOverflow true = Update the internal overflow flags, if
the address is outside of the supported sheet limits.
- @return A valid API cell address struct. */
+ @return A valid cell address struct. */
ScAddress createValidCellAddress(
const BinAddress& rBinAddress,
sal_Int16 nSheet,
diff --git a/sc/source/filter/oox/formulaparser.cxx b/sc/source/filter/oox/formulaparser.cxx
index c7d163eaba1c..f304cdda2dad 100644
--- a/sc/source/filter/oox/formulaparser.cxx
+++ b/sc/source/filter/oox/formulaparser.cxx
@@ -1252,7 +1252,6 @@ ApiTokenSequence OoxFormulaParserImpl::importOoxFormula( const ScAddress& rBaseA
return finalizeTokenArray( maApiParser.parseFormula( rFormulaString, rBaseAddr ) );
}
-// TODO: remove the importBiff12Formula function
ApiTokenSequence OoxFormulaParserImpl::importBiff12Formula( const ScAddress& rBaseAddr, FormulaType eType, SequenceInputStream& rStrm )
{
initializeImport( rBaseAddr, eType );
More information about the Libreoffice-commits
mailing list