[Libreoffice-commits] dev-tools.git: esc-reporting/esc-analyze.py

jan Iversen jani at libreoffice.org
Mon May 15 05:42:36 UTC 2017


 esc-reporting/esc-analyze.py |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 970abc0ae1ea75400352663fdbc416f38babc405
Author: jan Iversen <jani at libreoffice.org>
Date:   Mon May 15 07:42:13 2017 +0200

    esc-report: not all committers have a gerrit account

diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py
index 0b45f70..7680be1 100755
--- a/esc-reporting/esc-analyze.py
+++ b/esc-reporting/esc-analyze.py
@@ -664,19 +664,20 @@ def analyze_reports():
         if cntReview == 0 and not statList['people'][ownerEmail]['isCommitter']:
             tmpListToReview.append(entry['id'])
 
+    defaultEmail = util_check_mail('', cfg['automate']['gerritRewiewUserEmail'])
     for id in tmpListToReview:
-      reviewEmail = util_check_mail('', cfg['automate']['gerritRewiewUserEmail'])
+      reviewEmail = defaultEmail
       txt = gerritData['patch'][id]['subject']
       if txt.startswith('tdf#'):
         try:
           row = bugzillaData['bugs'][re.findall('\d+', txt)[0]]
           ownerEmail = util_check_mail(row['creator_detail']['name'], row['creator_detail']['email'])
-          if statList['people'][ownerEmail]['isCommitter']:
+          if 'reviewName' in statList['people'][ownerEmail]['gerrit']:
             reviewEmail = ownerEmail
           else:
             for comment in row['comments']:
               email = util_check_mail('', comment['creator'])
-              if not email == 'anistenis at gmail.com' and not email == 'jani at documentfoundation.org' and statList['people'][email]['isCommitter']:
+              if not email == 'anistenis at gmail.com' and not email == 'jani at documentfoundation.org' and 'reviewName' in statList['people'][ownerEmail]['gerrit']:
                 reviewEmail = email
                 break
         except Exception as e:


More information about the Libreoffice-commits mailing list