[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - cui/source

Julien Nabet serval2412 at yahoo.fr
Mon May 15 21:16:52 UTC 2017


 cui/source/options/optchart.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6eb0df62aaa00f2c1508b1650e8df3145822f84f
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sun May 14 00:35:21 2017 +0200

    fix gdi resource leak with unreleased virtual device
    
    (copycat Markus https://cgit.freedesktop.org/libreoffice/core/commit/?id=289711c2a469bfbe06aef3b3870b65f9c788f56d)
    
    Change-Id: I3974609559dd44257d7c3e9e9544348d622953f6
    Reviewed-on: https://gerrit.libreoffice.org/37586
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
    (cherry picked from commit 11c4cc15fdd491e15ffd4e7d9fb5d4082898f926)
    Reviewed-on: https://gerrit.libreoffice.org/37591
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/cui/source/options/optchart.cxx b/cui/source/options/optchart.cxx
index 060d3b0b6587..b4eb31b072d1 100644
--- a/cui/source/options/optchart.cxx
+++ b/cui/source/options/optchart.cxx
@@ -43,7 +43,7 @@ void SvxDefaultColorOptPage::InsertColorEntry(const XColorEntry& rEntry, sal_Int
     const StyleSettings& rStyleSettings = Application::GetSettings().GetStyleSettings();
     Size aImageSize = rStyleSettings.GetListBoxPreviewDefaultPixelSize();
 
-    VclPtr<VirtualDevice> xDevice = VclPtr<VirtualDevice>::Create();
+    ScopedVclPtrInstance<VirtualDevice> xDevice;
     xDevice->SetOutputSize(aImageSize);
     const Rectangle aRect(Point(0, 0), aImageSize);
     xDevice->SetFillColor(rColor);


More information about the Libreoffice-commits mailing list