[Libreoffice-commits] core.git: sc/qa sc/source
Noel Grandin
noel.grandin at collabora.co.uk
Tue May 16 02:19:57 UTC 2017
sc/qa/unit/ucalc_condformat.cxx | 2 +-
sc/qa/unit/ucalc_sharedformula.cxx | 2 +-
sc/source/ui/docshell/docfunc.cxx | 10 +++++-----
sc/source/ui/docshell/docsh3.cxx | 2 +-
sc/source/ui/drawfunc/graphsh.cxx | 10 +++++-----
sc/source/ui/inc/acredlin.hxx | 5 ++---
sc/source/ui/inc/autofmt.hxx | 2 +-
sc/source/ui/inc/docfunc.hxx | 10 +++++-----
sc/source/ui/inc/tabcont.hxx | 4 ++--
sc/source/ui/miscdlgs/acredlin.cxx | 24 ++++++++----------------
sc/source/ui/miscdlgs/autofmt.cxx | 6 +++---
sc/source/ui/navipi/navipi.cxx | 2 +-
sc/source/ui/unoobj/cellsuno.cxx | 14 +++++++-------
sc/source/ui/unoobj/docuno.cxx | 18 +++++++++---------
sc/source/ui/view/cellsh4.cxx | 2 +-
sc/source/ui/view/reffact.cxx | 2 +-
sc/source/ui/view/spelldialog.cxx | 2 +-
sc/source/ui/view/tabcont.cxx | 4 ++--
sc/source/ui/view/tabvwshf.cxx | 4 ++--
sc/source/ui/view/viewfun2.cxx | 6 +++---
sc/source/ui/view/viewfunc.cxx | 4 ++--
21 files changed, 63 insertions(+), 72 deletions(-)
New commits:
commit 774f033f86b3728123842321f21b10b400cf6b9a
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Mon May 15 14:49:33 2017 +0200
loplugin:checkunusedparams in sc(part5)
Change-Id: If969b989ed16e58fba26ae0fec06759da855a5ad
Reviewed-on: https://gerrit.libreoffice.org/37646
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/sc/qa/unit/ucalc_condformat.cxx b/sc/qa/unit/ucalc_condformat.cxx
index 17e4e5d52d3d..60344c248bde 100644
--- a/sc/qa/unit/ucalc_condformat.cxx
+++ b/sc/qa/unit/ucalc_condformat.cxx
@@ -211,7 +211,7 @@ void Test::testCondFormatInsertDeleteSheets()
CPPUNIT_ASSERT_EQUAL_MESSAGE("Format should be applied to B2:B4 on the 2nd sheet after the sheet insertion.", ScRange(1,1,1,1,3,1), *pRange);
// Delete the sheet to the left.
- bool bDeleted = rFunc.DeleteTable(0, true, true);
+ bool bDeleted = rFunc.DeleteTable(0, true);
CPPUNIT_ASSERT(bDeleted);
pList = m_pDoc->GetCondFormList(0);
diff --git a/sc/qa/unit/ucalc_sharedformula.cxx b/sc/qa/unit/ucalc_sharedformula.cxx
index a85baa17879c..204e9dfaef30 100644
--- a/sc/qa/unit/ucalc_sharedformula.cxx
+++ b/sc/qa/unit/ucalc_sharedformula.cxx
@@ -1211,7 +1211,7 @@ void Test::testSharedFormulasRefUpdateDeleteSheets()
// Delete Sheet2.
ScDocFunc& rFunc = getDocShell().GetDocFunc();
- rFunc.DeleteTable(1, true, true);
+ rFunc.DeleteTable(1, true);
ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(0,0,0), "#REF!.B2", "Wrong formula");
ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(0,1,0), "#REF!.B3", "Wrong formula");
diff --git a/sc/source/ui/docshell/docfunc.cxx b/sc/source/ui/docshell/docfunc.cxx
index 06a0030c1aac..acf6ec9692b5 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -3097,7 +3097,7 @@ bool ScDocFunc::InsertTable( SCTAB nTab, const OUString& rName, bool bRecord, bo
return bSuccess;
}
-bool ScDocFunc::DeleteTable( SCTAB nTab, bool bRecord, bool /* bApi */ )
+bool ScDocFunc::DeleteTable( SCTAB nTab, bool bRecord )
{
WaitObject aWait( ScDocShell::GetActiveDialogParent() );
@@ -3249,7 +3249,7 @@ void ScDocFunc::SetTableVisible( SCTAB nTab, bool bVisible, bool bApi )
aModificator.SetDocumentModified();
}
-bool ScDocFunc::SetLayoutRTL( SCTAB nTab, bool bRTL, bool /* bApi */ )
+bool ScDocFunc::SetLayoutRTL( SCTAB nTab, bool bRTL )
{
ScDocument& rDoc = rDocShell.GetDocument();
bool bUndo(rDoc.IsUndoEnabled());
@@ -3602,7 +3602,7 @@ bool ScDocFunc::SetWidthOrHeight(
}
bool ScDocFunc::InsertPageBreak( bool bColumn, const ScAddress& rPos,
- bool bRecord, bool bSetModified, bool /* bApi */ )
+ bool bRecord, bool bSetModified )
{
ScDocShellModificator aModificator( rDocShell );
@@ -3666,7 +3666,7 @@ bool ScDocFunc::InsertPageBreak( bool bColumn, const ScAddress& rPos,
}
bool ScDocFunc::RemovePageBreak( bool bColumn, const ScAddress& rPos,
- bool bRecord, bool bSetModified, bool /* bApi */ )
+ bool bRecord, bool bSetModified )
{
ScDocShellModificator aModificator( rDocShell );
@@ -3754,7 +3754,7 @@ void ScDocFunc::ProtectSheet( SCTAB nTab, const ScTableProtection& rProtect )
aModificator.SetDocumentModified();
}
-bool ScDocFunc::Protect( SCTAB nTab, const OUString& rPassword, bool /*bApi*/ )
+bool ScDocFunc::Protect( SCTAB nTab, const OUString& rPassword )
{
ScDocument& rDoc = rDocShell.GetDocument();
if (nTab == TABLEID_DOC)
diff --git a/sc/source/ui/docshell/docsh3.cxx b/sc/source/ui/docshell/docsh3.cxx
index 8a75619c2157..2a6e39bad2f9 100644
--- a/sc/source/ui/docshell/docsh3.cxx
+++ b/sc/source/ui/docshell/docsh3.cxx
@@ -1031,7 +1031,7 @@ void ScDocShell::MergeDocument( ScDocument& rOtherDoc, bool bShared, bool bCheck
(void)GetDocFunc().InsertCells( aSourceRange, nullptr, INS_INSCOLS_BEFORE, true, false );
break;
case SC_CAT_DELETE_TABS :
- (void)GetDocFunc().DeleteTable( aSourceRange.aStart.Tab(), true, false );
+ (void)GetDocFunc().DeleteTable( aSourceRange.aStart.Tab(), true );
break;
case SC_CAT_DELETE_ROWS:
{
diff --git a/sc/source/ui/drawfunc/graphsh.cxx b/sc/source/ui/drawfunc/graphsh.cxx
index 41defd63a6fb..7077711154fa 100644
--- a/sc/source/ui/drawfunc/graphsh.cxx
+++ b/sc/source/ui/drawfunc/graphsh.cxx
@@ -153,7 +153,7 @@ void ScGraphicShell::GetExternalEditState( SfxItemSet& rSet )
rSet.DisableItem( SID_EXTERNAL_EDIT );
}
-void ScGraphicShell::ExecuteExternalEdit( SfxRequest& )
+void ScGraphicShell::ExecuteExternalEdit( SAL_UNUSED_PARAMETER SfxRequest& )
{
ScDrawView* pView = GetViewData()->GetScDrawView();
const SdrMarkList& rMarkList = pView->GetMarkedObjectList();
@@ -191,7 +191,7 @@ void ScGraphicShell::GetCompressGraphicState( SfxItemSet& rSet )
rSet.DisableItem( SID_COMPRESS_GRAPHIC );
}
-void ScGraphicShell::ExecuteCompressGraphic( SfxRequest& )
+void ScGraphicShell::ExecuteCompressGraphic( SAL_UNUSED_PARAMETER SfxRequest& )
{
ScDrawView* pView = GetViewData()->GetScDrawView();
const SdrMarkList& rMarkList = pView->GetMarkedObjectList();
@@ -236,7 +236,7 @@ void ScGraphicShell::GetCropGraphicState( SfxItemSet& rSet )
rSet.DisableItem( SID_OBJECT_CROP );
}
-void ScGraphicShell::ExecuteCropGraphic( SfxRequest& )
+void ScGraphicShell::ExecuteCropGraphic( SAL_UNUSED_PARAMETER SfxRequest& )
{
ScDrawView* pView = GetViewData()->GetScDrawView();
const SdrMarkList& rMarkList = pView->GetMarkedObjectList();
@@ -255,7 +255,7 @@ void ScGraphicShell::ExecuteCropGraphic( SfxRequest& )
Invalidate();
}
-void ScGraphicShell::ExecuteSaveGraphic(SfxRequest& /*rReq*/)
+void ScGraphicShell::ExecuteSaveGraphic( SAL_UNUSED_PARAMETER SfxRequest& /*rReq*/)
{
ScDrawView* pView = GetViewData()->GetScDrawView();
const SdrMarkList& rMarkList = pView->GetMarkedObjectList();
@@ -291,7 +291,7 @@ void ScGraphicShell::GetSaveGraphicState(SfxItemSet &rSet)
rSet.DisableItem( SID_SAVE_GRAPHIC );
}
-void ScGraphicShell::ExecuteChangePicture(SfxRequest& /*rReq*/)
+void ScGraphicShell::ExecuteChangePicture( SAL_UNUSED_PARAMETER SfxRequest& /*rReq*/)
{
ScDrawView* pView = GetViewData()->GetScDrawView();
const SdrMarkList& rMarkList = pView->GetMarkedObjectList();
diff --git a/sc/source/ui/inc/acredlin.hxx b/sc/source/ui/inc/acredlin.hxx
index 90525c51f356..f6917ed1f91e 100644
--- a/sc/source/ui/inc/acredlin.hxx
+++ b/sc/source/ui/inc/acredlin.hxx
@@ -120,7 +120,7 @@ protected:
OUString* MakeTypeString(ScChangeActionType eType);
SvTreeListEntry* AppendChangeAction(
- const ScChangeAction* pScChangeAction,ScChangeActionState eState,
+ const ScChangeAction* pScChangeAction,
SvTreeListEntry* pParent=nullptr,bool bDelMaster = false,
bool bDisabled = false);
@@ -145,8 +145,7 @@ protected:
bool InsertChildren( ScChangeActionMap* pActionMap, SvTreeListEntry* pParent );
- void AppendChanges(ScChangeTrack* pChanges,sal_uLong nStartAction, sal_uLong nEndAction,
- sal_uLong nPos=TREELIST_APPEND);
+ void AppendChanges(ScChangeTrack* pChanges,sal_uLong nStartAction, sal_uLong nEndAction);
void RemoveEntrys(sal_uLong nStartAction,sal_uLong nEndAction);
void UpdateEntrys(ScChangeTrack* pChgTrack, sal_uLong nStartAction,sal_uLong nEndAction);
diff --git a/sc/source/ui/inc/autofmt.hxx b/sc/source/ui/inc/autofmt.hxx
index 8df8a45c3a64..17be4ab7d0e5 100644
--- a/sc/source/ui/inc/autofmt.hxx
+++ b/sc/source/ui/inc/autofmt.hxx
@@ -76,7 +76,7 @@ private:
SvNumberFormatter* pNumFmt;
SAL_DLLPRIVATE void Init();
- SAL_DLLPRIVATE void DoPaint(vcl::RenderContext& rRenderContext, const tools::Rectangle& rRect);
+ SAL_DLLPRIVATE void DoPaint(vcl::RenderContext& rRenderContext);
SAL_DLLPRIVATE void CalcCellArray(bool bFitWidth);
SAL_DLLPRIVATE void CalcLineMap();
SAL_DLLPRIVATE void PaintCells(vcl::RenderContext& rRenderContext);
diff --git a/sc/source/ui/inc/docfunc.hxx b/sc/source/ui/inc/docfunc.hxx
index db006875c3c2..a2010c4ac6c3 100644
--- a/sc/source/ui/inc/docfunc.hxx
+++ b/sc/source/ui/inc/docfunc.hxx
@@ -134,27 +134,27 @@ public:
SC_DLLPUBLIC bool InsertTable( SCTAB nTab, const OUString& rName, bool bRecord, bool bApi );
bool RenameTable( SCTAB nTab, const OUString& rName, bool bRecord, bool bApi );
- bool DeleteTable( SCTAB nTab, bool bRecord, bool bApi );
+ bool DeleteTable( SCTAB nTab, bool bRecord );
bool SetTabBgColor( SCTAB nTab, const Color& rColor, bool bRecord, bool bApi );
bool SetTabBgColor( ScUndoTabColorInfo::List& rUndoTabColorList, bool bApi );
void SetTableVisible( SCTAB nTab, bool bVisible, bool bApi );
- bool SetLayoutRTL( SCTAB nTab, bool bRTL, bool bApi );
+ bool SetLayoutRTL( SCTAB nTab, bool bRTL );
SC_DLLPUBLIC bool SetWidthOrHeight(
bool bWidth, const std::vector<sc::ColRowSpan>& rRanges, SCTAB nTab,
ScSizeMode eMode, sal_uInt16 nSizeTwips, bool bRecord, bool bApi );
bool InsertPageBreak( bool bColumn, const ScAddress& rPos,
- bool bRecord, bool bSetModified, bool bApi );
+ bool bRecord, bool bSetModified );
bool RemovePageBreak( bool bColumn, const ScAddress& rPos,
- bool bRecord, bool bSetModified, bool bApi );
+ bool bRecord, bool bSetModified );
void ProtectSheet( SCTAB nTab, const ScTableProtection& rProtect );
- bool Protect( SCTAB nTab, const OUString& rPassword, bool bApi );
+ bool Protect( SCTAB nTab, const OUString& rPassword );
bool Unprotect( SCTAB nTab, const OUString& rPassword, bool bApi );
void ClearItems( const ScMarkData& rMark, const sal_uInt16* pWhich, bool bApi );
diff --git a/sc/source/ui/inc/tabcont.hxx b/sc/source/ui/inc/tabcont.hxx
index 5434c7b61259..f21e87df6c23 100644
--- a/sc/source/ui/inc/tabcont.hxx
+++ b/sc/source/ui/inc/tabcont.hxx
@@ -37,9 +37,9 @@ private:
sal_uInt16 nSelPageIdByMouse; /// Selected page ID, if selected with mouse
bool bErrorShown;
- void DoDrag( const vcl::Region& rRegion );
+ void DoDrag();
- sal_uInt16 GetMaxId() const;
+ sal_uInt16 GetMaxId() const;
SCTAB GetPrivatDropPos(const Point& rPos );
DECL_LINK(ShowPageList, const CommandEvent&, void);
diff --git a/sc/source/ui/miscdlgs/acredlin.cxx b/sc/source/ui/miscdlgs/acredlin.cxx
index 20f6f5286c11..996f0719c2d7 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -359,7 +359,7 @@ bool ScAcceptChgDlg::IsValidAction(const ScChangeAction* pScChangeAction)
}
SvTreeListEntry* ScAcceptChgDlg::AppendChangeAction(
- const ScChangeAction* pScChangeAction, ScChangeActionState /*eState*/,
+ const ScChangeAction* pScChangeAction,
SvTreeListEntry* pParent, bool bDelMaster,bool bDisabled)
{
ScChangeTrack* pChanges=pDoc->GetChangeTrack();
@@ -781,7 +781,7 @@ void ScAcceptChgDlg::UpdateView()
if(pScChangeAction->IsDialogRoot())
{
if(pScChangeAction->IsDialogParent())
- pParent=AppendChangeAction(pScChangeAction,SC_CAS_VIRGIN);
+ pParent=AppendChangeAction(pScChangeAction);
else
pParent=AppendFilteredAction(pScChangeAction,SC_CAS_VIRGIN);
}
@@ -1229,7 +1229,7 @@ bool ScAcceptChgDlg::InsertChildren(ScChangeActionMap* pActionMap,SvTreeListEntr
for( itChangeAction = pActionMap->begin(); itChangeAction != pActionMap->end(); ++itChangeAction )
{
- SvTreeListEntry* pEntry=AppendChangeAction( itChangeAction->second, SC_CAS_VIRGIN, pParent, false, true );
+ SvTreeListEntry* pEntry=AppendChangeAction( itChangeAction->second, pParent, false, true );
if(pEntry!=nullptr)
{
@@ -1259,9 +1259,9 @@ bool ScAcceptChgDlg::InsertDeletedChildren(const ScChangeAction* pScChangeAction
{
if( pScChangeAction != itChangeAction->second )
- pEntry = AppendChangeAction( itChangeAction->second, SC_CAS_VIRGIN, pParent, false, true );
+ pEntry = AppendChangeAction( itChangeAction->second, pParent, false, true );
else
- pEntry = AppendChangeAction( itChangeAction->second, SC_CAS_VIRGIN, pParent, true, true );
+ pEntry = AppendChangeAction( itChangeAction->second, pParent, true, true );
if(pEntry!=nullptr)
{
@@ -1382,7 +1382,7 @@ IMPL_LINK( ScAcceptChgDlg, ExpandingHandle, SvTreeListBox*, pTable, bool )
}
void ScAcceptChgDlg::AppendChanges(ScChangeTrack* pChanges,sal_uLong nStartAction,
- sal_uLong nEndAction, sal_uLong /* nPos */)
+ sal_uLong nEndAction)
{
if(pChanges!=nullptr)
{
@@ -1411,7 +1411,7 @@ void ScAcceptChgDlg::AppendChanges(ScChangeTrack* pChanges,sal_uLong nStartActio
if(pScChangeAction->IsDialogRoot())
{
if(pScChangeAction->IsDialogParent())
- pParent=AppendChangeAction(pScChangeAction,SC_CAS_VIRGIN);
+ pParent=AppendChangeAction(pScChangeAction);
else
pParent=AppendFilteredAction(pScChangeAction,SC_CAS_VIRGIN);
}
@@ -1507,9 +1507,6 @@ void ScAcceptChgDlg::UpdateEntrys(ScChangeTrack* pChgTrack, sal_uLong nStartActi
{
pTheView->SetUpdateMode(false);
- sal_uLong nPos=TREELIST_APPEND;
-
-
SvTreeListEntry* pEntry=pTheView->First();
SvTreeListEntry* pLastEntry=nullptr;
while(pEntry!=nullptr)
@@ -1529,7 +1526,6 @@ void ScAcceptChgDlg::UpdateEntrys(ScChangeTrack* pChgTrack, sal_uLong nStartActi
SvTreeListEntry* pNextEntry;
if(bRemove)
{
- nPos=pEntry->GetChildListPos();
pTheView->RemoveEntry(pEntry);
if(pLastEntry==nullptr) pLastEntry=pTheView->First();
@@ -1555,13 +1551,9 @@ void ScAcceptChgDlg::UpdateEntrys(ScChangeTrack* pChgTrack, sal_uLong nStartActi
pEntry=pNextEntry;
}
- if(nStartAction==nEndAction)
- AppendChanges(pChgTrack,nStartAction,nEndAction,nPos);
- else
- AppendChanges(pChgTrack,nStartAction,nEndAction);
+ AppendChanges(pChgTrack,nStartAction,nEndAction);
pTheView->SetUpdateMode(true);
-
}
IMPL_LINK( ScAcceptChgDlg, ChgTrackModHdl, ScChangeTrack&, rChgTrack, void)
diff --git a/sc/source/ui/miscdlgs/autofmt.cxx b/sc/source/ui/miscdlgs/autofmt.cxx
index 15637dd3a26d..ee19ebcf9d3c 100644
--- a/sc/source/ui/miscdlgs/autofmt.cxx
+++ b/sc/source/ui/miscdlgs/autofmt.cxx
@@ -480,7 +480,7 @@ void ScAutoFmtPreview::NotifyChange( ScAutoFormatData* pNewData )
Invalidate(tools::Rectangle(Point(0,0), GetSizePixel()));
}
-void ScAutoFmtPreview::DoPaint(vcl::RenderContext& rRenderContext, const tools::Rectangle& /*rRect*/)
+void ScAutoFmtPreview::DoPaint(vcl::RenderContext& rRenderContext)
{
DrawModeFlags nOldDrawMode = aVD->GetDrawMode();
@@ -510,9 +510,9 @@ void ScAutoFmtPreview::DoPaint(vcl::RenderContext& rRenderContext, const tools::
aVD->SetDrawMode(nOldDrawMode);
}
-void ScAutoFmtPreview::Paint(vcl::RenderContext& rRenderContext, const tools::Rectangle& rRect)
+void ScAutoFmtPreview::Paint(vcl::RenderContext& rRenderContext, const tools::Rectangle& /*rRect*/)
{
- DoPaint(rRenderContext, rRect);
+ DoPaint(rRenderContext);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/navipi/navipi.cxx b/sc/source/ui/navipi/navipi.cxx
index a3f07db46431..ca1e861c738e 100644
--- a/sc/source/ui/navipi/navipi.cxx
+++ b/sc/source/ui/navipi/navipi.cxx
@@ -437,7 +437,7 @@ SFX_IMPL_CHILDWINDOWCONTEXT( ScNavigatorDialogWrapper, SID_NAVIGATOR )
ScNavigatorDialogWrapper::ScNavigatorDialogWrapper(vcl::Window* pParent,
sal_uInt16 nId,
SfxBindings* pBind,
- SfxChildWinInfo* /* pInfo */)
+ SAL_UNUSED_PARAMETER SfxChildWinInfo* /* pInfo */)
: SfxChildWindowContext(nId)
{
pNavigator = VclPtr<ScNavigatorDlg>::Create(pBind, pParent);
diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx
index c5fb3990c77c..70eb3beb33b0 100644
--- a/sc/source/ui/unoobj/cellsuno.cxx
+++ b/sc/source/ui/unoobj/cellsuno.cxx
@@ -7743,7 +7743,7 @@ void SAL_CALL ScTableSheetObj::protect( const OUString& aPassword )
// #i108245# if already protected, don't change anything
if ( pDocSh && !pDocSh->GetDocument().IsTabProtected( GetTab_Impl() ) )
{
- pDocSh->GetDocFunc().Protect( GetTab_Impl(), aPassword, true );
+ pDocSh->GetDocFunc().Protect( GetTab_Impl(), aPassword );
}
}
@@ -8234,9 +8234,9 @@ void ScTableSheetObj::SetOnePropertyValue( const SfxItemPropertySimpleEntry* pEn
if (aValue >>= nValue)
{
if (nValue == css::text::WritingMode2::RL_TB)
- rFunc.SetLayoutRTL(nTab, true, true);
+ rFunc.SetLayoutRTL(nTab, true);
else
- rFunc.SetLayoutRTL(nTab, false, true);
+ rFunc.SetLayoutRTL(nTab, false);
}
}
else if ( pEntry->nWID == SC_WID_UNO_AUTOPRINT )
@@ -8621,9 +8621,9 @@ void ScTableColumnObj::SetOnePropertyValue(const SfxItemPropertySimpleEntry* pEn
{
bool bSet = ScUnoHelpFunctions::GetBoolFromAny( aValue );
if (bSet)
- rFunc.InsertPageBreak( true, rRange.aStart, true, true, true );
+ rFunc.InsertPageBreak( true, rRange.aStart, true, true );
else
- rFunc.RemovePageBreak( true, rRange.aStart, true, true, true );
+ rFunc.RemovePageBreak( true, rRange.aStart, true, true );
}
else
ScCellRangeObj::SetOnePropertyValue(pEntry, aValue); // base class, no Item WID
@@ -8768,9 +8768,9 @@ void ScTableRowObj::SetOnePropertyValue( const SfxItemPropertySimpleEntry* pEntr
{
bool bSet = ScUnoHelpFunctions::GetBoolFromAny( aValue );
if (bSet)
- rFunc.InsertPageBreak( false, rRange.aStart, true, true, true );
+ rFunc.InsertPageBreak( false, rRange.aStart, true, true );
else
- rFunc.RemovePageBreak( false, rRange.aStart, true, true, true );
+ rFunc.RemovePageBreak( false, rRange.aStart, true, true );
}
else
ScCellRangeObj::SetOnePropertyValue(pEntry, aValue); // base class, no Item WID
diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index 49e3e0633d1b..7cfd874a354c 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -1997,7 +1997,7 @@ void SAL_CALL ScModelObj::protect( const OUString& aPassword )
// #i108245# if already protected, don't change anything
if ( pDocShell && !pDocShell->GetDocument().IsDocProtected() )
{
- pDocShell->GetDocFunc().Protect( TABLEID_DOC, aPassword, true );
+ pDocShell->GetDocFunc().Protect( TABLEID_DOC, aPassword );
}
}
@@ -3089,7 +3089,7 @@ void SAL_CALL ScDrawPagesObj::remove( const uno::Reference<drawing::XDrawPage>&
if (pPage)
{
SCTAB nPageNum = static_cast<SCTAB>(pPage->GetPageNum());
- pDocShell->GetDocFunc().DeleteTable( nPageNum, true, true );
+ pDocShell->GetDocFunc().DeleteTable( nPageNum, true );
}
}
}
@@ -3293,7 +3293,7 @@ void SAL_CALL ScTableSheetsObj::replaceByName( const OUString& aName, const uno:
SCTAB nPosition;
if ( pDocShell->GetDocument().GetTable( aName, nPosition ) )
{
- if ( pDocShell->GetDocFunc().DeleteTable( nPosition, true, true ) )
+ if ( pDocShell->GetDocFunc().DeleteTable( nPosition, true ) )
{
// InsertTable can't really go wrong now
bDone = pDocShell->GetDocFunc().InsertTable( nPosition, aName, true, true );
@@ -3331,7 +3331,7 @@ void SAL_CALL ScTableSheetsObj::removeByName( const OUString& aName )
{
SCTAB nIndex;
if ( pDocShell->GetDocument().GetTable( aName, nIndex ) )
- bDone = pDocShell->GetDocFunc().DeleteTable( nIndex, true, true );
+ bDone = pDocShell->GetDocFunc().DeleteTable( nIndex, true );
else // not found
throw container::NoSuchElementException();
}
@@ -3707,9 +3707,9 @@ void SAL_CALL ScTableColumnsObj::setPropertyValue(
bool bSet = ScUnoHelpFunctions::GetBoolFromAny( aValue );
for (SCCOL nCol=nStartCol; nCol<=nEndCol; nCol++)
if (bSet)
- rFunc.InsertPageBreak( true, ScAddress(nCol,0,nTab), true, true, true );
+ rFunc.InsertPageBreak( true, ScAddress(nCol,0,nTab), true, true );
else
- rFunc.RemovePageBreak( true, ScAddress(nCol,0,nTab), true, true, true );
+ rFunc.RemovePageBreak( true, ScAddress(nCol,0,nTab), true, true );
}
}
@@ -3952,9 +3952,9 @@ void SAL_CALL ScTableRowsObj::setPropertyValue(
bool bSet = ScUnoHelpFunctions::GetBoolFromAny( aValue );
for (SCROW nRow=nStartRow; nRow<=nEndRow; nRow++)
if (bSet)
- rFunc.InsertPageBreak( false, ScAddress(0,nRow,nTab), true, true, true );
+ rFunc.InsertPageBreak( false, ScAddress(0,nRow,nTab), true, true );
else
- rFunc.RemovePageBreak( false, ScAddress(0,nRow,nTab), true, true, true );
+ rFunc.RemovePageBreak( false, ScAddress(0,nRow,nTab), true, true );
}
else if ( aPropertyName == SC_UNONAME_CELLBACK || aPropertyName == SC_UNONAME_CELLTRAN )
{
@@ -4280,7 +4280,7 @@ void SAL_CALL ScScenariosObj::removeByName( const OUString& aName )
SolarMutexGuard aGuard;
SCTAB nIndex;
if ( pDocShell && GetScenarioIndex_Impl( aName, nIndex ) )
- pDocShell->GetDocFunc().DeleteTable( nTab+nIndex+1, true, true );
+ pDocShell->GetDocFunc().DeleteTable( nTab+nIndex+1, true );
}
// XEnumerationAccess
diff --git a/sc/source/ui/view/cellsh4.cxx b/sc/source/ui/view/cellsh4.cxx
index 3b565efeaa3a..d466751f3e37 100644
--- a/sc/source/ui/view/cellsh4.cxx
+++ b/sc/source/ui/view/cellsh4.cxx
@@ -240,7 +240,7 @@ void ScCellShell::ExecuteCursor( SfxRequest& rReq )
rReq.Done();
}
-void ScCellShell::GetStateCursor( SfxItemSet& /* rSet */ )
+void ScCellShell::GetStateCursor( SAL_UNUSED_PARAMETER SfxItemSet& /* rSet */ )
{
}
diff --git a/sc/source/ui/view/reffact.cxx b/sc/source/ui/view/reffact.cxx
index c6f6e39e604e..d843cb50fbcc 100644
--- a/sc/source/ui/view/reffact.cxx
+++ b/sc/source/ui/view/reffact.cxx
@@ -279,7 +279,7 @@ namespace
ScValidityRefChildWin::ScValidityRefChildWin( vcl::Window* pParentP,
sal_uInt16 nId,
SfxBindings* p,
- SfxChildWinInfo* /*pInfo*/ )
+ SAL_UNUSED_PARAMETER SfxChildWinInfo* /*pInfo*/ )
: SfxChildWindow(pParentP, nId),
m_bVisibleLock( false ),
m_bFreeWindowLock( false ),
diff --git a/sc/source/ui/view/spelldialog.cxx b/sc/source/ui/view/spelldialog.cxx
index 8f493fde86db..8bb710834795 100644
--- a/sc/source/ui/view/spelldialog.cxx
+++ b/sc/source/ui/view/spelldialog.cxx
@@ -40,7 +40,7 @@
SFX_IMPL_CHILDWINDOW_WITHID( ScSpellDialogChildWindow, SID_SPELL_DIALOG )
ScSpellDialogChildWindow::ScSpellDialogChildWindow( vcl::Window* pParentP, sal_uInt16 nId,
- SfxBindings* pBindings, SfxChildWinInfo* /*pInfo*/ ) :
+ SfxBindings* pBindings, SAL_UNUSED_PARAMETER SfxChildWinInfo* /*pInfo*/ ) :
svx::SpellDialogChildWindow( pParentP, nId, pBindings ),
mpViewShell( nullptr ),
mpViewData( nullptr ),
diff --git a/sc/source/ui/view/tabcont.cxx b/sc/source/ui/view/tabcont.cxx
index 88143e9ac594..c015c2bc12eb 100644
--- a/sc/source/ui/view/tabcont.cxx
+++ b/sc/source/ui/view/tabcont.cxx
@@ -464,11 +464,11 @@ void ScTabControl::StartDrag( sal_Int8 /* nAction */, const Point& rPosPixel )
vcl::Region aRegion( tools::Rectangle(0,0,0,0) );
CommandEvent aCEvt( rPosPixel, CommandEventId::StartDrag, true ); // needed for StartDrag
if (TabBar::StartDrag( aCEvt, aRegion ))
- DoDrag( aRegion );
+ DoDrag();
}
}
-void ScTabControl::DoDrag( const vcl::Region& /* rRegion */ )
+void ScTabControl::DoDrag()
{
ScDocShell* pDocSh = pViewData->GetDocShell();
ScDocument& rDoc = pDocSh->GetDocument();
diff --git a/sc/source/ui/view/tabvwshf.cxx b/sc/source/ui/view/tabvwshf.cxx
index 64638a63e048..d2980486bb4e 100644
--- a/sc/source/ui/view/tabvwshf.cxx
+++ b/sc/source/ui/view/tabvwshf.cxx
@@ -694,12 +694,12 @@ void ScTabViewShell::ExecuteTable( SfxRequest& rReq )
ScMarkData::const_iterator itr = rMark.begin(), itrEnd = rMark.end();
for (; itr != itrEnd; ++itr)
- rFunc.SetLayoutRTL( *itr, bSet, false );
+ rFunc.SetLayoutRTL( *itr, bSet );
pUndoManager->LeaveListAction();
}
else
- rFunc.SetLayoutRTL( nCurrentTab, bSet, false );
+ rFunc.SetLayoutRTL( nCurrentTab, bSet );
}
break;
diff --git a/sc/source/ui/view/viewfun2.cxx b/sc/source/ui/view/viewfun2.cxx
index dbc801c119e8..b0f5e24e1e19 100644
--- a/sc/source/ui/view/viewfun2.cxx
+++ b/sc/source/ui/view/viewfun2.cxx
@@ -834,7 +834,7 @@ void ScViewFunc::InsertPageBreak( bool bColumn, bool bRecord, const ScAddress* p
aCursor = ScAddress( GetViewData().GetCurX(), GetViewData().GetCurY(), nTab );
bool bSuccess = GetViewData().GetDocShell()->GetDocFunc().
- InsertPageBreak( bColumn, aCursor, bRecord, bSetModified, false );
+ InsertPageBreak( bColumn, aCursor, bRecord, bSetModified );
if ( bSuccess && bSetModified )
UpdatePageBreakData( true ); // for PageBreak-Mode
@@ -851,7 +851,7 @@ void ScViewFunc::DeletePageBreak( bool bColumn, bool bRecord, const ScAddress* p
aCursor = ScAddress( GetViewData().GetCurX(), GetViewData().GetCurY(), nTab );
bool bSuccess = GetViewData().GetDocShell()->GetDocFunc().
- RemovePageBreak( bColumn, aCursor, bRecord, bSetModified, false );
+ RemovePageBreak( bColumn, aCursor, bRecord, bSetModified );
if ( bSuccess && bSetModified )
UpdatePageBreakData( true ); // for PageBreak-Mode
@@ -2196,7 +2196,7 @@ void ScViewFunc::DeleteTable( SCTAB nTab, bool bRecord )
ScDocShell* pDocSh = GetViewData().GetDocShell();
ScDocument& rDoc = pDocSh->GetDocument();
- bool bSuccess = pDocSh->GetDocFunc().DeleteTable( nTab, bRecord, false );
+ bool bSuccess = pDocSh->GetDocFunc().DeleteTable( nTab, bRecord );
if (bSuccess)
{
SCTAB nNewTab = nTab;
diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx
index 39c0df61a5c2..f6a3c1084ffb 100644
--- a/sc/source/ui/view/viewfunc.cxx
+++ b/sc/source/ui/view/viewfunc.cxx
@@ -2363,7 +2363,7 @@ void ScViewFunc::Protect( SCTAB nTab, const OUString& rPassword )
bool bUndo(rDoc.IsUndoEnabled());
if ( nTab == TABLEID_DOC || rMark.GetSelectCount() <= 1 )
- rFunc.Protect( nTab, rPassword, false );
+ rFunc.Protect( nTab, rPassword );
else
{
// modifying several tabs is handled here
@@ -2376,7 +2376,7 @@ void ScViewFunc::Protect( SCTAB nTab, const OUString& rPassword )
ScMarkData::iterator itr = rMark.begin(), itrEnd = rMark.end();
for (; itr != itrEnd; ++itr)
- rFunc.Protect( *itr, rPassword, false );
+ rFunc.Protect( *itr, rPassword );
if (bUndo)
pDocSh->GetUndoManager()->LeaveListAction();
More information about the Libreoffice-commits
mailing list