[Libreoffice-commits] core.git: basctl/source include/vcl vcl/source

Julien Nabet serval2412 at yahoo.fr
Tue May 16 19:05:50 UTC 2017


 basctl/source/basicide/baside2.cxx  |    2 --
 basctl/source/basicide/baside2b.cxx |    1 -
 include/vcl/textview.hxx            |    2 --
 vcl/source/edit/textview.cxx        |   10 ----------
 4 files changed, 15 deletions(-)

New commits:
commit 7865aa4c9e08e5dccf3627a68daf439a26e1bd4d
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Tue May 16 18:43:19 2017 +0200

    Remove unused mpVirtDev (vcl/textview)
    
    Unused since commit 72edb6967f245f0c99c6a61e0ce8d0a245600cba
    "loplugin:unusedmethods in vcl"
    
    + remove useless EraseVirtualDevice
    
    Change-Id: I1b932bb49e9f84e3ddb5c3ab69b3d1b3131233e2
    Reviewed-on: https://gerrit.libreoffice.org/37685
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx
index 7a03c14aa61a..d24597ed819a 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -1195,8 +1195,6 @@ void ModulWindow::Activating ()
 void ModulWindow::Deactivating()
 {
     Hide();
-    if ( GetEditView() )
-        GetEditView()->EraseVirtualDevice();
 }
 
 sal_uInt16 ModulWindow::StartSearchAndReplace( const SvxSearchItem& rSearchItem, bool bFromStart )
diff --git a/basctl/source/basicide/baside2b.cxx b/basctl/source/basicide/baside2b.cxx
index afc85ea00b70..8b9137db9262 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -1004,7 +1004,6 @@ void EditorWindow::CreateEditEngine()
 
     pProgress.reset();
 
-    pEditView->EraseVirtualDevice();
     pEditEngine->SetModified( false );
     pEditEngine->EnableUndo( true );
 
diff --git a/include/vcl/textview.hxx b/include/vcl/textview.hxx
index b46bc5f3891c..ba96f89dba56 100644
--- a/include/vcl/textview.hxx
+++ b/include/vcl/textview.hxx
@@ -169,8 +169,6 @@ public:
 
     void                SetPaintSelection( bool bPaint);
 
-    void                EraseVirtualDevice();
-
     // aus dem protected Teil hierher verschoben
     // For 'SvtXECTextCursor' (TL). Must ggf nochmal anders gel?st werden.
     TextPaM             PageUp( const TextPaM& rPaM );
diff --git a/vcl/source/edit/textview.cxx b/vcl/source/edit/textview.cxx
index 083f3a984df9..c6cb9618e4cf 100644
--- a/vcl/source/edit/textview.cxx
+++ b/vcl/source/edit/textview.cxx
@@ -157,8 +157,6 @@ struct ImpTextView
 
     std::unique_ptr<TextDDInfo> mpDDInfo;
 
-    VclPtr<VirtualDevice>  mpVirtDev;
-
     std::unique_ptr<SelectionEngine> mpSelEngine;
     std::unique_ptr<TextSelFunctionSet> mpSelFuncSet;
 
@@ -185,7 +183,6 @@ TextView::TextView( ExtTextEngine* pEng, vcl::Window* pWindow ) :
 
     mpImpl->mpWindow = pWindow;
     mpImpl->mpTextEngine = pEng;
-    mpImpl->mpVirtDev = nullptr;
 
     mpImpl->mbPaintSelection = true;
     mpImpl->mbAutoScroll = true;
@@ -235,8 +232,6 @@ TextView::~TextView()
     mpImpl->mpSelEngine.reset();
     mpImpl->mpSelFuncSet.reset();
 
-    mpImpl->mpVirtDev.disposeAndClear();
-
     if ( mpImpl->mpWindow->GetCursor() == mpImpl->mpCursor.get() )
         mpImpl->mpWindow->SetCursor( nullptr );
 
@@ -476,11 +471,6 @@ void TextView::ImpShowHideSelection(const TextSelection* pRange)
     }
 }
 
-void TextView::EraseVirtualDevice()
-{
-    mpImpl->mpVirtDev.disposeAndClear();
-}
-
 bool TextView::KeyInput( const KeyEvent& rKeyEvent )
 {
     bool bDone      = true;


More information about the Libreoffice-commits mailing list