[Libreoffice-commits] core.git: solenv/bin

Yeliz Taneroğlu yeliztaneroglu at gmail.com
Sat May 20 09:31:32 UTC 2017


 solenv/bin/create-ids |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 027d661ef7e2490f1182d3e5003ae4da4135e0ca
Author: Yeliz Taneroğlu <yeliztaneroglu at gmail.com>
Date:   Fri May 19 18:03:04 2017 +0300

    tdf#105204 fix shellcheck warnings in solenv/bin/create-ids
    
    Change-Id: Iab3855cdd8fb1ae3719dd7267b1592eea0ef1e22
    SC2006: Use $(..) instead of legacy `..`.
    SC2035: Use ./*/* so names with dashes won't become options.
    SC2086: Double quote to prevent globbing and word splitting.
    SC2046: Quote this to prevent word splitting.
    Reviewed-on: https://gerrit.libreoffice.org/37832
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Chris Sherlock <chris.sherlock79 at gmail.com>

diff --git a/solenv/bin/create-ids b/solenv/bin/create-ids
index 0722091b2386..59c532719e38 100755
--- a/solenv/bin/create-ids
+++ b/solenv/bin/create-ids
@@ -11,8 +11,8 @@
 
 # TODO: should this include workdir headers?
 if [ "$1" = "--with-outpath" ]; then
-    dirs="`ls -d */* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\(clone\|workdir\|instdir\)\//d'`"
+    dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\(clone\|workdir\|instdir\)\//d')"
 else
-    dirs="`ls -d */* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\(clone\|workdir\|instdir\)\//d'`"
+    dirs="$(ls -d ./*/* | sed -e '/\(\/\(cscope\.\|tags\|ID\)\)\|^\(clone\|workdir\|instdir\)\//d')"
 fi
-mkid --lang-map=`dirname $0`/id-lang.map --include='C C++ asm perl java make' --statistics $dirs
+mkid --lang-map="$(dirname "$0")"/id-lang.map --include='C C++ asm perl java make' --statistics "$dirs"


More information about the Libreoffice-commits mailing list