[Libreoffice-commits] core.git: setup_native/scripts

Yeliz Taneroğlu yeliztaneroglu at gmail.com
Sat May 20 09:42:16 UTC 2017


 setup_native/scripts/unpack_update.sh |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 46a30d5eb89a7198f30a895ac92ab5d70d111511
Author: Yeliz Taneroğlu <yeliztaneroglu at gmail.com>
Date:   Tue May 16 15:11:06 2017 +0300

    tdf#105204 fix shellcheck warning in setup_native/scripts/unpack_update.sh
    
    Change-Id: Ic2a3b58dac3bc148cf9a2bd8237574d4851aabe6
    SC2006: Use $(STATEMENT) instead of legacy `STATEMENT`
    SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.
    Reviewed-on: https://gerrit.libreoffice.org/37681
    Reviewed-by: Chris Sherlock <chris.sherlock79 at gmail.com>
    Tested-by: Chris Sherlock <chris.sherlock79 at gmail.com>

diff --git a/setup_native/scripts/unpack_update.sh b/setup_native/scripts/unpack_update.sh
index 1b7b53430503..1af4865cd308 100644
--- a/setup_native/scripts/unpack_update.sh
+++ b/setup_native/scripts/unpack_update.sh
@@ -27,7 +27,7 @@ NUM=1
 DESTPATH="$BASEDIR/$FOLDER"
 
 while [ -d "$DESTPATH" ]; do
-  NUM=`expr $NUM + 1`
+  NUM=$(expr $NUM + 1)
   DESTPATH="$BASEDIR/$FOLDER-$NUM"
 done
 
@@ -47,4 +47,4 @@ else
   exit 2
 fi
 
-UPDATE=`eval ls */update` && SUBFOLDER=`dirname $UPDATE` && mv $SUBFOLDER/* . && rmdir $SUBFOLDER && echo "$DESTPATH/update"
+UPDATE=$(eval ls ./*/update) && SUBFOLDER=$(dirname $UPDATE) && mv $SUBFOLDER/* . && rmdir $SUBFOLDER && echo "$DESTPATH/update"


More information about the Libreoffice-commits mailing list