[Libreoffice-commits] core.git: sw/source

Justin Luth justin_luth at sil.org
Mon May 22 13:42:08 UTC 2017


 sw/source/filter/ww8/ww8atr.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f928ed66267330a8872a97767f11b97c219e0899
Author: Justin Luth <justin_luth at sil.org>
Date:   Fri May 19 09:11:40 2017 +0300

    ww8export: match kern=2 with docxexport
    
    MSO uses half-pt values in this field as the
    minimum font pt size to start kerning at.
    
    Although kern=1 enables pair kerning in MSO, it seems to be an
    invalid number, and so is interpretted to enable kerning at
    the default value of pt 11. So kern=1 is the same as kern=22.
    Setting kern=2 seems to be the minimun allowed value,
    enabling kerning for fonts size 1 and above.
    
    Likely, kerning small fonts doesn't look good, so the current value
    of 1 enables it for the default font size.  However, if someone
    intentionally wants to kern a smaller font, then we will be
    incompatible, and also any documents with smaller fonts authored in LO
    will not be identical. As always, when the two applications have a design
    incompatibility, a decision will need to be made one way over another.
    
    Switching to enabling kerning at ALL font sizes, thus matching native LO
    handling, and so that any documents that are edited in LO look the same
    in MSO.
    
    This change will ONLY affect MSO's rendering of documents
    round-tripped by LO. It will not be noticed in LibreOffice itself.
    
    Change-Id: I73c46f3f120221b7b194480145b9150929d3d9a3
    Reviewed-on: https://gerrit.libreoffice.org/37800
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Justin Luth <justin_luth at sil.org>
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 5047e4f0d0bd..9b5f5f7c5b2b 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -1114,7 +1114,7 @@ void WW8AttributeOutput::CharAutoKern( const SvxAutoKernItem& rAutoKern )
 {
     m_rWW8Export.InsUInt16( NS_sprm::sprmCHpsKern );
 
-    m_rWW8Export.InsUInt16( rAutoKern.GetValue() ? 1 : 0 );
+    m_rWW8Export.InsUInt16( rAutoKern.GetValue() ? 2 : 0 );
 }
 
 void WW8AttributeOutput::CharAnimatedText( const SvxBlinkItem& rBlink )


More information about the Libreoffice-commits mailing list