[Libreoffice-commits] core.git: helpcompiler/source

Gabor Kelemen kelemeng at ubuntu.com
Fri May 26 08:09:24 UTC 2017


 helpcompiler/source/HelpCompiler.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 59793d67d4c0324730e30d71d94ba5173643d79c
Author: Gabor Kelemen <kelemeng at ubuntu.com>
Date:   Thu May 25 23:33:03 2017 +0200

    Make helpcompiler more verbose on dot ahelps
    
    Currently we get a warning if the ahelp is one dot
    and there was no previous bookmark tag.
    
    This warning contains only the text with the problemmatic ahelp.
    
    It would make it easier to hunt down such problems if we would
    know the file names.
    
    This patch does that, and now I see 334 problems in 137 files.
    
    Change-Id: I364368f7affb85d5c5d526dd4674757c51956aea
    Reviewed-on: https://gerrit.libreoffice.org/38044
    Reviewed-by: Andras Timar <andras.timar at collabora.com>
    Tested-by: Andras Timar <andras.timar at collabora.com>

diff --git a/helpcompiler/source/HelpCompiler.cxx b/helpcompiler/source/HelpCompiler.cxx
index 8f0301ca2fe0..eb1c54830ffe 100644
--- a/helpcompiler/source/HelpCompiler.cxx
+++ b/helpcompiler/source/HelpCompiler.cxx
@@ -417,7 +417,7 @@ void myparser::traverse( xmlNodePtr parentNode )
             {
                 //TODO: make these asserts and flush out all our broken help ids
                 SAL_WARN_IF(hidstr.empty(), "helpcompiler", "hid='' for text:" << text);
-                SAL_WARN_IF(!hidstr.empty() && extendedHelpText.empty(), "helpcompiler", "hid='.' with no hid bookmark branches for text:" << text);
+                SAL_WARN_IF(!hidstr.empty() && extendedHelpText.empty(), "helpcompiler", "hid='.' with no hid bookmark branches in file: " << fileName + " for text: " << text);
                 HashSet::const_iterator aEnd = extendedHelpText.end();
                 for (HashSet::const_iterator iter = extendedHelpText.begin(); iter != aEnd; ++iter)
                 {


More information about the Libreoffice-commits mailing list