[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - vcl/source

Caolán McNamara caolanm at redhat.com
Fri May 26 11:44:26 UTC 2017


 vcl/source/opengl/OpenGLContext.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 3e368230eb28cd88a9491f6ca7a16a65e2774263
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 26 12:41:10 2017 +0100

    Resolves: tdf##108069 2nd OpenGLContext::init should dispose earlier results
    
    Change-Id: If6bb9517a4081576347d71ddf26d020119d34247
    (cherry picked from commit 0b9b36cafe29916a9fdeac420a49c174adb10c59)
    Reviewed-on: https://gerrit.libreoffice.org/38064
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx
index 72e7f3cbc32d..541491100bf5 100644
--- a/vcl/source/opengl/OpenGLContext.cxx
+++ b/vcl/source/opengl/OpenGLContext.cxx
@@ -234,7 +234,8 @@ bool OpenGLContext::init( vcl::Window* pParent )
     mpWindow = pParent ? pParent : m_xWindow.get();
     if(m_xWindow)
         m_xWindow->setPosSizePixel(0,0,0,0);
-    m_pChildWindow = nullptr;
+    //tdf#108069 we may be initted twice, so dispose earlier effort
+    m_pChildWindow.disposeAndClear();
     initWindow();
     return ImplInit();
 }


More information about the Libreoffice-commits mailing list