[Libreoffice-commits] core.git: vcl/win

[Mike Kaganski]

 vcl/win/gdi/DWriteTextRenderer.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 11459949e920fab6074bab85e3e1a748e9aee1ee
Author: Mike Kaganski <mike.kaganski at collabora.com>
Date:   Wed Nov 1 22:11:01 2017 +0200

    Related: tdf#113347: properly check HRESULT value
    
    HRESULT's "success" value S_OK is 0; they are failed when their values are
    negative. So, the incorrect check resulted in false failures.
    
    Change-Id: I56560ced73e335af49c66d58201d5455e555e431
    Reviewed-on: https://gerrit.libreoffice.org/44180
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/vcl/win/gdi/DWriteTextRenderer.cxx b/vcl/win/gdi/DWriteTextRenderer.cxx
index 95dd9e9d9b97..9819ef205aa1 100644
--- a/vcl/win/gdi/DWriteTextRenderer.cxx
+++ b/vcl/win/gdi/DWriteTextRenderer.cxx
@@ -341,7 +341,7 @@ bool D2DWriteTextOutRenderer::BindFont(HDC hDC)
 
     // Initially bind to an empty rectangle to get access to the font face,
     //  we'll update it once we've calculated a bounding rect in DrawGlyphs
-    if (!BindDC(mhDC = hDC))
+    if (FAILED(BindDC(mhDC = hDC)))
         return false;
 
     mlfEmHeight = 0;