[Libreoffice-commits] core.git: Branch 'libreoffice-5-4-3' - sc/source

[Eike Rathke]

 sc/source/core/data/column.cxx |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit f80ec94e75a9257504135bc32793c5eb37914bbe
Author: Eike Rathke <erack at redhat.com>
Date:   Thu Nov 2 12:53:14 2017 +0100

    Resolves: tdf#111428 swap ScColumn::mnBlkCountFormula
    
     This is a combination of 2 commits.
    
    (cherry picked from commit 423df1fa929784c14e3a133c06468589fe9269cd)
    (cherry picked from commit 911e2aff3cc37cb7410292728ffea05fffbfb0b3)
    
    CellStoreEvent remembered the original ScColumn::mnBlkCountFormula,
    hence after inserting a column to the left the quick check of
    ScColumn::HasFormulaCell() whether there are any formula cells worked on
    the swapped in count (originally the one to the right) that happens to
    be empty in the scenario. Things worked correctly by accident if the
    next column to the right already contained a formula cell.
    
    c44fed96c49bea7365bf1200e06788860966795c
    
    Change-Id: If993856ceee657736f516a81c293506041a6b7eb
    Reviewed-on: https://gerrit.libreoffice.org/44211
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice at googlemail.com>
    Tested-by: Christian Lohmaier <lohmaier+LibreOffice at googlemail.com>

diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 45f211cbedd1..5a817c2f747e 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -1899,6 +1899,9 @@ void ScColumn::SwapCol(ScColumn& rCol)
     maCellTextAttrs.swap(rCol.maCellTextAttrs);
     maCellNotes.swap(rCol.maCellNotes);
 
+    // Swap all CellStoreEvent mdds event_func related.
+    std::swap( mnBlkCountFormula, rCol.mnBlkCountFormula);
+
     // notes update caption
     UpdateNoteCaptions(0, MAXROW);
     rCol.UpdateNoteCaptions(0, MAXROW);