[Libreoffice-commits] core.git: sc/source

Caolán McNamara caolanm at redhat.com
Fri Nov 3 19:45:46 UTC 2017


 sc/source/filter/excel/xichart.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit bd74993aef9b30ca42810543d8b8bf13490ee9ce
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Nov 3 14:11:46 2017 +0000

    ofz#4043 Null-deference READ
    
    Change-Id: I2af7adc55c5b219086aad3157ccac1ce88a8ba97
    Reviewed-on: https://gerrit.libreoffice.org/44266
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/filter/excel/xichart.cxx b/sc/source/filter/excel/xichart.cxx
index 49aa0c9ac3c9..627c8f998521 100644
--- a/sc/source/filter/excel/xichart.cxx
+++ b/sc/source/filter/excel/xichart.cxx
@@ -1233,9 +1233,9 @@ namespace {
 
 void lclUpdateText( XclImpChTextRef& rxText, const XclImpChText* xDefText )
 {
-    if( rxText )
+    if (rxText)
         rxText->UpdateText( xDefText );
-    else
+    else if (xDefText)
     {
         XclImpChTextRef xNew(new XclImpChText(*xDefText));
         rxText = xNew;


More information about the Libreoffice-commits mailing list