[Libreoffice-commits] core.git: basctl/source basic/source chart2/source drawinglayer/source editeng/source extensions/source include/drawinglayer include/editeng linguistic/source oox/source package/inc package/source xmloff/source
Noel Grandin
noel.grandin at collabora.co.uk
Sat Nov 4 06:50:32 UTC 2017
basctl/source/basicide/brkdlg.cxx | 4 ++--
basctl/source/basicide/brkdlg.hxx | 4 ++--
basic/source/classes/sbunoobj.cxx | 4 ++--
basic/source/inc/namecont.hxx | 2 +-
basic/source/inc/runtime.hxx | 2 +-
basic/source/runtime/runtime.cxx | 2 +-
basic/source/uno/namecont.cxx | 2 +-
chart2/source/view/axes/VPolarAngleAxis.cxx | 2 +-
chart2/source/view/axes/VPolarAngleAxis.hxx | 2 +-
chart2/source/view/inc/GL3DRenderer.hxx | 2 +-
chart2/source/view/main/GL3DRenderer.cxx | 2 +-
drawinglayer/source/texture/texture3d.cxx | 2 +-
editeng/source/uno/unoedhlp.cxx | 2 +-
editeng/source/uno/unofield.cxx | 2 +-
extensions/source/scanner/sane.cxx | 2 +-
extensions/source/scanner/sane.hxx | 2 +-
include/drawinglayer/texture/texture3d.hxx | 2 +-
include/editeng/unoedhlp.hxx | 2 +-
linguistic/source/lngsvcmgr.cxx | 2 +-
oox/source/helper/propertymap.cxx | 2 +-
oox/source/ole/vbaexport.cxx | 2 +-
package/inc/ZipFile.hxx | 4 ++--
package/source/zipapi/XUnbufferedStream.cxx | 2 +-
package/source/zipapi/XUnbufferedStream.hxx | 2 +-
package/source/zipapi/ZipFile.cxx | 4 ++--
xmloff/source/text/txtimppr.cxx | 4 ++--
26 files changed, 32 insertions(+), 32 deletions(-)
New commits:
commit 3dde9d988f0c9a432429389359c3531f10a4ff10
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Thu Nov 2 12:09:52 2017 +0200
loplugin:constparams in various(1)
Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b
Reviewed-on: https://gerrit.libreoffice.org/44261
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/basctl/source/basicide/brkdlg.cxx b/basctl/source/basicide/brkdlg.cxx
index 6bcb23d5eb37..27fc322e5805 100644
--- a/basctl/source/basicide/brkdlg.cxx
+++ b/basctl/source/basicide/brkdlg.cxx
@@ -121,7 +121,7 @@ void BreakPointDialog::dispose()
ModalDialog::dispose();
}
-void BreakPointDialog::SetCurrentBreakPoint( BreakPoint* pBrk )
+void BreakPointDialog::SetCurrentBreakPoint( BreakPoint const * pBrk )
{
OUString aStr( "# " + OUString::number(pBrk->nLine) );
m_pComboBox->SetText( aStr );
@@ -233,7 +233,7 @@ IMPL_LINK( BreakPointDialog, ButtonHdl, Button *, pButton, void )
}
-void BreakPointDialog::UpdateFields( BreakPoint* pBrk )
+void BreakPointDialog::UpdateFields( BreakPoint const * pBrk )
{
if ( pBrk )
{
diff --git a/basctl/source/basicide/brkdlg.hxx b/basctl/source/basicide/brkdlg.hxx
index 2a93ef2131e7..1a2ea84e01bd 100644
--- a/basctl/source/basicide/brkdlg.hxx
+++ b/basctl/source/basicide/brkdlg.hxx
@@ -47,7 +47,7 @@ protected:
DECL_LINK( ComboBoxHighlightHdl, ComboBox&, void );
DECL_LINK( EditModifyHdl, Edit&, void );
DECL_LINK( ButtonHdl, Button*, void );
- void UpdateFields( BreakPoint* pBrk );
+ void UpdateFields( BreakPoint const * pBrk );
BreakPoint* GetSelectedBreakPoint();
@@ -56,7 +56,7 @@ public:
virtual ~BreakPointDialog() override;
virtual void dispose() override;
- void SetCurrentBreakPoint( BreakPoint* pBrk );
+ void SetCurrentBreakPoint( BreakPoint const * pBrk );
};
} // namespace basctl
diff --git a/basic/source/classes/sbunoobj.cxx b/basic/source/classes/sbunoobj.cxx
index d6e8210340a1..3c223f3010e7 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -362,7 +362,7 @@ OUString implGetExceptionMsg( const EXCEPTION& e )
return implGetExceptionMsg( e, cppu::UnoType<decltype(e)>::get().getTypeName() );
}
-void implHandleBasicErrorException( BasicErrorException& e )
+void implHandleBasicErrorException( BasicErrorException const & e )
{
ErrCode nError = StarBASIC::GetSfxFromVBError( (sal_uInt16)e.ErrorCode );
StarBASIC::Error( nError, e.ErrorMessageArgument );
@@ -521,7 +521,7 @@ SbxDataType unoToSbxType( const Reference< XIdlClass >& xIdlClass )
return eRetType;
}
-static void implSequenceToMultiDimArray( SbxDimArray*& pArray, Sequence< sal_Int32 >& indices, Sequence< sal_Int32 >& sizes, const Any& aValue, sal_Int32& dimension, bool bIsZeroIndex, Type const * pType )
+static void implSequenceToMultiDimArray( SbxDimArray*& pArray, Sequence< sal_Int32 >& indices, Sequence< sal_Int32 >& sizes, const Any& aValue, sal_Int32 dimension, bool bIsZeroIndex, Type const * pType )
{
const Type& aType = aValue.getValueType();
TypeClass eTypeClass = aType.getTypeClass();
diff --git a/basic/source/inc/namecont.hxx b/basic/source/inc/namecont.hxx
index 875e15a60897..72016292713f 100644
--- a/basic/source/inc/namecont.hxx
+++ b/basic/source/inc/namecont.hxx
@@ -255,7 +255,7 @@ protected:
const css::uno::Reference< css::embed::XStorage >& xStorage,
const OUString& aIndexFileName );
- void implImportLibDescriptor( SfxLibrary* pLib, ::xmlscript::LibDescriptor& rLib );
+ void implImportLibDescriptor( SfxLibrary* pLib, ::xmlscript::LibDescriptor const & rLib );
// Methods to distinguish between different library types
virtual SfxLibrary* SAL_CALL implCreateLibrary( const OUString& aName ) = 0;
diff --git a/basic/source/inc/runtime.hxx b/basic/source/inc/runtime.hxx
index 64320ce6cee7..647fe364274e 100644
--- a/basic/source/inc/runtime.hxx
+++ b/basic/source/inc/runtime.hxx
@@ -193,7 +193,7 @@ public:
// offer NumberFormatter also static
static SvNumberFormatter* PrepareNumberFormatter( sal_uInt32 &rnStdDateIdx,
sal_uInt32 &rnStdTimeIdx, sal_uInt32 &rnStdDateTimeIdx,
- LanguageType const * peFormatterLangType=nullptr, DateOrder* peFormatterDateOrder=nullptr );
+ LanguageType const * peFormatterLangType=nullptr, DateOrder const * peFormatterDateOrder=nullptr );
};
// There's one instance of this class for every executed sub-program.
diff --git a/basic/source/runtime/runtime.cxx b/basic/source/runtime/runtime.cxx
index e9a0215b0442..0c4af5336882 100644
--- a/basic/source/runtime/runtime.cxx
+++ b/basic/source/runtime/runtime.cxx
@@ -383,7 +383,7 @@ SvNumberFormatter* SbiInstance::GetNumberFormatter()
// #39629 offer NumberFormatter static too
SvNumberFormatter* SbiInstance::PrepareNumberFormatter( sal_uInt32 &rnStdDateIdx,
sal_uInt32 &rnStdTimeIdx, sal_uInt32 &rnStdDateTimeIdx,
- LanguageType const * peFormatterLangType, DateOrder* peFormatterDateOrder )
+ LanguageType const * peFormatterLangType, DateOrder const * peFormatterDateOrder )
{
SvNumberFormatter* pNumberFormater = nullptr;
LanguageType eLangType;
diff --git a/basic/source/uno/namecont.cxx b/basic/source/uno/namecont.cxx
index 4ac32587ec97..4010259771c4 100644
--- a/basic/source/uno/namecont.cxx
+++ b/basic/source/uno/namecont.cxx
@@ -1718,7 +1718,7 @@ bool SfxLibraryContainer::implLoadLibraryIndexFile( SfxLibrary* pLib,
}
void SfxLibraryContainer::implImportLibDescriptor( SfxLibrary* pLib,
- ::xmlscript::LibDescriptor& rLib )
+ ::xmlscript::LibDescriptor const & rLib )
{
if( !pLib->mbInitialised )
{
diff --git a/chart2/source/view/axes/VPolarAngleAxis.cxx b/chart2/source/view/axes/VPolarAngleAxis.cxx
index da7eeb3733c7..7e4132f84321 100644
--- a/chart2/source/view/axes/VPolarAngleAxis.cxx
+++ b/chart2/source/view/axes/VPolarAngleAxis.cxx
@@ -48,7 +48,7 @@ VPolarAngleAxis::~VPolarAngleAxis()
bool VPolarAngleAxis::createTextShapes_ForAngleAxis(
const uno::Reference< drawing::XShapes >& xTarget
, EquidistantTickIter& rTickIter
- , AxisLabelProperties& rAxisLabelProperties
+ , AxisLabelProperties const & rAxisLabelProperties
, double fLogicRadius
, double fLogicZ )
{
diff --git a/chart2/source/view/axes/VPolarAngleAxis.hxx b/chart2/source/view/axes/VPolarAngleAxis.hxx
index f9899f5da674..993a5ce5fef6 100644
--- a/chart2/source/view/axes/VPolarAngleAxis.hxx
+++ b/chart2/source/view/axes/VPolarAngleAxis.hxx
@@ -43,7 +43,7 @@ private: //methods
bool createTextShapes_ForAngleAxis(
const css::uno::Reference< css::drawing::XShapes >& xTarget
, EquidistantTickIter& rTickIter
- , AxisLabelProperties& rAxisLabelProperties
+ , AxisLabelProperties const & rAxisLabelProperties
, double fLogicRadius, double fLogicZ );
};
diff --git a/chart2/source/view/inc/GL3DRenderer.hxx b/chart2/source/view/inc/GL3DRenderer.hxx
index 9443ca23f982..19b6996b5d8f 100644
--- a/chart2/source/view/inc/GL3DRenderer.hxx
+++ b/chart2/source/view/inc/GL3DRenderer.hxx
@@ -213,7 +213,7 @@ public:
void ReleaseScreenTextShapes();
void ReleaseTextTexture();
void ReleaseScreenTextTexture();
- void StartClick(sal_uInt32 &selectID);
+ void StartClick(sal_uInt32 selectID);
void EndClick();
void SetScroll();
void SetScrollSpeed(float scrollSpeed);
diff --git a/chart2/source/view/main/GL3DRenderer.cxx b/chart2/source/view/main/GL3DRenderer.cxx
index 0bca5ba3a70b..a6947e82277d 100644
--- a/chart2/source/view/main/GL3DRenderer.cxx
+++ b/chart2/source/view/main/GL3DRenderer.cxx
@@ -2388,7 +2388,7 @@ void OpenGL3DRenderer::DisableHighLightBar(BatchBarInfo &barInfo)
}
}
-void OpenGL3DRenderer::StartClick(sal_uInt32 &selectID)
+void OpenGL3DRenderer::StartClick(sal_uInt32 selectID)
{
m_bHighLighting = true;
m_uiSelectID = selectID;
diff --git a/drawinglayer/source/texture/texture3d.cxx b/drawinglayer/source/texture/texture3d.cxx
index dda8e6b73d87..2120b8f04280 100644
--- a/drawinglayer/source/texture/texture3d.cxx
+++ b/drawinglayer/source/texture/texture3d.cxx
@@ -110,7 +110,7 @@ namespace drawinglayer
{
}
- sal_uInt8 GeoTexSvxBitmapEx::impGetTransparence(sal_Int32& rX, sal_Int32& rY) const
+ sal_uInt8 GeoTexSvxBitmapEx::impGetTransparence(sal_Int32 rX, sal_Int32 rY) const
{
switch(maBitmapEx.GetTransparentType())
{
diff --git a/editeng/source/uno/unoedhlp.cxx b/editeng/source/uno/unoedhlp.cxx
index 37205eef052f..767a7c14b41f 100644
--- a/editeng/source/uno/unoedhlp.cxx
+++ b/editeng/source/uno/unoedhlp.cxx
@@ -42,7 +42,7 @@ SvxEditSourceHint::SvxEditSourceHint( SfxHintId _nId, sal_uLong nValue, sal_Int3
}
-std::unique_ptr<SfxHint> SvxEditSourceHelper::EENotification2Hint( EENotify* aNotify )
+std::unique_ptr<SfxHint> SvxEditSourceHelper::EENotification2Hint( EENotify const * aNotify )
{
if( aNotify )
{
diff --git a/editeng/source/uno/unofield.cxx b/editeng/source/uno/unofield.cxx
index b2f416c7c78e..0f439e9a4f9e 100644
--- a/editeng/source/uno/unofield.cxx
+++ b/editeng/source/uno/unofield.cxx
@@ -203,7 +203,7 @@ static util::DateTime getDate( sal_Int32 nDate )
return aDate;
}
-inline Date setDate( util::DateTime& rDate )
+inline Date setDate( util::DateTime const & rDate )
{
return Date( rDate.Day, rDate.Month, rDate.Year );
}
diff --git a/extensions/source/scanner/sane.cxx b/extensions/source/scanner/sane.cxx
index 330d3a79ef29..a22cda021bd4 100644
--- a/extensions/source/scanner/sane.cxx
+++ b/extensions/source/scanner/sane.cxx
@@ -454,7 +454,7 @@ void Sane::SetOptionValue( int n, double fSet, int nElement )
}
}
-void Sane::SetOptionValue( int n, double* pSet )
+void Sane::SetOptionValue( int n, double const * pSet )
{
if( ! maHandle || ( mppOptions[n]->type != SANE_TYPE_INT &&
mppOptions[n]->type != SANE_TYPE_FIXED ) )
diff --git a/extensions/source/scanner/sane.hxx b/extensions/source/scanner/sane.hxx
index e3694a3ff58a..c40ff1bb8c1b 100644
--- a/extensions/source/scanner/sane.hxx
+++ b/extensions/source/scanner/sane.hxx
@@ -141,7 +141,7 @@ public:
void SetOptionValue( int, bool );
void SetOptionValue( int, const OUString& );
void SetOptionValue( int, double, int nElement = 0 );
- void SetOptionValue( int, double* );
+ void SetOptionValue( int, double const * );
bool ActivateButtonOption( int );
diff --git a/include/drawinglayer/texture/texture3d.hxx b/include/drawinglayer/texture/texture3d.hxx
index 489c631b0b27..9d05122f373a 100644
--- a/include/drawinglayer/texture/texture3d.hxx
+++ b/include/drawinglayer/texture/texture3d.hxx
@@ -74,7 +74,7 @@ namespace drawinglayer
// helpers
bool impIsValid(const basegfx::B2DPoint& rUV, sal_Int32& rX, sal_Int32& rY) const;
- sal_uInt8 impGetTransparence(sal_Int32& rX, sal_Int32& rY) const;
+ sal_uInt8 impGetTransparence(sal_Int32 rX, sal_Int32 rY) const;
public:
GeoTexSvxBitmapEx(
diff --git a/include/editeng/unoedhlp.hxx b/include/editeng/unoedhlp.hxx
index 3d0a42cde3f7..3858a5ae717d 100644
--- a/include/editeng/unoedhlp.hxx
+++ b/include/editeng/unoedhlp.hxx
@@ -67,7 +67,7 @@ public:
@return the translated hint
*/
- static ::std::unique_ptr<SfxHint> EENotification2Hint( EENotify* aNotify );
+ static ::std::unique_ptr<SfxHint> EENotification2Hint( EENotify const * aNotify );
/** Calculate attribute run for EditEngines
diff --git a/linguistic/source/lngsvcmgr.cxx b/linguistic/source/lngsvcmgr.cxx
index 0ab0688379d6..b028a9f1cadf 100644
--- a/linguistic/source/lngsvcmgr.cxx
+++ b/linguistic/source/lngsvcmgr.cxx
@@ -565,7 +565,7 @@ namespace
}
Sequence< OUString > lcl_GetLastFoundSvcs(
- SvtLinguConfig &rCfg,
+ SvtLinguConfig const &rCfg,
const OUString &rLastFoundList ,
const OUString& rCfgLocaleStr )
{
diff --git a/oox/source/helper/propertymap.cxx b/oox/source/helper/propertymap.cxx
index 26928c2013b3..3b7e8e65a089 100644
--- a/oox/source/helper/propertymap.cxx
+++ b/oox/source/helper/propertymap.cxx
@@ -528,7 +528,7 @@ static const char *lclGetEnhancedParameterType( sal_uInt16 nType )
return type;
}
-static void printParameterPairData(int level, EnhancedCustomShapeParameterPair &pp)
+static void printParameterPairData(int level, EnhancedCustomShapeParameterPair const &pp)
{
// These are always sal_Int32s so lets depend on that for our packing ...
sal_Int32 nFirstValue, nSecondValue;
diff --git a/oox/source/ole/vbaexport.cxx b/oox/source/ole/vbaexport.cxx
index 0983a17809ac..cd26bf486615 100644
--- a/oox/source/ole/vbaexport.cxx
+++ b/oox/source/ole/vbaexport.cxx
@@ -88,7 +88,7 @@ OUString createHexStringFromDigit(sal_uInt8 nDigit)
return aString.toAsciiUpperCase();
}
-OUString createGuidStringFromInt(sal_uInt8 nGuid[16])
+OUString createGuidStringFromInt(sal_uInt8 const nGuid[16])
{
OUStringBuffer aBuffer;
aBuffer.append('{');
diff --git a/package/inc/ZipFile.hxx b/package/inc/ZipFile.hxx
index f57a0fb30015..c5353b6c17d2 100644
--- a/package/inc/ZipFile.hxx
+++ b/package/inc/ZipFile.hxx
@@ -67,14 +67,14 @@ class ZipFile
// aMediaType parameter is used only for raw stream header creation
css::uno::Reference < css::io::XInputStream > createStreamForZipEntry(
const rtl::Reference<comphelper::RefCountedMutex>& aMutexHolder,
- ZipEntry & rEntry,
+ ZipEntry const & rEntry,
const ::rtl::Reference < EncryptionData > &rData,
sal_Int8 nStreamMode,
bool bDecrypt,
const bool bUseBufferedStream = true,
const OUString& aMediaType = OUString() );
- bool hasValidPassword ( ZipEntry & rEntry, const rtl::Reference < EncryptionData > &rData );
+ bool hasValidPassword ( ZipEntry const & rEntry, const rtl::Reference < EncryptionData > &rData );
bool checkSizeAndCRC( const ZipEntry& aEntry );
diff --git a/package/source/zipapi/XUnbufferedStream.cxx b/package/source/zipapi/XUnbufferedStream.cxx
index b1e31f5ee2c9..1e219b698871 100644
--- a/package/source/zipapi/XUnbufferedStream.cxx
+++ b/package/source/zipapi/XUnbufferedStream.cxx
@@ -41,7 +41,7 @@ using com::sun::star::packages::zip::ZipIOException;
XUnbufferedStream::XUnbufferedStream(
const uno::Reference< uno::XComponentContext >& xContext,
const rtl::Reference< comphelper::RefCountedMutex >& aMutexHolder,
- ZipEntry & rEntry,
+ ZipEntry const & rEntry,
Reference < XInputStream > const & xNewZipStream,
const ::rtl::Reference< EncryptionData >& rData,
sal_Int8 nStreamMode,
diff --git a/package/source/zipapi/XUnbufferedStream.hxx b/package/source/zipapi/XUnbufferedStream.hxx
index 47bb3ce583be..db1b58dfe9a8 100644
--- a/package/source/zipapi/XUnbufferedStream.hxx
+++ b/package/source/zipapi/XUnbufferedStream.hxx
@@ -65,7 +65,7 @@ public:
XUnbufferedStream(
const css::uno::Reference< css::uno::XComponentContext >& xContext,
const rtl::Reference<comphelper::RefCountedMutex>& aMutexHolder,
- ZipEntry & rEntry,
+ ZipEntry const & rEntry,
css::uno::Reference < css::io::XInputStream > const & xNewZipStream,
const ::rtl::Reference< EncryptionData >& rData,
sal_Int8 nStreamMode,
diff --git a/package/source/zipapi/ZipFile.cxx b/package/source/zipapi/ZipFile.cxx
index 0b1fa46a3907..b7cdf7289d4c 100644
--- a/package/source/zipapi/ZipFile.cxx
+++ b/package/source/zipapi/ZipFile.cxx
@@ -491,7 +491,7 @@ bool ZipFile::StaticHasValidPassword( const uno::Reference< uno::XComponentConte
return bRet;
}
-bool ZipFile::hasValidPassword ( ZipEntry & rEntry, const ::rtl::Reference< EncryptionData >& rData )
+bool ZipFile::hasValidPassword ( ZipEntry const & rEntry, const ::rtl::Reference< EncryptionData >& rData )
{
::osl::MutexGuard aGuard( m_aMutexHolder->GetMutex() );
@@ -605,7 +605,7 @@ public:
uno::Reference< XInputStream > ZipFile::createStreamForZipEntry(
const rtl::Reference< comphelper::RefCountedMutex >& aMutexHolder,
- ZipEntry & rEntry,
+ ZipEntry const & rEntry,
const ::rtl::Reference< EncryptionData > &rData,
sal_Int8 nStreamMode,
bool bIsEncrypted,
diff --git a/xmloff/source/text/txtimppr.cxx b/xmloff/source/text/txtimppr.cxx
index 5f9ee099c37e..2b528bc3b4e9 100644
--- a/xmloff/source/text/txtimppr.cxx
+++ b/xmloff/source/text/txtimppr.cxx
@@ -277,9 +277,9 @@ isNotDefaultRelSize(const XMLPropertyState* pRelState, const rtl::Reference<XMLP
* four side, we have to duplicate the compressed attribute during import.
**/
void lcl_SeparateBorder(
- sal_uInt16 nIndex, XMLPropertyState* pAllBorderDistance,
+ sal_uInt16 nIndex, XMLPropertyState const * pAllBorderDistance,
XMLPropertyState* pBorderDistances[4], XMLPropertyState* pNewBorderDistances[4],
- XMLPropertyState* pAllBorder, XMLPropertyState* pBorders[4],
+ XMLPropertyState const * pAllBorder, XMLPropertyState* pBorders[4],
XMLPropertyState* pNewBorders[4], XMLPropertyState* pAllBorderWidth,
XMLPropertyState* pBorderWidths[4]
#if OSL_DEBUG_LEVEL > 0
More information about the Libreoffice-commits
mailing list