[Libreoffice-commits] core.git: i18nlangtag/source include/i18nlangtag

Jochen Nitschke j.nitschke+logerrit at ok.de
Fri Nov 10 06:48:51 UTC 2017


 i18nlangtag/source/languagetag/languagetag.cxx |   32 -------------------------
 include/i18nlangtag/languagetag.hxx            |    2 -
 2 files changed, 34 deletions(-)

New commits:
commit d12699bab3eab6e29f0667f042148e5634c9efe4
Author: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Date:   Thu Nov 9 21:01:51 2017 +0100

    clang-tidy modernize-use-equals-default LanguageTag
    
    mbIsFallback was added to ctor but not to copy assignment in
    commit 258d9fac7544f925c8250bad99b9554cc49578d5
        CID#1103756 missing initialization
    
    Change-Id: I91ee5daf68c3c3682b5d7007c028eaf3579a0715
    Reviewed-on: https://gerrit.libreoffice.org/44563
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/i18nlangtag/source/languagetag/languagetag.cxx b/i18nlangtag/source/languagetag/languagetag.cxx
index 3f887de7d6c1..28842ccace6d 100644
--- a/i18nlangtag/source/languagetag/languagetag.cxx
+++ b/i18nlangtag/source/languagetag/languagetag.cxx
@@ -561,38 +561,6 @@ LanguageTag::LanguageTag( const rtl_Locale & rLocale )
 }
 
 
-LanguageTag::LanguageTag( const LanguageTag & rLanguageTag )
-    :
-        maLocale( rLanguageTag.maLocale),
-        maBcp47( rLanguageTag.maBcp47),
-        mnLangID( rLanguageTag.mnLangID),
-        mpImpl( rLanguageTag.mpImpl),
-        mbSystemLocale( rLanguageTag.mbSystemLocale),
-        mbInitializedBcp47( rLanguageTag.mbInitializedBcp47),
-        mbInitializedLocale( rLanguageTag.mbInitializedLocale),
-        mbInitializedLangID( rLanguageTag.mbInitializedLangID),
-        mbIsFallback(rLanguageTag.mbIsFallback)
-{
-}
-
-
-LanguageTag& LanguageTag::operator=( const LanguageTag & rLanguageTag )
-{
-    if (&rLanguageTag == this)
-        return *this;
-
-    maLocale            = rLanguageTag.maLocale;
-    maBcp47             = rLanguageTag.maBcp47;
-    mnLangID            = rLanguageTag.mnLangID;
-    mpImpl              = rLanguageTag.mpImpl;
-    mbSystemLocale      = rLanguageTag.mbSystemLocale;
-    mbInitializedBcp47  = rLanguageTag.mbInitializedBcp47;
-    mbInitializedLocale = rLanguageTag.mbInitializedLocale;
-    mbInitializedLangID = rLanguageTag.mbInitializedLangID;
-    return *this;
-}
-
-
 LanguageTag::~LanguageTag()
 {
 }
diff --git a/include/i18nlangtag/languagetag.hxx b/include/i18nlangtag/languagetag.hxx
index 42da7cc88179..a9937205ef8c 100644
--- a/include/i18nlangtag/languagetag.hxx
+++ b/include/i18nlangtag/languagetag.hxx
@@ -107,9 +107,7 @@ public:
      */
     explicit LanguageTag( const rtl_Locale & rLocale );
 
-    LanguageTag( const LanguageTag & rLanguageTag );
     ~LanguageTag();
-    LanguageTag& operator=( const LanguageTag & rLanguageTag );
 
     /** Obtain BCP 47 language tag.
 


More information about the Libreoffice-commits mailing list