[Libreoffice-commits] core.git: compilerplugins/clang

Stephan Bergmann sbergman at redhat.com
Fri Nov 10 07:52:23 UTC 2017


 compilerplugins/clang/unnecessaryoverride.cxx |    2 --
 1 file changed, 2 deletions(-)

New commits:
commit d4ee66c15e8c57f2de54d1306128f6546dfb6e8d
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Fri Nov 10 08:51:43 2017 +0100

    No need to check both (identical) param_size() and getNumParams()
    
    Change-Id: I481cfa8b0f4bb9cbc257d28f36c372fb7367f294

diff --git a/compilerplugins/clang/unnecessaryoverride.cxx b/compilerplugins/clang/unnecessaryoverride.cxx
index eb3dabb26f60..7a0431a2bf44 100644
--- a/compilerplugins/clang/unnecessaryoverride.cxx
+++ b/compilerplugins/clang/unnecessaryoverride.cxx
@@ -410,8 +410,6 @@ const CXXMethodDecl* UnnecessaryOverride::findOverriddenOrSimilarMethodInSupercl
             {
                 continue;
             }
-            if (methodDecl->param_size() != baseMethod->param_size())
-                continue;
             if (methodDecl->getNumParams() != baseMethod->getNumParams())
                 continue;
             bool bParamsMatch = true;


More information about the Libreoffice-commits mailing list