[Libreoffice-commits] core.git: include/comphelper

Stephan Bergmann sbergman at redhat.com
Fri Nov 10 23:03:43 UTC 2017


 include/comphelper/propertyvalue.hxx |   12 ------------
 1 file changed, 12 deletions(-)

New commits:
commit f697d06b67e91c704c088dceafade209462e0b95
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Fri Nov 10 17:29:43 2017 +0100

    Remove unnecessary makePropertyValue specialization for Any
    
    ...that had been introduced with 9e87a00e11486a2be64b0dc2799e3efca4b000cc "oox:
    replace PUT_PROP macro with comphelper::makePropertyValue() calls", but for
    reasons unclear to me.  toAny is specifically there to either wrap its argument
    in an Any or, if the argument already is an Any, pass it on unwrapped.  There
    is no deleted toAny overloads or explicit specializations.
    
    Change-Id: I63edf22ba3a63f6b3ebb3347ec5dc9ff81fd3bc4
    Reviewed-on: https://gerrit.libreoffice.org/44607
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/include/comphelper/propertyvalue.hxx b/include/comphelper/propertyvalue.hxx
index 185d6d1e29d0..ba442c12a931 100644
--- a/include/comphelper/propertyvalue.hxx
+++ b/include/comphelper/propertyvalue.hxx
@@ -30,18 +30,6 @@ template<typename T> css::beans::PropertyValue makePropertyValue(const OUString&
     return aValue;
 }
 
-/**
- * Overload for uno::Any where an additional toAny() is not needed (and is
- * actually a deleted function).
- */
-template<> inline css::beans::PropertyValue makePropertyValue(const OUString& rName, const css::uno::Any& rValue)
-{
-    css::beans::PropertyValue aValue;
-    aValue.Name = rName;
-    aValue.Value = rValue;
-    return aValue;
-}
-
 }
 
 #endif // INCLUDED_COMPHELPER_PROPERTYVALUE_HXX


More information about the Libreoffice-commits mailing list