[Libreoffice-commits] core.git: sc/source

[Julien Nabet]

 sc/source/ui/miscdlgs/datatableview.cxx |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 39ba5cbd8ca491aa322f48569ee5c10248e6e94b
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sun Nov 12 18:20:10 2017 +0100

    tdf#113784: fix crash when right click on data provider dialog
    
    Do like ScDataTableView::MouseButtonDown
        188 void ScDataTableView::MouseButtonDown(const MouseEvent& rMEvt)
        189 {
        190     if (!rMEvt.IsLeft())
        191         return;
    ...
    
    See bt:
    0  0x00007fffc971096c in Point::X() const (this=0x0) at /home/julien/lo/libreoffice/include/tools/gen.hxx:77
    1  0x00007fffc9c67f92 in Point::getX() const (this=0x0) at /home/julien/lo/libreoffice/include/tools/gen.hxx:98
    2  0x00007fffca04ca9f in ScDataTableView::MouseButtonUp(MouseEvent const&) (this=0x555558afbed0, rMEvt=...)
        at /home/julien/lo/libreoffice/sc/source/ui/miscdlgs/datatableview.cxx:242
    
    Change-Id: Ia124dcec698438b51072956949e3274a8e3f77c5
    Reviewed-on: https://gerrit.libreoffice.org/44651
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/sc/source/ui/miscdlgs/datatableview.cxx b/sc/source/ui/miscdlgs/datatableview.cxx
index 9429e0744b85..bc71ada433d2 100644
--- a/sc/source/ui/miscdlgs/datatableview.cxx
+++ b/sc/source/ui/miscdlgs/datatableview.cxx
@@ -239,6 +239,9 @@ SCROW findRowFromPos(sal_uInt16 nPixelPos, const ScDocument* pDoc, SCROW nStartR
 
 void ScDataTableView::MouseButtonUp(const MouseEvent& rMEvt)
 {
+    if (!rMEvt.IsLeft())
+        return;
+
     SCCOL nStartCol = findColFromPos(mpMouseEvent->GetPosPixel().getX(), mpDoc.get());
     SCCOL nEndCol = findColFromPos(rMEvt.GetPosPixel().getX(), mpDoc.get());
     SCROW nStartRow = findRowFromPos(mpMouseEvent->GetPosPixel().getY(), mpDoc.get());