[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - vcl/osx

Tor Lillqvist tml at collabora.com
Mon Nov 13 21:37:30 UTC 2017


 vcl/osx/salprn.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9f8429d81c08cc40d5b1210cb6e4b383316cdc75
Author: Tor Lillqvist <tml at collabora.com>
Date:   Mon Nov 13 15:18:13 2017 +0200

    Apparent fix for what seems like a copy-paste error by me in 2014
    
    (in 5f27a6864420815d0d0abc409333fec963536faf.) Whether this has
    anything to do with tdf#92190 is unclear. Some experimentation indeed
    seems to indicate that it fixes the problem, but I am not 100% sure.
    Reproducing the bug fully realistically would require using a printer
    with actual Letter size paper.
    
    Thanks to Telesto for noticing this copy-paste issue.
    
    Change-Id: I853aaaf2b7a19380dce908f93349b001bf3feb92
    Reviewed-on: https://gerrit.libreoffice.org/44679
    Reviewed-by: Tor Lillqvist <tml at collabora.com>
    Tested-by: Tor Lillqvist <tml at collabora.com>

diff --git a/vcl/osx/salprn.cxx b/vcl/osx/salprn.cxx
index 7d48ffa99d16..0b82d551fecd 100644
--- a/vcl/osx/salprn.cxx
+++ b/vcl/osx/salprn.cxx
@@ -65,7 +65,7 @@ AquaSalInfoPrinter::AquaSalInfoPrinter( const SalPrinterQueueInfo& i_rQueue ) :
         mpPrintInfo = [pShared copy];
         [mpPrintInfo setPrinter: mpPrinter];
 #if MACOSX_SDK_VERSION >= 1090
-        mePageOrientation = ([mpPrintInfo orientation] == NSPaperOrientationPortrait) ? Orientation::Landscape : Orientation::Portrait;
+        mePageOrientation = ([mpPrintInfo orientation] == NSPaperOrientationLandscape) ? Orientation::Landscape : Orientation::Portrait;
         [mpPrintInfo setOrientation: NSPaperOrientationPortrait];
 #else
         mePageOrientation = ([mpPrintInfo orientation] == NSLandscapeOrientation) ? Orientation::Landscape : Orientation::Portrait;


More information about the Libreoffice-commits mailing list