[Libreoffice-commits] core.git: sc/qa

Andrea Gelmini andrea.gelmini at gelma.net
Tue Nov 14 13:49:54 UTC 2017


 sc/qa/unit/pivottable_filters_test.cxx |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit e4e4097a95cc66785d5828f05dd43cb0cc98b845
Author: Andrea Gelmini <andrea.gelmini at gelma.net>
Date:   Tue Nov 14 11:46:39 2017 +0100

    Changed encoding from cp1252 to UTF-8
    
    In [54]: open("sc/qa/unit/pivottable_filters_test.cxx",'r').readlines()
    ---------------------------------------------------------------------------
    UnicodeDecodeError                        Traceback (most recent call last)
    <ipython-input-54-39091a82db4d> in <module>()
    ----> 1 open("sc/qa/unit/pivottable_filters_test.cxx",'r').readlines()
    
    /usr/lib/python3.6/codecs.py in decode(self, input, final)
        319         # decode input (taking the buffer into account)
        320         data = self.buffer + input
    --> 321         (result, consumed) = self._buffer_decode(data, self.errors, final)
        322         # keep undecoded input until the next call
        323         self.buffer = data[consumed:]
    
    UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 1648: invalid continuation byte
    
    In [55]: open("sc/qa/unit/pivottable_filters_test.cxx",'r',encoding="cp1252").readlines()
    Out[55]:
    ['/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */\n',
     '/*\n',
    ...
    
    Change-Id: Iad48bdf3502fcb6340e358249781a39d50f80c85
    Reviewed-on: https://gerrit.libreoffice.org/44708
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Eike Rathke <erack at redhat.com>

diff --git a/sc/qa/unit/pivottable_filters_test.cxx b/sc/qa/unit/pivottable_filters_test.cxx
index 167b68f0d773..79f8f002ee14 100755
--- a/sc/qa/unit/pivottable_filters_test.cxx
+++ b/sc/qa/unit/pivottable_filters_test.cxx
@@ -1382,15 +1382,15 @@ void ScPivotTableFiltersTest::testPivotTableDateFieldFilter()
         const ScDPSaveDimension::MemberList& rMembers = pSaveDim->GetMembers();
         CPPUNIT_ASSERT_EQUAL(size_t(3), rMembers.size());
         auto aIter = rMembers.begin();
-        ScDPSaveMember* pMember = *aIter; // "2016. január 6."
+        ScDPSaveMember* pMember = *aIter; // "2016. január 6."
         CPPUNIT_ASSERT(pMember);
         CPPUNIT_ASSERT(pMember->HasIsVisible() && pMember->GetIsVisible());
         ++aIter;
-        pMember = *aIter; // "2016. január 7."
+        pMember = *aIter; // "2016. január 7."
         CPPUNIT_ASSERT(pMember);
         CPPUNIT_ASSERT(pMember->HasIsVisible() && pMember->GetIsVisible());
         ++aIter;
-        pMember = *aIter; // "2016. január 8."
+        pMember = *aIter; // "2016. január 8."
         CPPUNIT_ASSERT(pMember);
         CPPUNIT_ASSERT(pMember->HasIsVisible() && !pMember->GetIsVisible());
     }
@@ -1875,11 +1875,11 @@ void ScPivotTableFiltersTest::testPivotTableDateFieldFilterXLSX()
         const ScDPSaveDimension::MemberList& rMembers = pSaveDim->GetMembers();
         //CPPUNIT_ASSERT_EQUAL(size_t(3), rMembers.size());
         auto aIter = rMembers.begin();
-        ScDPSaveMember* pMember = *aIter; // "2016. január 7."
+        ScDPSaveMember* pMember = *aIter; // "2016. január 7."
         CPPUNIT_ASSERT(pMember);
         CPPUNIT_ASSERT(pMember->HasIsVisible() && pMember->GetIsVisible());
         ++aIter;
-        pMember = *aIter; // "2016. január 8."
+        pMember = *aIter; // "2016. január 8."
         CPPUNIT_ASSERT(pMember);
         CPPUNIT_ASSERT(pMember->HasIsVisible() && !pMember->GetIsVisible());
     }


More information about the Libreoffice-commits mailing list