[Libreoffice-commits] core.git: 2 commits - svx/source sw/qa

[Caolán McNamara]

 svx/source/dialog/ClassificationDialog.cxx     |    1 +
 sw/qa/extras/tiledrendering/tiledrendering.cxx |    3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

New commits:
commit c2602c5f0eb6555dc5cbcfc74a02c0e3b0347e37
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Nov 15 09:14:12 2017 +0000

    coverity#1421163 Unchecked dynamic_cast
    
    and
    
    coverity#1421165 Unchecked dynamic_cast
    
    Change-Id: Iabd9560d41ec3ddbdb7a560b7839024b7749f917

diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index b55e775d0ba7..91f5f2235901 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -1828,12 +1828,13 @@ void SwTiledRenderingTest::testAllTrackedChanges()
 
     // view #1
     SwView* pView1 = dynamic_cast<SwView*>(SfxViewShell::Current());
+    CPPUNIT_ASSERT(pView1);
     SwWrtShell* pWrtShell1 = pView1->GetWrtShellPtr();
 
     // view #2
     SfxLokHelper::createView();
     SwView* pView2 = dynamic_cast<SwView*>(SfxViewShell::Current());
-    CPPUNIT_ASSERT(pView1 != pView2);
+    CPPUNIT_ASSERT(pView2 && pView1 != pView2);
     SwWrtShell* pWrtShell2 = pView2->GetWrtShellPtr();
     // Insert text and reject all
     {
commit 44844b60847af68b8b1b91137eb6af4b65979697
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Nov 15 09:09:51 2017 +0000

    coverity#1421071 Uninitializer scalar field
    
    Change-Id: I6b52c62574013ba242922227c2cbd7bfceea0e29

diff --git a/svx/source/dialog/ClassificationDialog.cxx b/svx/source/dialog/ClassificationDialog.cxx
index 34b5d1504344..0bb8e7892d4e 100644
--- a/svx/source/dialog/ClassificationDialog.cxx
+++ b/svx/source/dialog/ClassificationDialog.cxx
@@ -166,6 +166,7 @@ ClassificationDialog::ClassificationDialog(vcl::Window* pParent, const bool bPer
     , maInternationalHelper(SfxObjectShell::Current()->getDocProperties(), /*bUseLocalizedPolicy*/ false)
     , m_bPerParagraph(bPerParagraph)
     , m_aParagraphSignHandler(rParagraphSignHandler)
+    , m_nCurrentSelectedCategory(-1)
 {
     get(m_pOkButton, "ok");
     get(m_pEditWindow, "classificationEditWindow");