[Libreoffice-commits] core.git: compilerplugins/clang

Stephan Bergmann sbergman at redhat.com
Thu Nov 16 14:13:39 UTC 2017


 compilerplugins/clang/plugin.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 49027122436dc061768e1e781d36755ff041d4a9
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Nov 16 15:12:05 2017 +0100

    Avoid infinite loops in loplugin
    
    ...introduced with cab6e6836973a9ddfc5ed9df757e07138328c1c3 "Make
    checkIdenticalDefaultArguments more precise", causing older Clang to hang when
    compiling specific LO source files.
    
    Change-Id: I99cfcad2f0cd9adccd5aa84d21502f586762217f

diff --git a/compilerplugins/clang/plugin.cxx b/compilerplugins/clang/plugin.cxx
index 80fff7651ae0..ed179d9b2b65 100644
--- a/compilerplugins/clang/plugin.cxx
+++ b/compilerplugins/clang/plugin.cxx
@@ -292,6 +292,7 @@ Plugin::IdenticalDefaultArgumentsResult Plugin::checkIdenticalDefaultArguments(
         if (ce1->getNumArgs() == 0 && ce2->getNumArgs() == 0) {
             return IdenticalDefaultArgumentsResult::Yes;
         }
+        break;
     }
     return IdenticalDefaultArgumentsResult::Maybe;
 }


More information about the Libreoffice-commits mailing list