[Libreoffice-commits] core.git: sw/source

[Stephan Bergmann]

 sw/source/core/unocore/unoframe.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 0717f32de0fa96ccf353ac074d040df0f4e27751
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Nov 21 23:19:27 2017 +0100

    Missing GraphicObject destruction, memory leak
    
    ...causes e.g. a leftover temp file like
    _anonymous_namespace___WpftWriterFilterTest__test_9m9gdo.tmp in $TMPDIR during
    CppunitTest_writerperfect_writer's processing of
    writerperfect/qa/unit/data/writer/libwps/Write_3.1.wri.
    
    The code lacking the delete was originally introduced with
    e3911a61e60610d32d4f41ab0361ff495bbf3f95 "INTEGRATION: CWS fwk59: #i63867# let
    the replacement image be imported", then heavily modified with
    ec8258f3b78f6bc00a108fe0bef7656b86812b7d "INTEGRATION: CWS xmlfilter06".
    
    Change-Id: Ie0830d5f358e6d81efe0bb9ef04d6a206bd27201
    Reviewed-on: https://gerrit.libreoffice.org/45059
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sw/source/core/unocore/unoframe.cxx b/sw/source/core/unocore/unoframe.cxx
index 8ae5042534d0..d9c508893107 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -1667,6 +1667,7 @@ void SwXFrame::setPropertyValue(const OUString& rPropertyName, const ::uno::Any&
                     aGraphic = pGrfObj->GetGraphic();
                     bApply = true;
                 }
+                delete pGrfObj;
             }
             else
             {