[Libreoffice-commits] core.git: sccomp/qa

Stephan Bergmann sbergman at redhat.com
Sat Nov 25 03:20:44 UTC 2017


 sccomp/qa/unit/SwarmSolverTest.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1fa761af825641da5c87f80c2a17135f92418960
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Fri Nov 24 15:30:48 2017 +0100

    Ridiculously large delta for SwarmSolverTest::testUnconstrained for now
    
    At least the Jenkins lo_ubsan build sporadically keeps failing
    CppunitTest_sccomp_swarmsolvertest due to rather widely off values here
    (3.00064356398118 in <https://ci.libreoffice.org/job/lo_ubsan/736/console> and
    2.8639022684852 in <https://ci.libreoffice.org/job/lo_ubsan/738/console>), so
    suggestion by Tomaž Vajngerl was: "Let's adapt the delta for now. Generally
    anything close to 3 should be acceptable as the algorithm greatly depends on
    random values."
    
    Change-Id: Id8f8657e521381decb1c719a1cffdf959ae74ef4
    Reviewed-on: https://gerrit.libreoffice.org/45231
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Tomaž Vajngerl <quikee at gmail.com>

diff --git a/sccomp/qa/unit/SwarmSolverTest.cxx b/sccomp/qa/unit/SwarmSolverTest.cxx
index 918cd9103021..0be632dfb174 100644
--- a/sccomp/qa/unit/SwarmSolverTest.cxx
+++ b/sccomp/qa/unit/SwarmSolverTest.cxx
@@ -103,7 +103,7 @@ void SwarmSolverTest::testUnconstrained()
     uno::Sequence<double> aSolution = xSolver->getSolution();
 
     CPPUNIT_ASSERT_EQUAL(aSolution.getLength(), aVariables.getLength());
-    CPPUNIT_ASSERT_DOUBLES_EQUAL(3.0, aSolution[0], 1E-5);
+    CPPUNIT_ASSERT_DOUBLES_EQUAL(3.0, aSolution[0], .2);
 }
 
 void SwarmSolverTest::testVariableBounded()


More information about the Libreoffice-commits mailing list