[Libreoffice-commits] libvisio.git: src/lib

Miklos Vajna vmiklos at collabora.co.uk
Wed Nov 29 08:57:30 UTC 2017


 src/lib/VSDContentCollector.cpp |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 2baddb07cf518ca871d8969c694867d2d27c12d1
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Wed Nov 29 09:57:09 2017 +0100

    VSDContentCollector: remove dead shapeId assignment
    
    It's a by-value parameter, it's not read later in the function and the
    assignment scope only includes conditions (not loops), so it's not read
    later.
    
    Change-Id: I56bed45c71de892d388fa534f8512b27245daf3a

diff --git a/src/lib/VSDContentCollector.cpp b/src/lib/VSDContentCollector.cpp
index 87e0306..4c8aafa 100644
--- a/src/lib/VSDContentCollector.cpp
+++ b/src/lib/VSDContentCollector.cpp
@@ -475,7 +475,6 @@ void libvisio::VSDContentCollector::_flushCurrentPath(unsigned shapeId)
         librevenge::RVNGString stringId;
         stringId.sprintf("id%u", shapeId);
         propList.insert("draw:id", stringId);
-        shapeId = MINUS_ONE;
       }
       _appendVisibleAndPrintable(propList);
       m_shapeOutputDrawing->addPath(propList);


More information about the Libreoffice-commits mailing list