[Libreoffice-commits] core.git: include/oox include/toolkit include/vcl
Noel Grandin
noel.grandin at collabora.co.uk
Wed Nov 29 09:02:18 UTC 2017
include/oox/dump/dumperbase.hxx | 10 +++++-----
include/oox/export/drawingml.hxx | 8 ++++----
include/oox/export/vmlexport.hxx | 2 +-
include/toolkit/awt/scrollabledialog.hxx | 2 +-
include/vcl/BitmapTools.hxx | 2 +-
include/vcl/bitmap.hxx | 2 +-
include/vcl/idle.hxx | 4 ++--
include/vcl/opengl/OpenGLContext.hxx | 2 +-
include/vcl/timer.hxx | 2 +-
include/vcl/toolbox.hxx | 2 +-
include/vcl/wrkwin.hxx | 2 +-
11 files changed, 19 insertions(+), 19 deletions(-)
New commits:
commit 6a3413a2336433b1359db95cdf52eec0c93b632e
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Tue Nov 28 16:29:28 2017 +0200
loplugin:countusersofdefaultparams in include/oox..vcl
Change-Id: If831bce4cd1fe2c5233159b31c239b813629e0de
Reviewed-on: https://gerrit.libreoffice.org/45420
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/include/oox/dump/dumperbase.hxx b/include/oox/dump/dumperbase.hxx
index dcde6ff1808f..97a36f3699ba 100644
--- a/include/oox/dump/dumperbase.hxx
+++ b/include/oox/dump/dumperbase.hxx
@@ -248,8 +248,8 @@ class StringHelper
public:
// append string to string ------------------------------------------------
- static void appendChar( OUStringBuffer& rStr, sal_Unicode cChar, sal_Int32 nCount = 1 );
- static void appendString( OUStringBuffer& rStr, const OUString& rData, sal_Int32 nWidth = 0, sal_Unicode cFill = ' ' );
+ static void appendChar( OUStringBuffer& rStr, sal_Unicode cChar, sal_Int32 nCount );
+ static void appendString( OUStringBuffer& rStr, const OUString& rData, sal_Int32 nWidth, sal_Unicode cFill = ' ' );
// append decimal ---------------------------------------------------------
@@ -313,7 +313,7 @@ public:
// encoded text output ----------------------------------------------------
static void appendCChar( OUStringBuffer& rStr, sal_Unicode cChar, bool bPrefix = true );
- static void appendEncChar( OUStringBuffer& rStr, sal_Unicode cChar, sal_Int32 nCount = 1, bool bPrefix = true );
+ static void appendEncChar( OUStringBuffer& rStr, sal_Unicode cChar, sal_Int32 nCount, bool bPrefix = true );
static void appendEncString( OUStringBuffer& rStr, const OUString& rData, bool bPrefix = true );
// token list -------------------------------------------------------------
@@ -967,7 +967,7 @@ public:
void writeBin( Type nData, bool bDots = true )
{ StringHelper::appendBin( maLine, nData, bDots ); }
template< typename Type >
- void writeFix( Type nData, sal_Int32 nWidth = 0 )
+ void writeFix( Type nData, sal_Int32 nWidth )
{ StringHelper::appendFix( maLine, nData, nWidth ); }
template< typename Type >
void writeValue( Type nData, FormatType eFmtType )
@@ -1367,7 +1367,7 @@ protected:
virtual bool implIsValid() const override;
void skipBlock( sal_Int64 nBytes, bool bShowSize = true );
- void dumpRawBinary( sal_Int64 nBytes, bool bShowOffset = true, bool bStream = false );
+ void dumpRawBinary( sal_Int64 nBytes, bool bShowOffset, bool bStream = false );
void dumpBinary( const String& rName, sal_Int64 nBytes, bool bShowOffset = true );
void dumpRemaining( sal_Int64 nBytes );
diff --git a/include/oox/export/drawingml.hxx b/include/oox/export/drawingml.hxx
index 627bcc983706..2e0625c43ed9 100644
--- a/include/oox/export/drawingml.hxx
+++ b/include/oox/export/drawingml.hxx
@@ -150,7 +150,7 @@ protected:
static bool EqualGradients( css::awt::Gradient aGradient1, css::awt::Gradient aGradient2 );
public:
- DrawingML( ::sax_fastparser::FSHelperPtr pFS, ::oox::core::XmlFilterBase* pFB = nullptr, DocumentType eDocumentType = DOCUMENT_PPTX, DMLTextExport* pTextExport = nullptr )
+ DrawingML( ::sax_fastparser::FSHelperPtr pFS, ::oox::core::XmlFilterBase* pFB, DocumentType eDocumentType = DOCUMENT_PPTX, DMLTextExport* pTextExport = nullptr )
: meDocumentType( eDocumentType ), mpTextExport(pTextExport), mpFS( pFS ), mpFB( pFB ), mbIsBackgroundDark( false ) {}
void SetFS( ::sax_fastparser::FSHelperPtr pFS ) { mpFS = pFS; }
const ::sax_fastparser::FSHelperPtr& GetFS() { return mpFS; }
@@ -193,7 +193,7 @@ public:
void WriteLinespacing( const css::style::LineSpacing& rLineSpacing );
OUString WriteBlip( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet,
- const OUString& rURL, bool bRelPathToMedia = false , const Graphic *pGraphic=nullptr );
+ const OUString& rURL, bool bRelPathToMedia, const Graphic *pGraphic=nullptr );
void WriteBlipMode( const css::uno::Reference< css::beans::XPropertySet >& rXPropSet, const OUString& rURL );
void WriteShapeTransformation(const css::uno::Reference< css::drawing::XShape >& rXShape,
@@ -201,7 +201,7 @@ public:
void WriteTransformation(const tools::Rectangle& rRectangle,
sal_Int32 nXmlNamespace, bool bFlipH = false, bool bFlipV = false, sal_Int32 nRotation = 0, bool bIsGroupShape = false);
- void WriteText( const css::uno::Reference< css::uno::XInterface >& rXIface, const OUString& presetWarp, bool bBodyPr = true, bool bText = true, sal_Int32 nXmlNamespace = 0);
+ void WriteText( const css::uno::Reference< css::uno::XInterface >& rXIface, const OUString& presetWarp, bool bBodyPr, bool bText = true, sal_Int32 nXmlNamespace = 0);
void WriteParagraph( const css::uno::Reference< css::text::XTextContent >& rParagraph,
bool& rbOverridingCharHeight, sal_Int32& rnCharHeight );
void WriteParagraphProperties( const css::uno::Reference< css::text::XTextContent >& rParagraph );
@@ -244,7 +244,7 @@ public:
const css::uno::Reference< css::io::XOutputStream >& xParentRelation,
const char* sContentType,
const char* sRelationshipType,
- OUString* pRelationshipId = nullptr );
+ OUString* pRelationshipId );
};
diff --git a/include/oox/export/vmlexport.hxx b/include/oox/export/vmlexport.hxx
index c50c6a77a53e..0564eff65832 100644
--- a/include/oox/export/vmlexport.hxx
+++ b/include/oox/export/vmlexport.hxx
@@ -137,7 +137,7 @@ public:
OString AddSdrObject( const SdrObject& rObj, sal_Int16 eHOri = -1,
sal_Int16 eVOri = -1, sal_Int16 eHRel = -1,
sal_Int16 eVRel = -1, const bool bOOxmlExport = false );
- OString AddInlineSdrObject( const SdrObject& rObj, const bool bOOxmlExport = false );
+ OString AddInlineSdrObject( const SdrObject& rObj, const bool bOOxmlExport );
virtual void AddSdrObjectVMLObject( const SdrObject& rObj) override;
static bool IsWaterMarkShape(const OUString& rStr);
diff --git a/include/toolkit/awt/scrollabledialog.hxx b/include/toolkit/awt/scrollabledialog.hxx
index 83c0123717c9..14bc87ab027c 100644
--- a/include/toolkit/awt/scrollabledialog.hxx
+++ b/include/toolkit/awt/scrollabledialog.hxx
@@ -45,7 +45,7 @@ namespace toolkit
DECL_LINK( ScrollBarHdl, ScrollBar*, void );
public:
- ScrollableDialog( vcl::Window* pParent, WinBits nStyle = WB_STDDIALOG, Dialog::InitFlag eFlag = Dialog::InitFlag::Default );
+ ScrollableDialog( vcl::Window* pParent, WinBits nStyle, Dialog::InitFlag eFlag = Dialog::InitFlag::Default );
virtual ~ScrollableDialog() override;
virtual void dispose() override;
// Window
diff --git a/include/vcl/BitmapTools.hxx b/include/vcl/BitmapTools.hxx
index d46d34b43360..3517a9d0dd5c 100644
--- a/include/vcl/BitmapTools.hxx
+++ b/include/vcl/BitmapTools.hxx
@@ -20,7 +20,7 @@ namespace bitmap {
BitmapEx VCL_DLLPUBLIC loadFromName(const OUString& rFileName, const ImageLoadFlags eFlags = ImageLoadFlags::NONE);
-void loadFromSvg(SvStream& rStream, const OUString& sPath, BitmapEx& rBitmapEx, double fScaleFactor = 1.0);
+void loadFromSvg(SvStream& rStream, const OUString& sPath, BitmapEx& rBitmapEx, double fScaleFactor);
}} // end vcl::bitmap
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index 66a056448b53..f2cd512b3158 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -574,7 +574,7 @@ public:
const Color* pSearchColors,
const Color* rReplaceColors,
sal_uLong nColorCount,
- sal_uLong* pTols = nullptr );
+ sal_uLong* pTols );
/** Convert the bitmap to a meta file
diff --git a/include/vcl/idle.hxx b/include/vcl/idle.hxx
index 18d4e8abaab7..f58061313611 100644
--- a/include/vcl/idle.hxx
+++ b/include/vcl/idle.hxx
@@ -38,7 +38,7 @@ protected:
virtual sal_uInt64 UpdateMinPeriod(
sal_uInt64 nMinPeriod, sal_uInt64 nTimeNow ) const override;
- Idle( bool bAuto, const sal_Char *pDebugName = nullptr );
+ Idle( bool bAuto, const sal_Char *pDebugName );
public:
Idle( const sal_Char *pDebugName = nullptr );
@@ -58,7 +58,7 @@ public:
class VCL_DLLPUBLIC AutoIdle : public Idle
{
public:
- AutoIdle( const sal_Char *pDebugName = nullptr );
+ AutoIdle( const sal_Char *pDebugName );
};
diff --git a/include/vcl/opengl/OpenGLContext.hxx b/include/vcl/opengl/OpenGLContext.hxx
index 2df8f8c563fb..ad9ef72b824a 100644
--- a/include/vcl/opengl/OpenGLContext.hxx
+++ b/include/vcl/opengl/OpenGLContext.hxx
@@ -75,7 +75,7 @@ public:
void requestLegacyContext();
- bool init(vcl::Window* pParent = nullptr);
+ bool init(vcl::Window* pParent);
bool init(SystemChildWindow* pChildWindow);
void reset();
diff --git a/include/vcl/timer.hxx b/include/vcl/timer.hxx
index ad2206f1e41c..88f1558b8518 100644
--- a/include/vcl/timer.hxx
+++ b/include/vcl/timer.hxx
@@ -34,7 +34,7 @@ protected:
virtual sal_uInt64 UpdateMinPeriod(
sal_uInt64 nMinPeriod, sal_uInt64 nTimeNow ) const override;
- Timer( bool bAuto, const sal_Char *pDebugName = nullptr );
+ Timer( bool bAuto, const sal_Char *pDebugName );
public:
Timer( const sal_Char *pDebugName = nullptr );
diff --git a/include/vcl/toolbox.hxx b/include/vcl/toolbox.hxx
index e6d213027e60..df9120f305d2 100644
--- a/include/vcl/toolbox.hxx
+++ b/include/vcl/toolbox.hxx
@@ -327,7 +327,7 @@ public:
void CopyItem( const ToolBox& rToolBox, sal_uInt16 nItemId );
void Clear();
- void SetButtonType( ButtonType eNewType = ButtonType::SYMBOLONLY );
+ void SetButtonType( ButtonType eNewType );
ButtonType GetButtonType() const { return meButtonType; }
// sets a fixed button size (small, large or dontcare (==autosize))
diff --git a/include/vcl/wrkwin.hxx b/include/vcl/wrkwin.hxx
index ef8f28ab01cf..3d2c22840f44 100644
--- a/include/vcl/wrkwin.hxx
+++ b/include/vcl/wrkwin.hxx
@@ -79,7 +79,7 @@ public:
/**
@overload void ShowFullScreenMode(bool bFullScreenMode, sal_Int32 nDisplayScreen)
*/
- void ShowFullScreenMode( bool bFullScreenMode = true );
+ void ShowFullScreenMode( bool bFullScreenMode );
bool IsFullScreenMode() const { return mbFullScreenMode; }
void StartPresentationMode( bool bPresentation,
More information about the Libreoffice-commits
mailing list