[Libreoffice-commits] core.git: sc/inc sc/source
Noel Grandin
noel.grandin at collabora.co.uk
Wed Nov 29 11:41:20 UTC 2017
sc/inc/attarray.hxx | 2 +-
sc/inc/column.hxx | 6 +++---
sc/inc/filter.hxx | 2 +-
sc/inc/rangelst.hxx | 2 +-
sc/inc/scabstdlg.hxx | 4 ++--
sc/inc/scmod.hxx | 2 +-
sc/inc/table.hxx | 4 ++--
sc/inc/viewopti.hxx | 4 ++--
sc/source/core/opencl/formulagroupcl.cxx | 8 ++++----
sc/source/filter/inc/ftools.hxx | 2 +-
sc/source/filter/inc/tokstack.hxx | 4 ++--
sc/source/filter/inc/xepivot.hxx | 2 +-
sc/source/filter/inc/xichart.hxx | 2 +-
sc/source/ui/attrdlg/scdlgfact.hxx | 4 ++--
sc/source/ui/inc/docfunc.hxx | 3 ++-
sc/source/ui/inc/viewfunc.hxx | 2 +-
sc/source/ui/vba/vbapalette.hxx | 2 +-
sc/source/ui/vba/vbatitle.hxx | 5 ++++-
18 files changed, 32 insertions(+), 28 deletions(-)
New commits:
commit e231ada19e14a4bae4b919c63a4e0227989f80d6
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Wed Nov 29 09:52:06 2017 +0200
loplugin:countusersofdefaultparams in sc
Change-Id: I8e790f9253279c9135ea1a4bcdd663ae7df44015
Reviewed-on: https://gerrit.libreoffice.org/45464
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/sc/inc/attarray.hxx b/sc/inc/attarray.hxx
index ccfb1bb8120a..f8d7d53b88f6 100644
--- a/sc/inc/attarray.hxx
+++ b/sc/inc/attarray.hxx
@@ -109,7 +109,7 @@ friend class ScHorizontalAttrIterator;
ScAttrArray& operator=(const ScAttrArray&) = delete;
public:
- ScAttrArray( SCCOL nNewCol, SCTAB nNewTab, ScDocument* pDoc, ScAttrArray* pNextColAttrArray = nullptr );
+ ScAttrArray( SCCOL nNewCol, SCTAB nNewTab, ScDocument* pDoc, ScAttrArray* pNextColAttrArray );
~ScAttrArray();
void SetTab(SCTAB nNewTab) { nTab = nNewTab; }
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index acd899e7658a..c9c55e85b92e 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -188,7 +188,7 @@ public:
ScColumn();
~ScColumn() COVERITY_NOEXCEPT_FALSE;
- void Init(SCCOL nNewCol, SCTAB nNewTab, ScDocument* pDoc, bool bEmptyAttrArray = false);
+ void Init(SCCOL nNewCol, SCTAB nNewTab, ScDocument* pDoc, bool bEmptyAttrArray);
ScDocument& GetDoc() { return *pDocument;}
const ScDocument& GetDoc() const { return *pDocument;}
@@ -385,7 +385,7 @@ public:
bool HasStringCells( SCROW nStartRow, SCROW nEndRow ) const;
sc::MultiDataCellState::StateType HasDataCellsInRange(
- SCROW nRow1, SCROW nRow2, SCROW* pRow1 = nullptr ) const;
+ SCROW nRow1, SCROW nRow2, SCROW* pRow1 ) const;
bool IsFormulaDirty( SCROW nRow ) const;
@@ -500,7 +500,7 @@ public:
void RemoveProtected( SCROW nStartRow, SCROW nEndRow );
- SCROW ApplySelectionCache( SfxItemPoolCache* pCache, const ScMarkData& rMark, ScEditDataArray* pDataArray, bool* const pIsChanged = nullptr );
+ SCROW ApplySelectionCache( SfxItemPoolCache* pCache, const ScMarkData& rMark, ScEditDataArray* pDataArray, bool* const pIsChanged );
void DeleteSelection( InsertDeleteFlags nDelFlag, const ScMarkData& rMark, bool bBroadcast );
void ClearSelectionItems( const sal_uInt16* pWhich, const ScMarkData& rMark );
diff --git a/sc/inc/filter.hxx b/sc/inc/filter.hxx
index 5bef4a0e07d0..56e25f55b6e9 100644
--- a/sc/inc/filter.hxx
+++ b/sc/inc/filter.hxx
@@ -69,7 +69,7 @@ class SAL_DLLPUBLIC_RTTI ScFormatFilterPlugin {
const rtl_TextEncoding eSrc ) = 0;
virtual ErrCode ScImportRTF( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange ) = 0;
virtual ErrCode ScImportHTML( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange, double nOutputFactor,
- bool bCalcWidthHeight, SvNumberFormatter* pFormatter = nullptr, bool bConvertDate = true ) = 0;
+ bool bCalcWidthHeight, SvNumberFormatter* pFormatter, bool bConvertDate = true ) = 0;
// various import helpers
virtual ScEEAbsImport *CreateRTFImport( ScDocument* pDoc, const ScRange& rRange ) = 0;
diff --git a/sc/inc/rangelst.hxx b/sc/inc/rangelst.hxx
index 932a5ed52d6d..d9f4067a3899 100644
--- a/sc/inc/rangelst.hxx
+++ b/sc/inc/rangelst.hxx
@@ -43,7 +43,7 @@ public:
formula::FormulaGrammar::AddressConvention eConv = formula::FormulaGrammar::CONV_OOO,
SCTAB nDefaultTab = 0, sal_Unicode cDelimiter = 0 );
- void Format( OUString&, ScRefFlags nFlags, ScDocument* = nullptr,
+ void Format( OUString&, ScRefFlags nFlags, ScDocument*,
formula::FormulaGrammar::AddressConvention eConv = formula::FormulaGrammar::CONV_OOO,
sal_Unicode cDelimiter = 0 ) const;
diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx
index edb52e238a67..32757d2c9f2e 100644
--- a/sc/inc/scabstdlg.hxx
+++ b/sc/inc/scabstdlg.hxx
@@ -462,7 +462,7 @@ public:
long nDefault,
FieldUnit eFUnit,
sal_uInt16 nDecimals,
- long nMaximum = 1000,
+ long nMaximum,
long nMinimum = 0 ) = 0;
virtual VclPtr<AbstractScMoveTableDlg> CreateScMoveTableDlg(vcl::Window * pParent,
@@ -516,7 +516,7 @@ public:
virtual VclPtr<AbstractScImportOptionsDlg> CreateScImportOptionsDlg ( bool bAscii,
const ScImportOptions* pOptions,
- const OUString* pStrTitle = nullptr,
+ const OUString* pStrTitle,
bool bOnlyDbtoolsEncodings = false,
bool bImport = true ) = 0;
diff --git a/sc/inc/scmod.hxx b/sc/inc/scmod.hxx
index 78a433e7d511..9b9ca89be7e8 100644
--- a/sc/inc/scmod.hxx
+++ b/sc/inc/scmod.hxx
@@ -210,7 +210,7 @@ public:
ScInputHandler* GetRefInputHdl() { return pRefInputHandler;}
void ViewShellGone(const ScTabViewShell* pViewSh);
- void ViewShellChanged(bool bStopEditing = true);
+ void ViewShellChanged(bool bStopEditing);
// communication with function-autopilot
void InputGetSelection( sal_Int32& rStart, sal_Int32& rEnd );
void InputSetSelection( sal_Int32 nStart, sal_Int32 nEnd );
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index 3721e2226a5a..e9f47167dab0 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -577,7 +577,7 @@ public:
bool ShrinkToUsedDataArea( bool& o_bShrunk, SCCOL& rStartCol, SCROW& rStartRow,
SCCOL& rEndCol, SCROW& rEndRow, bool bColumnsOnly,
- bool bStickyTopRow, bool bStickyLeftCol, bool bConsiderCellNotes=false ) const;
+ bool bStickyTopRow, bool bStickyLeftCol, bool bConsiderCellNotes ) const;
SCROW GetLastDataRow( SCCOL nCol1, SCCOL nCol2, SCROW nLastRow ) const;
@@ -794,7 +794,7 @@ public:
sal_uInt16 GetColWidth( SCCOL nCol, bool bHiddenAsZero = true ) const;
sal_uLong GetColWidth( SCCOL nStartCol, SCCOL nEndCol ) const;
- SC_DLLPUBLIC sal_uInt16 GetRowHeight( SCROW nRow, SCROW* pStartRow, SCROW* pEndRow = nullptr, bool bHiddenAsZero = true ) const;
+ SC_DLLPUBLIC sal_uInt16 GetRowHeight( SCROW nRow, SCROW* pStartRow, SCROW* pEndRow, bool bHiddenAsZero = true ) const;
sal_uLong GetRowHeight( SCROW nStartRow, SCROW nEndRow, bool bHiddenAsZero = true ) const;
sal_uLong GetScaledRowHeight( SCROW nStartRow, SCROW nEndRow, double fScale ) const;
sal_uLong GetColOffset( SCCOL nCol, bool bHiddenAsZero = true ) const;
diff --git a/sc/inc/viewopti.hxx b/sc/inc/viewopti.hxx
index 0d64499a8901..0eae517d78a1 100644
--- a/sc/inc/viewopti.hxx
+++ b/sc/inc/viewopti.hxx
@@ -85,8 +85,8 @@ public:
void SetDefaults();
- void SetOption( ScViewOption eOpt, bool bNew = true ) { aOptArr[eOpt] = bNew; }
- bool GetOption( ScViewOption eOpt ) const { return aOptArr[eOpt]; }
+ void SetOption( ScViewOption eOpt, bool bNew ) { aOptArr[eOpt] = bNew; }
+ bool GetOption( ScViewOption eOpt ) const { return aOptArr[eOpt]; }
void SetObjMode( ScVObjType eObj, ScVObjMode eMode ) { aModeArr[eObj] = eMode; }
ScVObjMode GetObjMode( ScVObjType eObj ) const { return aModeArr[eObj]; }
diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx
index 872f59edf15a..0aed2c51bcee 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -920,7 +920,7 @@ class DynamicKernelSlidingArgument : public Base
public:
DynamicKernelSlidingArgument( const ScCalcConfig& config, const std::string& s,
FormulaTreeNodeRef ft, std::shared_ptr<SlidingFunctionBase>& CodeGen,
- int index = 0 ) :
+ int index ) :
Base(config, s, ft, index), mpCodeGen(CodeGen)
{
FormulaToken* t = ft->GetFormulaToken();
@@ -1094,7 +1094,7 @@ class DynamicKernelMixedSlidingArgument : public VectorRef
public:
DynamicKernelMixedSlidingArgument( const ScCalcConfig& config, const std::string& s,
const FormulaTreeNodeRef& ft, std::shared_ptr<SlidingFunctionBase>& CodeGen,
- int index = 0 ) :
+ int index ) :
VectorRef(config, s, ft),
mDoubleArgument(mCalcConfig, s, ft, CodeGen, index),
mStringArgument(mCalcConfig, s + "s", ft, CodeGen, index) { }
@@ -1205,7 +1205,7 @@ class ParallelReductionVectorRef : public Base
public:
ParallelReductionVectorRef( const ScCalcConfig& config, const std::string& s,
FormulaTreeNodeRef ft, std::shared_ptr<SlidingFunctionBase>& CodeGen,
- int index = 0 ) :
+ int index ) :
Base(config, s, ft, index), mpCodeGen(CodeGen), mpClmem2(nullptr)
{
FormulaToken* t = ft->GetFormulaToken();
@@ -1395,7 +1395,7 @@ public:
}
}
- virtual std::string GenSlidingWindowDeclRef( bool = false ) const
+ virtual std::string GenSlidingWindowDeclRef( bool ) const
{
std::stringstream ss;
if (!bIsStartFixed && !bIsEndFixed)
diff --git a/sc/source/filter/inc/ftools.hxx b/sc/source/filter/inc/ftools.hxx
index 086ba65fb4d2..13fb359831ea 100644
--- a/sc/source/filter/inc/ftools.hxx
+++ b/sc/source/filter/inc/ftools.hxx
@@ -275,7 +275,7 @@ public:
virtual ErrCode ScImportRTF( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange ) override;
virtual ErrCode ScImportHTML( SvStream&, const OUString& rBaseURL, ScDocument*, ScRange& rRange,
double nOutputFactor, bool bCalcWidthHeight,
- SvNumberFormatter* pFormatter = nullptr, bool bConvertDate = true ) override;
+ SvNumberFormatter* pFormatter, bool bConvertDate = true ) override;
virtual ScEEAbsImport *CreateRTFImport( ScDocument* pDoc, const ScRange& rRange ) override;
virtual ScEEAbsImport *CreateHTMLImport( ScDocument* pDocP, const OUString& rBaseURL, const ScRange& rRange ) override;
diff --git a/sc/source/filter/inc/tokstack.hxx b/sc/source/filter/inc/tokstack.hxx
index 1e7e0eeb1582..c218ab5661d0 100644
--- a/sc/source/filter/inc/tokstack.hxx
+++ b/sc/source/filter/inc/tokstack.hxx
@@ -100,7 +100,7 @@ struct TokenPoolPool
return true;
}
/** Returns the new number of elements, or 0 if overflow. */
- static sal_uInt16 lcl_canGrow( sal_uInt16 nOld, sal_uInt16 nByMin = 1 )
+ static sal_uInt16 lcl_canGrow( sal_uInt16 nOld, sal_uInt16 nByMin )
{
if (!nOld)
return nByMin ? nByMin : 1;
@@ -213,7 +213,7 @@ private:
#endif
ScTokenArray* pScToken; // Token array
- bool GrowTripel( sal_uInt16 nByMin = 1 );
+ bool GrowTripel( sal_uInt16 nByMin );
bool GrowId();
bool GrowElement();
bool GrowMatrix();
diff --git a/sc/source/filter/inc/xepivot.hxx b/sc/source/filter/inc/xepivot.hxx
index 27b38ad3b073..38464e2523fe 100644
--- a/sc/source/filter/inc/xepivot.hxx
+++ b/sc/source/filter/inc/xepivot.hxx
@@ -43,7 +43,7 @@ public:
explicit XclExpPCItem( double fValue, const OUString& rText = OUString() );
explicit XclExpPCItem( const DateTime& rDateTime, const OUString& rText = OUString() );
explicit XclExpPCItem( sal_Int16 nValue );
- explicit XclExpPCItem( bool bValue, const OUString& rText = OUString() );
+ explicit XclExpPCItem( bool bValue, const OUString& rText );
sal_uInt16 GetTypeFlag() const { return mnTypeFlag; }
diff --git a/sc/source/filter/inc/xichart.hxx b/sc/source/filter/inc/xichart.hxx
index bbba69a88cb5..d1e3f4efcde8 100644
--- a/sc/source/filter/inc/xichart.hxx
+++ b/sc/source/filter/inc/xichart.hxx
@@ -507,7 +507,7 @@ public:
/** Converts and writes the contained number format to the passed property set. */
void ConvertNumFmt( ScfPropertySet& rPropSet, bool bPercent ) const;
/** Converts and writes all contained data to the passed data point label property set. */
- void ConvertDataLabel( ScfPropertySet& rPropSet, const XclChTypeInfo& rTypeInfo, const ScfPropertySet* pGlobalPropSet = nullptr ) const;
+ void ConvertDataLabel( ScfPropertySet& rPropSet, const XclChTypeInfo& rTypeInfo, const ScfPropertySet* pGlobalPropSet ) const;
/** Creates a title text object. */
css::uno::Reference< css::chart2::XTitle >
CreateTitle() const;
diff --git a/sc/source/ui/attrdlg/scdlgfact.hxx b/sc/source/ui/attrdlg/scdlgfact.hxx
index f167952383c8..5684f1245825 100644
--- a/sc/source/ui/attrdlg/scdlgfact.hxx
+++ b/sc/source/ui/attrdlg/scdlgfact.hxx
@@ -456,7 +456,7 @@ public:
long nDefault,
FieldUnit eFUnit,
sal_uInt16 nDecimals,
- long nMaximum = 1000,
+ long nMaximum,
long nMinimum = 0 ) override;
virtual VclPtr<AbstractScMoveTableDlg> CreateScMoveTableDlg(vcl::Window * pParent,
@@ -510,7 +510,7 @@ public:
virtual VclPtr<AbstractScImportOptionsDlg> CreateScImportOptionsDlg ( bool bAscii,
const ScImportOptions* pOptions,
- const OUString* pStrTitle = nullptr,
+ const OUString* pStrTitle,
bool bOnlyDbtoolsEncodings = false,
bool bImport = true ) override;
virtual VclPtr<SfxAbstractTabDialog> CreateScAttrDlg( vcl::Window* pParent,
diff --git a/sc/source/ui/inc/docfunc.hxx b/sc/source/ui/inc/docfunc.hxx
index 80298ec48e1b..00e48f29b9eb 100644
--- a/sc/source/ui/inc/docfunc.hxx
+++ b/sc/source/ui/inc/docfunc.hxx
@@ -193,7 +193,8 @@ public:
bool UnmergeCells( const ScRange& rRange, bool bRecord, ScUndoRemoveMerge* pUndoRemoveMerge );
bool UnmergeCells( const ScCellMergeOption& rOption, bool bRecord, ScUndoRemoveMerge* pUndoRemoveMerge );
- void SetNewRangeNames( ScRangeName* pNewRanges, bool bModifyDoc, SCTAB nTab = -1 ); // takes ownership of pNewRanges //nTab = -1 for local range names
+ // takes ownership of pNewRanges, nTab = -1 for local range names
+ void SetNewRangeNames( ScRangeName* pNewRanges, bool bModifyDoc, SCTAB nTab );
void ModifyRangeNames( const ScRangeName& rNewRanges, SCTAB nTab = -1 );
/**
* Modify all range names, global scope names as well as sheet local ones,
diff --git a/sc/source/ui/inc/viewfunc.hxx b/sc/source/ui/inc/viewfunc.hxx
index 91f8dcb3708a..552dc52172ec 100644
--- a/sc/source/ui/inc/viewfunc.hxx
+++ b/sc/source/ui/inc/viewfunc.hxx
@@ -99,7 +99,7 @@ public:
void EnterDataAtCursor( const OUString& rString ); //! Not used?
SC_DLLPUBLIC void CutToClip();
- SC_DLLPUBLIC bool CopyToClip( ScDocument* pClipDoc, bool bCut = false, bool bApi = false,
+ SC_DLLPUBLIC bool CopyToClip( ScDocument* pClipDoc, bool bCut, bool bApi = false,
bool bIncludeObjects = false, bool bStopEdit = true );
SC_DLLPUBLIC bool CopyToClip( ScDocument* pClipDoc, const ScRangeList& rRange, bool bCut,
bool bApi = false, bool bIncludeObjects = false, bool bStopEdit = true );
diff --git a/sc/source/ui/vba/vbapalette.hxx b/sc/source/ui/vba/vbapalette.hxx
index 3f5ef8b0eed6..8a643837488e 100644
--- a/sc/source/ui/vba/vbapalette.hxx
+++ b/sc/source/ui/vba/vbapalette.hxx
@@ -34,7 +34,7 @@ class ScVbaPalette
private:
SfxObjectShell* m_pShell;
public:
- explicit ScVbaPalette( SfxObjectShell* pShell = nullptr ) : m_pShell( pShell ) {}
+ explicit ScVbaPalette( SfxObjectShell* pShell ) : m_pShell( pShell ) {}
explicit ScVbaPalette( const css::uno::Reference< css::frame::XModel >& rxModel );
// if no palette available e.g. because the document doesn't have a
// palette defined then a default palette will be returned.
diff --git a/sc/source/ui/vba/vbatitle.hxx b/sc/source/ui/vba/vbatitle.hxx
index 972579f41d49..06078ef66f55 100644
--- a/sc/source/ui/vba/vbatitle.hxx
+++ b/sc/source/ui/vba/vbatitle.hxx
@@ -42,7 +42,10 @@ protected:
std::unique_ptr<ov::ShapeHelper> oShapeHelper;
ScVbaPalette m_Palette;
public:
- TitleImpl( const css::uno::Reference< ov::XHelperInterface >& xParent, const css::uno::Reference< css::uno::XComponentContext >& xContext, const css::uno::Reference< css::drawing::XShape >& _xTitleShape ) : BaseClass( xParent, xContext ), xTitleShape( _xTitleShape )
+ TitleImpl( const css::uno::Reference< ov::XHelperInterface >& xParent,
+ const css::uno::Reference< css::uno::XComponentContext >& xContext,
+ const css::uno::Reference< css::drawing::XShape >& _xTitleShape )
+ : BaseClass( xParent, xContext ), xTitleShape( _xTitleShape ), m_Palette(nullptr)
{
xShapePropertySet.set( xTitleShape, css::uno::UNO_QUERY_THROW );
oShapeHelper.reset( new ov::ShapeHelper(xTitleShape) );
More information about the Libreoffice-commits
mailing list