[Libreoffice-commits] core.git: 2 commits - connectivity/source

Eike Rathke erack at redhat.com
Fri Oct 13 08:34:11 UTC 2017


 connectivity/source/commontools/predicateinput.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 643e9001bff137b6e5a8784d9e1f25a51e0d1644
Author: Eike Rathke <erack at redhat.com>
Date:   Thu Oct 12 16:05:22 2017 +0200

    Do not cast sal_Unicode separator to sal_Char
    
    ... living in an ASCII world?
    
    Change-Id: I82912924420766734573a10b2e110fef6fcadd1c
    Reviewed-on: https://gerrit.libreoffice.org/43343
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Eike Rathke <erack at redhat.com>

diff --git a/connectivity/source/commontools/predicateinput.cxx b/connectivity/source/commontools/predicateinput.cxx
index 79ebda070cc6..06764a4f34ea 100644
--- a/connectivity/source/commontools/predicateinput.cxx
+++ b/connectivity/source/commontools/predicateinput.cxx
@@ -64,7 +64,7 @@ namespace dbtools
 
         sal_Unicode nReturn( _nFallback );
         if ( !_rSeparator.isEmpty() )
-            nReturn = static_cast< sal_Char >( _rSeparator[0] );
+            nReturn = _rSeparator[0];
         return nReturn;
     }
 
commit 51b0200304c307c11f3878af0ed61d28e09f53bf
Author: Eike Rathke <erack at redhat.com>
Date:   Thu Oct 12 16:03:05 2017 +0200

    Correct copypasta decimal separator as group separator
    
    Quite certainly the decimal separator wasn't to be obtained twice
    and used as group separator the second time..
    
    Change-Id: I8fb1a066f7f33f377fc98f917aeadad74c41205b
    Reviewed-on: https://gerrit.libreoffice.org/43342
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Eike Rathke <erack at redhat.com>

diff --git a/connectivity/source/commontools/predicateinput.cxx b/connectivity/source/commontools/predicateinput.cxx
index c3c91fad6972..79ebda070cc6 100644
--- a/connectivity/source/commontools/predicateinput.cxx
+++ b/connectivity/source/commontools/predicateinput.cxx
@@ -79,7 +79,7 @@ namespace dbtools
             {
                 aLocaleData = m_xLocaleData->getLocaleItem( _rLocale );
                 _rDecSep = lcl_getSeparatorChar( aLocaleData.decimalSeparator, _rDecSep );
-                _rThdSep = lcl_getSeparatorChar( aLocaleData.decimalSeparator, _rThdSep );
+                _rThdSep = lcl_getSeparatorChar( aLocaleData.thousandSeparator, _rThdSep );
                 return true;
             }
         }


More information about the Libreoffice-commits mailing list