[Libreoffice-commits] core.git: svtools/source

Katarina Behrens Katarina.Behrens at cib.de
Sat Oct 28 01:41:53 UTC 2017


 svtools/source/dialogs/prnsetup.cxx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 51eb767eaf514ee8106401e364e75533fd6fcb51
Author: Katarina Behrens <Katarina.Behrens at cib.de>
Date:   Wed Oct 25 12:46:33 2017 +0200

    Related tdf#95694: Enable papersize & orientation listboxes
    
    when called from File > Printer Properties > Properties. Anything
    else doesn't make sense, user opens this dialog in order to be able
    to edit the settings
    
    Change-Id: I9559829551e6d6144da972757ab98afa5696bbfa
    Reviewed-on: https://gerrit.libreoffice.org/43823
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>

diff --git a/svtools/source/dialogs/prnsetup.cxx b/svtools/source/dialogs/prnsetup.cxx
index d7a8b06a7900..d3a46048b2dc 100644
--- a/svtools/source/dialogs/prnsetup.cxx
+++ b/svtools/source/dialogs/prnsetup.cxx
@@ -293,7 +293,10 @@ IMPL_LINK_NOARG(PrinterSetupDialog, ImplPropertiesHdl, Button*, void)
 {
     if ( !mpTempPrinter )
         mpTempPrinter = VclPtr<Printer>::Create( mpPrinter->GetJobSetup() );
-    mpTempPrinter->Setup( this );
+    // 2nd argument: whether paper size and orientation from printer settings
+    // override document settings, iow whether matching listboxes are editable
+    // (this is a printer setup dialog, so they definitely should be editable)
+    mpTempPrinter->Setup( this, true );
 }
 
 


More information about the Libreoffice-commits mailing list