[Libreoffice-commits] core.git: test/source

Jens Carl j.carl43 at gmx.de
Mon Oct 30 07:35:08 UTC 2017


 test/source/sheet/xsheetfilterable.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bf50220ac0ef2266dca188a4f485746b4cfb4096
Author: Jens Carl <j.carl43 at gmx.de>
Date:   Mon Oct 30 02:11:58 2017 +0000

    Fix xsheetfilterable CppUnit assert
    
    Change to Logical NOT operator to make
    clang loplugin:simplifybool happy.
    
    Change-Id: I95af212ea6fa33be2775824322bd64f04d2ac695
    Reviewed-on: https://gerrit.libreoffice.org/44039
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/test/source/sheet/xsheetfilterable.cxx b/test/source/sheet/xsheetfilterable.cxx
index 8539a4315bd5..369045aea858 100644
--- a/test/source/sheet/xsheetfilterable.cxx
+++ b/test/source/sheet/xsheetfilterable.cxx
@@ -80,7 +80,7 @@ void XSheetFilterable::testFilter()
     bool bIsVisible = true;
     CPPUNIT_ASSERT(xRowProps->getPropertyValue("IsVisible") >>= bIsVisible);
 
-    CPPUNIT_ASSERT_MESSAGE("Row 1 should be invisible", bIsVisible == false);
+    CPPUNIT_ASSERT_MESSAGE("Row 1 should be invisible", !bIsVisible);
 }
 
 }


More information about the Libreoffice-commits mailing list