[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sfx2/source

Julien Nabet serval2412 at yahoo.fr
Tue Sep 5 11:57:08 UTC 2017


 sfx2/source/dialog/templdlg.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 02b95a0e8191fc560637b2fa3a62bca0bd51b9c4
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Tue Aug 29 20:48:42 2017 +0200

    tdf#112027: avoid leaks in FillTreeBox (sfx2)
    
    Next step could be using std::unique_ptr<StyleTree_Impl>
    instead of StyleTree_Impl*
    
    Change-Id: Ifbf5313fedf1fc0310073918f91edd6fe75d0afc
    Reviewed-on: https://gerrit.libreoffice.org/41710
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    (cherry picked from commit c82e5db9626e4d84300f84842b837e852be828be)
    Reviewed-on: https://gerrit.libreoffice.org/41925
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx
index 48a874f34996..fdeaa9910a42 100644
--- a/sfx2/source/dialog/templdlg.cxx
+++ b/sfx2/source/dialog/templdlg.cxx
@@ -1044,6 +1044,7 @@ void SfxCommonTemplateDialog_Impl::FillTreeBox()
         for (sal_uInt16 i = 0; i < nCount; ++i)
         {
             FillBox_Impl(pTreeBox, aArr[i], aEntries, pItem->GetFamily(), nullptr);
+            delete aArr[i];
         }
         pTreeBox->Recalc();
 


More information about the Libreoffice-commits mailing list