[Libreoffice-commits] core.git: fpicker/source

[Jan-Marek Glogowski]

 fpicker/source/aqua/ControlHelper.mm |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 3fa8ff7734541c8cb12a5e80b6770cbc7a9347f1
Author: Jan-Marek Glogowski <glogow at fbihome.de>
Date:   Sat Sep 9 00:26:21 2017 +0200

    tdf#112289 OSX fpicker: don't default to true
    
    When LO requests a value for the currently unimplemented
    GPG encryption checkbox, the Aqua file picker defaults to
    a "uno::Any <<= true", which triggers the GPG key dialog.
    
    This simply returns an empty uno::Any for values of unknown
    controls, which is handled fine.
    
    If something else relies on the current default value, it
    must to be properly implemented.
    
    Change-Id: I3637ca833d59e19416e25f3096bc90a756aa8840

diff --git a/fpicker/source/aqua/ControlHelper.mm b/fpicker/source/aqua/ControlHelper.mm
index f645d2a4aecd..d0568b9a5ea1 100644
--- a/fpicker/source/aqua/ControlHelper.mm
+++ b/fpicker/source/aqua/ControlHelper.mm
@@ -348,7 +348,6 @@ uno::Any ControlHelper::getValue( sal_Int16 nControlId, sal_Int16 nControlAction
 
     if( pControl == nil ) {
         SAL_INFO("fpicker.aqua","get value for unknown control " << nControlId);
-        aRetval <<= true;
     } else {
         if( [pControl class] == [NSPopUpButton class] ) {
             aRetval = HandleGetListValue(pControl, nControlAction);