[Libreoffice-commits] core.git: .git-hooks/pre-commit

Caolán McNamara caolanm at redhat.com
Mon Sep 11 13:02:02 UTC 2017


 .git-hooks/pre-commit |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 354d460af2f74b74406967da63567e60a1fe782e
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Sep 11 12:13:20 2017 +0100

    insist in a domain in .ui files
    
    and just check .ui files for those .ui-specific patterns
    
    Change-Id: If7b9c8779f7592db5b22ab96058dd85666ca9bdf
    Reviewed-on: https://gerrit.libreoffice.org/42160
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/.git-hooks/pre-commit b/.git-hooks/pre-commit
index 07569905488b..e35156f012e6 100755
--- a/.git-hooks/pre-commit
+++ b/.git-hooks/pre-commit
@@ -86,17 +86,20 @@ sub check_whitespaces($)
             }
             if (/<property name="use_markup">True<\/property>/)
             {
-                bad_line("use font attributes instead of use-markup", $_, $src_limited);
+                bad_line("use font attributes instead of use-markup", $_, "ui");
             }
             if (/<property name="tooltip_markup"/ )
             {
-                bad_line("use tooltip_text instead of tooltip_markup", $_, $src_limited);
+                bad_line("use tooltip_text instead of tooltip_markup", $_, "ui");
             }
             if ((/translatable="yes"/) and not(/context=/))
             {
-                bad_line("translatable .ui file line without context", $_, $src_limited);
+                bad_line("translatable .ui file line without context", $_, "ui");
+            }
+            if ((/<interface/) and not(/domain=/))
+            {
+                bad_line(".ui file without translation domain", $_, "ui");
             }
-
         }
     }
     if ( $found_bad)


More information about the Libreoffice-commits mailing list