[Libreoffice-commits] core.git: cui/source

Julien Nabet serval2412 at yahoo.fr
Fri Sep 15 03:11:00 UTC 2017


 cui/source/options/optlingu.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 2126e549623b4cbf8c8488e8f20c9a43609b3a44
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Thu Sep 14 23:09:58 2017 +0200

    tdf#112393: avoid leak in LangSelectHdl_Impl (cui)
    
    by deleting userdata of entries containing in m_pModulesCLB
    
    Change-Id: Ie903b0cd0ccf16839ac7bed42b7bdbc1db4fa5ef
    Reviewed-on: https://gerrit.libreoffice.org/42308
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/cui/source/options/optlingu.cxx b/cui/source/options/optlingu.cxx
index 213bb29b69da..44fd520ba724 100644
--- a/cui/source/options/optlingu.cxx
+++ b/cui/source/options/optlingu.cxx
@@ -1823,6 +1823,8 @@ void SvxEditModulesDlg::dispose()
     delete pDefaultLinguData;
     pDefaultLinguData = nullptr;
     m_pLanguageLB.clear();
+    for(sal_uLong i = 0; i < m_pModulesCLB->GetEntryCount(); i++)
+        delete static_cast<ModuleUserData_Impl*>(m_pModulesCLB->GetEntry(i)->GetUserData());
     m_pModulesCLB.clear();
     m_pPrioUpPB.clear();
     m_pPrioDownPB.clear();


More information about the Libreoffice-commits mailing list