[Libreoffice-commits] core.git: sal/osl

Stephan Bergmann sbergman at redhat.com
Mon Sep 18 12:59:20 UTC 2017


 sal/osl/unx/thread.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0f3b52bc2c289dd5684b6661bf335e9aa92d48db
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Mon Sep 18 14:56:06 2017 +0200

    The '<= 0' check can go now
    
    ...after 0083b33650c2f584ceff6eeaf9ef6993bfe0ae9b "sal: -Werror,-Wsign-compare
    (32-bit)" cast the check against SAL_MAX_UINT32 to unsigned, anyway.  (And the
    check for == 0 is already handled in the platform-generic part below.)
    
    Change-Id: I0d0354cb9368bffef5d3aa835f865524d106a6f3

diff --git a/sal/osl/unx/thread.cxx b/sal/osl/unx/thread.cxx
index c2705c8c08cc..639e8b6cec26 100644
--- a/sal/osl/unx/thread.cxx
+++ b/sal/osl/unx/thread.cxx
@@ -625,7 +625,7 @@ static oslThreadIdentifier insertThreadId (pthread_t hThread)
 
 #if defined LINUX && ! defined __FreeBSD_kernel__
         long lin_tid = syscall(SYS_gettid);
-        if (lin_tid <= 0 || SAL_MAX_UINT32 < static_cast<unsigned long>(lin_tid))
+        if (SAL_MAX_UINT32 < static_cast<unsigned long>(lin_tid))
             std::abort();
         pEntry->Ident = static_cast<pid_t>(lin_tid);
 #elif defined MACOSX || defined IOS


More information about the Libreoffice-commits mailing list