[Libreoffice-commits] core.git: basctl/source

Jochen Nitschke j.nitschke+logerrit at ok.de
Thu Sep 21 05:07:04 UTC 2017


 basctl/source/accessibility/accessibledialogwindow.cxx |   22 -----------------
 basctl/source/basicide/scriptdocument.cxx              |   11 --------
 basctl/source/inc/accessibledialogwindow.hxx           |    4 ---
 basctl/source/inc/scriptdocument.hxx                   |    6 ----
 4 files changed, 43 deletions(-)

New commits:
commit 4067487eb304c6686a22319c51790e41e311de08
Author: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Date:   Wed Sep 20 10:15:11 2017 +0200

    clang-tidy modernize-use-equals-default in basctl
    
    to find unneeded explicit defined or default able
    copy assignments and copy constructors.
    Remove the default destructor if it's not needed.
    
    Change-Id: I8c53a8622a53398889397132ec1f464e996ac49d
    Reviewed-on: https://gerrit.libreoffice.org/42525
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/basctl/source/accessibility/accessibledialogwindow.cxx b/basctl/source/accessibility/accessibledialogwindow.cxx
index 6d306466052c..473f698d53d8 100644
--- a/basctl/source/accessibility/accessibledialogwindow.cxx
+++ b/basctl/source/accessibility/accessibledialogwindow.cxx
@@ -53,28 +53,6 @@ AccessibleDialogWindow::ChildDescriptor::ChildDescriptor( DlgEdObj* _pDlgEdObj )
 {
 }
 
-
-AccessibleDialogWindow::ChildDescriptor::~ChildDescriptor()
-{
-}
-
-
-AccessibleDialogWindow::ChildDescriptor::ChildDescriptor( const ChildDescriptor& rDesc )
-    :pDlgEdObj( rDesc.pDlgEdObj )
-    ,rxAccessible( rDesc.rxAccessible )
-{
-}
-
-
-AccessibleDialogWindow::ChildDescriptor& AccessibleDialogWindow::ChildDescriptor::operator=( const ChildDescriptor& rDesc )
-{
-    pDlgEdObj = rDesc.pDlgEdObj;
-    rxAccessible = rDesc.rxAccessible;
-
-    return *this;
-}
-
-
 bool AccessibleDialogWindow::ChildDescriptor::operator==( const ChildDescriptor& rDesc )
 {
     bool bRet = false;
diff --git a/basctl/source/basicide/scriptdocument.cxx b/basctl/source/basicide/scriptdocument.cxx
index 9078948e4d2b..5bbbc0a9ee1a 100644
--- a/basctl/source/basicide/scriptdocument.cxx
+++ b/basctl/source/basicide/scriptdocument.cxx
@@ -1044,17 +1044,6 @@ namespace basctl
     }
 
 
-    ScriptDocument::ScriptDocument( const ScriptDocument& _rSource )
-        :m_pImpl( _rSource.m_pImpl )
-    {
-    }
-
-
-    ScriptDocument::~ScriptDocument()
-    {
-    }
-
-
     const ScriptDocument& ScriptDocument::getApplicationScriptDocument()
     {
         static ScriptDocument s_aApplicationScripts;
diff --git a/basctl/source/inc/accessibledialogwindow.hxx b/basctl/source/inc/accessibledialogwindow.hxx
index badcabda17d3..98397bb185cb 100644
--- a/basctl/source/inc/accessibledialogwindow.hxx
+++ b/basctl/source/inc/accessibledialogwindow.hxx
@@ -64,10 +64,6 @@ private:
         css::uno::Reference< css::accessibility::XAccessible >    rxAccessible;
 
         ChildDescriptor( DlgEdObj* _pDlgEdObj );
-        ~ChildDescriptor();
-
-        ChildDescriptor( const ChildDescriptor& rDesc );
-        ChildDescriptor& operator=( const ChildDescriptor& rDesc );
 
         bool operator==( const ChildDescriptor& rDesc );
         bool operator<( const ChildDescriptor& rDesc ) const;
diff --git a/basctl/source/inc/scriptdocument.hxx b/basctl/source/inc/scriptdocument.hxx
index f30719097deb..e03c66546a2e 100644
--- a/basctl/source/inc/scriptdocument.hxx
+++ b/basctl/source/inc/scriptdocument.hxx
@@ -96,12 +96,6 @@ namespace basctl
         */
         explicit    ScriptDocument( const css::uno::Reference< css::frame::XModel >& _rxDocument );
 
-        /// copy constructor
-                    ScriptDocument( const ScriptDocument& _rSource );
-
-        /// destructor
-                    ~ScriptDocument();
-
         /** returns a reference to a shared ScriptDocument instance which
             operates on the application-wide scripts and dialogs
         */


More information about the Libreoffice-commits mailing list