[Libreoffice-commits] core.git: xmlsecurity/qa

Stephan Bergmann sbergman at redhat.com
Thu Sep 21 20:04:10 UTC 2017


 xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 462454b7e0aea2d067352e33f320198a850e0127
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Sep 21 17:29:29 2017 +0200

    Map from GetLastError() to HRESULT
    
    clang-cl reported "error: comparison of integers of different signs: 'DWORD'
    (aka 'unsigned long') and 'HRESULT' (aka 'long') [-Werror,-Wsign-compare]"
    
    Change-Id: I568f03bd863ba63e30143483d9573042f3506de7
    Reviewed-on: https://gerrit.libreoffice.org/42597
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>
    Tested-by: Jenkins <ci at libreoffice.org>

diff --git a/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx b/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx
index c3da91797458..642a034ae5e1 100644
--- a/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx
+++ b/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx
@@ -190,7 +190,7 @@ bool PDFSigningTest::sign(const OUString& rInURL, const OUString& rOutURL, size_
                 if (!bSignResult)
                 {
                     DWORD dwErr = GetLastError();
-                    if (dwErr == CRYPT_E_NO_KEY_PROPERTY)
+                    if (HRESULT_FROM_WIN32(dwErr) == CRYPT_E_NO_KEY_PROPERTY)
                     {
                         SAL_WARN("xmlsecurity.pdfio.test", "Skipping a certificate without a private key");
                         continue; // The certificate does not have a private key - not a valid certificate


More information about the Libreoffice-commits mailing list