[Libreoffice-commits] core.git: include/vcl vcl/unx

[Michael Stahl]

 include/vcl/ppdparser.hxx             |    1 -
 vcl/unx/generic/printer/ppdparser.cxx |    4 ----
 2 files changed, 5 deletions(-)

New commits:
commit ba4151219a5c010e840396e30bc408383e474327
Author: Michael Stahl <mstahl at redhat.com>
Date:   Fri Sep 22 11:21:08 2017 +0200

    vcl: [loplugin:badstatics] PPDParser
    
    class PPDContext actually looks harmless but it has an out-of-line
    destructor so the plugin can't see that it's harmless, so use
    default destructor instead.
    
    Change-Id: I921a4cdaeb5c8fe286615162b9e9c2a8db47b300
    Reviewed-on: https://gerrit.libreoffice.org/42633
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Michael Stahl <mstahl at redhat.com>

diff --git a/include/vcl/ppdparser.hxx b/include/vcl/ppdparser.hxx
index ecbda153af79..16f93e080e76 100644
--- a/include/vcl/ppdparser.hxx
+++ b/include/vcl/ppdparser.hxx
@@ -255,7 +255,6 @@ public:
     PPDContext( const PPDContext& rContext ) { operator=( rContext ); }
     PPDContext& operator=( const PPDContext& rContext );
     PPDContext& operator=( PPDContext&& rContext );
-    ~PPDContext();
 
     void setParser( const PPDParser* );
     const PPDParser* getParser() const { return m_pParser; }
diff --git a/vcl/unx/generic/printer/ppdparser.cxx b/vcl/unx/generic/printer/ppdparser.cxx
index 4efe108f5e9b..60df9da4b33e 100644
--- a/vcl/unx/generic/printer/ppdparser.cxx
+++ b/vcl/unx/generic/printer/ppdparser.cxx
@@ -1678,10 +1678,6 @@ PPDContext& PPDContext::operator=( PPDContext&& rCopy )
     return *this;
 }
 
-PPDContext::~PPDContext()
-{
-}
-
 const PPDKey* PPDContext::getModifiedKey( int n ) const
 {
     hash_type::const_iterator it;