[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sw/qa

Tor Lillqvist tml at collabora.com
Fri Sep 22 18:43:50 UTC 2017


 sw/qa/extras/ooxmlexport/ooxmlexport3.cxx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit b012ddbf39eaa51a05aec590f35e2f4d46cddd57
Author: Tor Lillqvist <tml at collabora.com>
Date:   Thu Apr 13 17:36:24 2017 +0300

    Make the testTdf106974_int32Crop pass on my Mac
    
    For some reason, on my Mac the Right value is 41226, both times the
    function gets called. (On my Linux box, it is 46387 and 46394.) So
    compare to 41000 instead of 46000.
    Or would it be better to just bypass the test on macOS, as we already
    do for other tests in this file...?
    (cherry picked from commit 1391f3702a3daaefc67a8ee4b62ac38959db283f)
    
    Make the testTdf106974_int32Crop pass on my Mac, too
    
    cf. 1391f3702a3daaefc67a8ee4b62ac38959db283f "Make the testTdf106974_int32Crop
    pass on my Mac".  For some reason, on my Mac the Right value is 40474 resp.
    40471 the two times the function gets called.
    (cherry picked from commit a900c72c675c8605fc004a4f63ba1d82eaeed9d5)
    
    Change-Id: I731ff9c5cf76be9d4817ad14f296807017d10dbd
    Reviewed-on: https://gerrit.libreoffice.org/42642
    Reviewed-by: Michael Stahl <mstahl at redhat.com>
    Tested-by: Jenkins <ci at libreoffice.org>

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
index 6844e3ead9fc..34c885db2b28 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
@@ -639,7 +639,10 @@ DECLARE_OOXMLEXPORT_TEST(testTdf106974_int32Crop, "tdf106974_int32Crop.docx")
     css::text::GraphicCrop aGraphicCropStruct;
 
     imageProperties->getPropertyValue( "GraphicCrop" ) >>= aGraphicCropStruct;
-    CPPUNIT_ASSERT( sal_Int32( 46000 ) < aGraphicCropStruct.Right );
+
+    CPPUNIT_ASSERT_MESSAGE(
+        OString::number(aGraphicCropStruct.Right).getStr(),
+        sal_Int32( 40470 ) < aGraphicCropStruct.Right );
 }
 
 DECLARE_OOXMLEXPORT_TEST(testLineSpacingexport, "test_line_spacing.docx")


More information about the Libreoffice-commits mailing list