[Libreoffice-commits] core.git: desktop/source

Gabor Kelemen kelemeng at ubuntu.com
Tue Apr 10 07:36:40 UTC 2018


 desktop/source/deployment/gui/dp_gui.h                     |    1 -
 desktop/source/deployment/gui/dp_gui_dependencydialog.cxx  |    2 --
 desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx |    1 +
 desktop/source/deployment/gui/dp_gui_extlistbox.cxx        |    1 +
 desktop/source/deployment/gui/dp_gui_service.cxx           |    1 -
 desktop/source/deployment/gui/license_dialog.cxx           |    2 --
 desktop/source/deployment/manager/dp_manager.cxx           |    1 +
 desktop/source/deployment/manager/dp_manager.h             |    1 -
 desktop/source/deployment/misc/dp_ucb.cxx                  |    1 -
 9 files changed, 3 insertions(+), 8 deletions(-)

New commits:
commit 342a5d13dfcca37a68cb996650e1ada868c5ce3e
Author: Gabor Kelemen <kelemeng at ubuntu.com>
Date:   Sun Mar 18 16:30:00 2018 +0100

    tdf#42949 Remove unnecessary localization headers from desktop
    
    Found by searching for the header names and the localization function:
    git grep -l -e \<dp_shared.hxx\> -e \<strings.hrc\> desktop | xargs grep -c DpResId | grep :0$ | grep -v /pch
    
    Change-Id: I6608eb94c7572040ae20ce8a3926f3a522ee66bd
    Reviewed-on: https://gerrit.libreoffice.org/52593
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/desktop/source/deployment/gui/dp_gui.h b/desktop/source/deployment/gui/dp_gui.h
index 494eae85939f..e60109ad710b 100644
--- a/desktop/source/deployment/gui/dp_gui.h
+++ b/desktop/source/deployment/gui/dp_gui.h
@@ -22,7 +22,6 @@
 
 #include "dp_gui_updatedata.hxx"
 #include <dp_misc.h>
-#include <strings.hrc>
 #include <rtl/ref.hxx>
 #include <rtl/instance.hxx>
 #include <osl/thread.hxx>
diff --git a/desktop/source/deployment/gui/dp_gui_dependencydialog.cxx b/desktop/source/deployment/gui/dp_gui_dependencydialog.cxx
index 1ddda6e43794..ab150968ba1c 100644
--- a/desktop/source/deployment/gui/dp_gui_dependencydialog.cxx
+++ b/desktop/source/deployment/gui/dp_gui_dependencydialog.cxx
@@ -26,9 +26,7 @@
 #include <rtl/ustring.hxx>
 #include <vcl/dialog.hxx>
 
-#include <strings.hrc>
 #include "dp_gui_dependencydialog.hxx"
-#include <dp_shared.hxx>
 
 namespace vcl { class Window; }
 
diff --git a/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx b/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx
index 423e52e65744..8ceaf58f3a31 100644
--- a/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx
+++ b/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx
@@ -70,6 +70,7 @@
 #include "dp_gui_dependencydialog.hxx"
 #include "dp_gui_dialog2.hxx"
 #include <dp_shared.hxx>
+#include <strings.hrc>
 #include "dp_gui_theextmgr.hxx"
 #include "dp_gui_updatedialog.hxx"
 #include "dp_gui_updateinstalldialog.hxx"
diff --git a/desktop/source/deployment/gui/dp_gui_extlistbox.cxx b/desktop/source/deployment/gui/dp_gui_extlistbox.cxx
index fd0d98fc049b..60bc41d003e5 100644
--- a/desktop/source/deployment/gui/dp_gui_extlistbox.cxx
+++ b/desktop/source/deployment/gui/dp_gui_extlistbox.cxx
@@ -20,6 +20,7 @@
 #include <svtools/controldims.hxx>
 
 #include <dp_shared.hxx>
+#include <strings.hrc>
 #include "dp_gui.h"
 #include "dp_gui_extlistbox.hxx"
 #include "dp_gui_theextmgr.hxx"
diff --git a/desktop/source/deployment/gui/dp_gui_service.cxx b/desktop/source/deployment/gui/dp_gui_service.cxx
index 1f93cdd49fb7..d91cdc3e9d5a 100644
--- a/desktop/source/deployment/gui/dp_gui_service.cxx
+++ b/desktop/source/deployment/gui/dp_gui_service.cxx
@@ -19,7 +19,6 @@
 
 
 #include <memory>
-#include <dp_shared.hxx>
 #include "dp_gui.h"
 #include "dp_gui_theextmgr.hxx"
 #include <cppuhelper/implbase.hxx>
diff --git a/desktop/source/deployment/gui/license_dialog.cxx b/desktop/source/deployment/gui/license_dialog.cxx
index 0fa3678cc838..1bab915f178b 100644
--- a/desktop/source/deployment/gui/license_dialog.cxx
+++ b/desktop/source/deployment/gui/license_dialog.cxx
@@ -33,9 +33,7 @@
 #include <vcl/threadex.hxx>
 #include <vcl/builderfactory.hxx>
 
-#include <dp_shared.hxx>
 #include "license_dialog.hxx"
-#include <strings.hrc>
 
 #include <functional>
 
diff --git a/desktop/source/deployment/manager/dp_manager.cxx b/desktop/source/deployment/manager/dp_manager.cxx
index b46bc24ff197..3618ec5cd4eb 100644
--- a/desktop/source/deployment/manager/dp_manager.cxx
+++ b/desktop/source/deployment/manager/dp_manager.cxx
@@ -21,6 +21,7 @@
 
 #include <dp_registry.hxx>
 #include <dp_shared.hxx>
+#include <strings.hrc>
 #include <dp_ucb.h>
 #include <dp_resource.h>
 #include <dp_platform.hxx>
diff --git a/desktop/source/deployment/manager/dp_manager.h b/desktop/source/deployment/manager/dp_manager.h
index f3002a88d163..3f2168695e5a 100644
--- a/desktop/source/deployment/manager/dp_manager.h
+++ b/desktop/source/deployment/manager/dp_manager.h
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_DESKTOP_SOURCE_DEPLOYMENT_MANAGER_DP_MANAGER_H
 #define INCLUDED_DESKTOP_SOURCE_DEPLOYMENT_MANAGER_DP_MANAGER_H
 
-#include <strings.hrc>
 #include <dp_misc.h>
 #include <dp_interact.h>
 #include "dp_activepackages.hxx"
diff --git a/desktop/source/deployment/misc/dp_ucb.cxx b/desktop/source/deployment/misc/dp_ucb.cxx
index c27adf7383a8..be62722ffc43 100644
--- a/desktop/source/deployment/misc/dp_ucb.cxx
+++ b/desktop/source/deployment/misc/dp_ucb.cxx
@@ -18,7 +18,6 @@
  */
 
 
-#include <strings.hrc>
 #include <dp_misc.h>
 #include <dp_ucb.h>
 #include <rtl/uri.hxx>


More information about the Libreoffice-commits mailing list