[Libreoffice-commits] core.git: linguistic/source

Michael Meeks michael.meeks at collabora.com
Mon Apr 16 20:50:58 UTC 2018


 linguistic/source/gciterator.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 08364d213091e47b91b5fd044c7cda7e71d2647b
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Fri Apr 13 23:28:33 2018 +0100

    Defer grammar checker thread creation until use.
    
    Avoid this thread being started and stranded in the forkit.
    
    Change-Id: Ia79cdac729a85960c2b5a83af265d67af07b74aa
    Reviewed-on: https://gerrit.libreoffice.org/52980
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

diff --git a/linguistic/source/gciterator.cxx b/linguistic/source/gciterator.cxx
index 0f59515dcc15..b1dce0de8543 100644
--- a/linguistic/source/gciterator.cxx
+++ b/linguistic/source/gciterator.cxx
@@ -241,7 +241,7 @@ GrammarCheckingIterator::GrammarCheckingIterator() :
     m_aEventListeners( MyMutex::get() ),
     m_aNotifyListeners( MyMutex::get() )
 {
-    m_thread = osl_createThread( lcl_workerfunc, this );
+    m_thread = nullptr;
 }
 
 
@@ -321,6 +321,8 @@ void GrammarCheckingIterator::AddEntry(
 
         // add new entry to the end of this queue
         ::osl::Guard< ::osl::Mutex > aGuard( MyMutex::get() );
+        if (!m_thread)
+            m_thread = osl_createThread( lcl_workerfunc, this );
         m_aFPEntriesQueue.push_back( aNewFPEntry );
 
         // wake up the thread in order to do grammar checking


More information about the Libreoffice-commits mailing list